From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#41897: 28.0.50; JavaScript comment filling with mhtml-mode Date: Thu, 25 Jun 2020 14:49:57 -0600 Message-ID: <87v9jeeuq2.fsf@tromey.com> References: <20200620171827.7855.qmail@mail.muc.de> <87d05ta8z9.fsf@simenheg@gmail.com> <20200622191750.GA11506@ACM> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="100471"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Simen =?UTF-8?Q?Heggest=C3=B8yl?= , 41897@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 25 22:51:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1joYpy-000Q15-VM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jun 2020 22:51:10 +0200 Original-Received: from localhost ([::1]:45380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joYpx-0004Be-Kr for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jun 2020 16:51:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joYpq-0004BC-Ch for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2020 16:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58005) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1joYpq-0004iE-3B for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2020 16:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1joYpq-0001lR-1Q for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2020 16:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jun 2020 20:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41897 X-GNU-PR-Package: emacs Original-Received: via spool by 41897-submit@debbugs.gnu.org id=B41897.15931182066707 (code B ref 41897); Thu, 25 Jun 2020 20:51:01 +0000 Original-Received: (at 41897) by debbugs.gnu.org; 25 Jun 2020 20:50:06 +0000 Original-Received: from localhost ([127.0.0.1]:41317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joYov-0001k5-RV for submit@debbugs.gnu.org; Thu, 25 Jun 2020 16:50:06 -0400 Original-Received: from gateway24.websitewelcome.com ([192.185.51.35]:32471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joYop-0001jU-VC for 41897@debbugs.gnu.org; Thu, 25 Jun 2020 16:50:03 -0400 Original-Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway24.websitewelcome.com (Postfix) with ESMTP id F1A40AB13 for <41897@debbugs.gnu.org>; Thu, 25 Jun 2020 15:49:58 -0500 (CDT) Original-Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id oYooj8JDLzOauoYoojPS4g; Thu, 25 Jun 2020 15:49:58 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vUleD2vZe+wEgvhB/oXdH6YF5M5jrVLNzFJw1NNkb8c=; b=GtYx7iWgEVAfpCyWoaGXvxBDy5 2MV3+LCM7K8nPitXay73/dgvbJ63nywzVJabik0fKmT4kU5OaxwChJ77Zq0xdef6R7CnhAq/8hnnM zPb4rpNw7a+ijyJ0EEcAIAnKB; Original-Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:58408 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1joYoo-0031OC-Jw; Thu, 25 Jun 2020 14:49:58 -0600 In-Reply-To: <20200622191750.GA11506@ACM> (Alan Mackenzie's message of "Mon, 22 Jun 2020 19:17:50 +0000") X-Attribution: Tom X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1joYoo-0031OC-Jw X-Source-Sender: 174-16-104-48.hlrn.qwest.net (bapiya) [174.16.104.48]:58408 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182393 Archived-At: >>>>> "Alan" == Alan Mackenzie writes: Alan> (ii) An enhancement to CC Mode, used by mhtml-mode and js-mode, which Alan> invalidates a CC Mode cache used by the filling code. This gets rid of Alan> a few strange looking bugs; I wonder if js-mode can be changed not to use cc-mode like this. Looking at js.el, it seems like this is the origin of a use of advice in-core, which is generally frowned upon: ;; FIXME: Such redefinitions are bad style. We should try and use some other ;; way to get the same result. (defun js--fill-c-advice (js-fun) ... Tom