From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36597: 27.0.50; rehash hash tables eagerly in pdumper Date: Mon, 10 Aug 2020 15:04:18 +0200 Message-ID: <87v9hq4ppp.fsf@gnus.org> References: <6a260307-a463-bd08-8a10-d7664d0606a2@cs.ucla.edu> <74235afc-7043-1da7-7c71-07f0ca23b9fd@cs.ucla.edu> <83r26mv53z.fsf@gnu.org> <87ft8vbow1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23892"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Paul Eggert , 36597@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 10 15:05:44 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k57Uk-000643-KX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 15:05:42 +0200 Original-Received: from localhost ([::1]:55758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k57Uj-0003bq-Mw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 09:05:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k57U7-00034l-8P for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 09:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k57U6-0005eY-VK for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 09:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k57U6-0007Et-Qj for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 09:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Aug 2020 13:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36597-submit@debbugs.gnu.org id=B36597.159706467127739 (code B ref 36597); Mon, 10 Aug 2020 13:05:02 +0000 Original-Received: (at 36597) by debbugs.gnu.org; 10 Aug 2020 13:04:31 +0000 Original-Received: from localhost ([127.0.0.1]:34894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k57Tb-0007DK-J7 for submit@debbugs.gnu.org; Mon, 10 Aug 2020 09:04:31 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k57TZ-0007D7-TZ for 36597@debbugs.gnu.org; Mon, 10 Aug 2020 09:04:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=L8GTLXuwGNogLngbwlFAB6hti1drZql3333hYiz2W6Q=; b=eZO94GH5WoPgJeg6c60XaESXlX STF6vmbTEUStRT/Qrmmy23GyGXGFTUx+sbxVGT982WVdmdK82eT7TyNE0ct0cACpZ+uOMazIRNPLl r0iLSsBGRVXWw5gxsINN6XnGdXnWhbCF36D+x1e5H9PKr5q5682s1XgVOoVLvPlhMY3o=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k57TQ-000463-Fr; Mon, 10 Aug 2020 15:04:23 +0200 In-Reply-To: (Pip Cet's message of "Mon, 10 Aug 2020 11:51:42 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184502 Archived-At: Pip Cet writes: >> So I tried applying the patch now to Emacs 28 to do some benchmarking, >> but it didn't apply cleanly, so I gave up. > > I'll try to rebase them again. Does the attached work for you? Yup. I've now done some benchmarking with time make -j32 compile-always Without patch: real 0m38.855s real 0m40.295s real 0m39.299s real 0m39.864s real 0m40.428s real 0m40.012s real 0m38.988s real 0m39.807s real 0m40.455s real 0m37.341s real 0m33.349s real 0m34.379s real 0m34.339s real 0m33.139s real 0m32.902s real 0m33.755s real 0m34.143s real 0m34.598s real 0m34.484s real 0m34.342s With patch: real 0m36.064s real 0m36.617s real 0m34.502s real 0m36.817s real 0m31.782s real 0m32.859s real 0m29.779s real 0m29.703s real 0m30.313s real 0m29.496s real 0m29.585s real 0m29.807s real 0m30.235s real 0m30.142s real 0m29.960s real 0m30.067s real 0m30.114s real 0m29.975s real 0m30.388s real 0m30.112s Er... It's weird that there's so much difference in time between runs -- this is running on a machine that does nothing else and has a load of 0.0 if I'm not compiling Emacs. So I don't know what can be concluded here... if we just take the mean from these numbers, it seems that your patch is making compilation faster. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no