unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 24042@debbugs.gnu.org, Tassilo Horn <tsdh@gnu.org>
Subject: bug#24042: mudraw doesn't exist any more
Date: Fri, 04 Sep 2020 15:16:57 +0200	[thread overview]
Message-ID: <87v9gtadh2.fsf@gnus.org> (raw)
In-Reply-To: <jwvtwfkvw8u.fsf@iro.umontreal.ca> (Stefan Monnier's message of "Wed, 20 Jul 2016 17:24:17 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Apparently mudraw has been superseded by "mutool draw".  I'm using the
> patch below to accommodate this new situation, but it's not
> quite satisfactory.

It seems like this was fixed in a somewhat different way in this commit:

commit d5f629d193ffe88c464379f02dd2adaadc9dfdf0
Author:     Federico Tedin <federicotedin@gmail.com>
AuthorDate: Sun Feb 3 13:48:31 2019 -0300
Commit:     Tassilo Horn <tsdh@gnu.org>
CommitDate: Mon Feb 4 16:47:00 2019 +0100

But it's basically the same idea (and has the same problems as Stefan's
patch); it introduces this helper function:

(defun doc-view-pdfdraw-program-subcommand ()
  "Return the mutool subcommand replacing mudraw.
Recent MuPDF distributions replaced `mudraw' with `mutool draw'."
  (when (string-match "mutool[^/\\]*$" doc-view-pdfdraw-program)
    '("draw")))

I think a better solution would have been to allow the command to be a
list, for instance, so you could have '("mutool" "draw") be the command.

But I guess nobody has complained, so I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      parent reply	other threads:[~2020-09-04 13:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 21:24 bug#24042: mudraw doesn't exist any more Stefan Monnier
2016-07-20 22:53 ` Nicolas Petton
2016-07-21  1:17   ` Stefan Monnier
2016-07-21  1:33     ` Mark Oteiza
2016-07-21  1:55       ` Mark Oteiza
2016-07-21  3:46         ` Clément Pit--Claudel
2020-09-04 13:16 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9gtadh2.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=24042@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).