From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#44629: 28.0.50; Eglot noisy with gfm-view-mode and view-read-only Date: Sat, 14 Nov 2020 11:15:48 +0000 Message-ID: <87v9e8i3yz.fsf@tcd.ie> References: <875z68p5mr.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27323"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: 44629@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 14 12:16:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdtXM-0006ze-T9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Nov 2020 12:16:08 +0100 Original-Received: from localhost ([::1]:52524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdtXL-0001cS-GF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Nov 2020 06:16:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdtXG-0001cI-0x for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 06:16:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdtXF-0006ZI-Nx for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 06:16:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kdtXF-0007Y3-JU for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 06:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Nov 2020 11:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44629 X-GNU-PR-Package: emacs Original-Received: via spool by 44629-submit@debbugs.gnu.org id=B44629.160535256029008 (code B ref 44629); Sat, 14 Nov 2020 11:16:01 +0000 Original-Received: (at 44629) by debbugs.gnu.org; 14 Nov 2020 11:16:00 +0000 Original-Received: from localhost ([127.0.0.1]:49865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdtXE-0007Xn-4P for submit@debbugs.gnu.org; Sat, 14 Nov 2020 06:16:00 -0500 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:46084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdtXA-0007XW-If for 44629@debbugs.gnu.org; Sat, 14 Nov 2020 06:15:58 -0500 Original-Received: by mail-wr1-f54.google.com with SMTP id d12so13128383wrr.13 for <44629@debbugs.gnu.org>; Sat, 14 Nov 2020 03:15:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hF1mVhg6PyzH88DHQ85G57pMVbZNA1T+eackuMy7Eqc=; b=BRL7uQFBHBj4+L7RQBUcHHw/2Pm7sbvj2wBV75o0+IZmV0SOvNtaIu1/TMweh7ieWL MPpknKU9uL/38Df+8S3dIEgnZMEwKNjsMt9t+hQRRS/9MQu54Vz9KMwIQIbcJOSokyom F98fufCgQb5Y6yI6r71cASUeWyxmVDwxP9a0CGVPV5quBxpPZ4Ddq+W0jrqj6J56Dz/b 6o/WuU33zMj2pl2U/U04l10hsSZy7elcjTY2qVMvCJCWwRr0sj63dacOfM47lIB6Cstw hAuKFVUYUmnfNmOh672e974a/8+doNZ4z7EtowWSjMnpslY6MH+gWjO0gj11ok54dzPb jg9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hF1mVhg6PyzH88DHQ85G57pMVbZNA1T+eackuMy7Eqc=; b=SVD1SqxO81vStzWgojR3nkpNwZpwW9/aReXW5l760/zFue+rD8X5kINrELsmOYlvRD GTq8Lbl/GqfeNAEj9Qn39l3AueEMUgtT2fS/xFc30p8Q4xvmOSJ876PA93Lnf0AgaxI/ D1Jw6Rf6AyToYZMtb0xO22GxsqMe8x8dVEkyOL7tPToWDlUXtkwoCr7RlBm3vBmh2bUo Pcdu4WsZ/vgIPWRdaRD/GA8xXkmRkj1ZL/uWOqnaMdibZy3JUNPLxGsn746eGmKkmxAG wofADEZa7NYkUo3v5tBwI5vxSXxxaZZ7RY/epqQCO4C3Td5SDjqZsvv3PuaEPEdaGdL/ FPLQ== X-Gm-Message-State: AOAM530+mpdEVr4kow3QnGdjfhDx7bIMhRLiK5nIiakb87R1BWJlti9p VZ8/HwWEaw6CPH1BSUC2lnosR9QMJMBDxg== X-Google-Smtp-Source: ABdhPJzDl22BzbXfE0o7liuB/J22jD/NB0rug1HkuLml7zIFSrGai2KtgJhZiYtt/aPHOG2aUO/7EA== X-Received: by 2002:a05:6000:1050:: with SMTP id c16mr9401227wrx.400.1605352550540; Sat, 14 Nov 2020 03:15:50 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:fef1:a98a:87ca:e0e6]) by smtp.gmail.com with ESMTPSA id p12sm14462742wrw.28.2020.11.14.03.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2020 03:15:49 -0800 (PST) In-Reply-To: <875z68p5mr.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 14 Nov 2020 10:58:04 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193263 Archived-At: "Basil L. Contovounesios" writes: > The echo area is now taken over by the view-mode-enter message > "View mode: type C-h for help, h for commands, q to quit." > > This message also appears at various other stages of editing, but when > hovering over variables or flymake errors it seems to be the last one > standing in the echo area. > > This happens because eglot--format-markup calls gfm-view-mode, which in > turn enables read-only-mode, which in turn calls view-mode-enter. > > I can't disable this by setting view-read-only or > view-inhibit-help-message locally, since Eglot does its doc processing > in a different buffer. > > Perhaps Eglot could/should bind view-inhibit-help-message around > gfm-view-mode? Any other ideas? I tried advising eglot--format-markup to bind view-inhibit-help-message, which gets rid of the most annoying messages, but some still seem to emanate from jsonrpc, which calls read-only-mode in jsonrpc-events-buffer and initialize-instance. I'd rather not have to rely on advising internal functions, but maybe I can't have my cake and eat it, too. ;) -- Basil