From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44858: [PATCH] Make byte-compiler warn about wide docstrings Date: Thu, 26 Nov 2020 13:53:31 +0100 Message-ID: <87v9dss2ic.fsf@gnus.org> References: <87zh34wfxo.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1164"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44858@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 26 13:56:03 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiGob-000AbD-9C for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 13:56:01 +0100 Original-Received: from localhost ([::1]:52648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiGoa-0005qU-AJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 07:56:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiGmh-00047z-Lb for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 07:54:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiGmf-00007a-RH for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 07:54:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kiGmf-0003qa-Pg for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 07:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Nov 2020 12:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44858-submit@debbugs.gnu.org id=B44858.160639522414758 (code B ref 44858); Thu, 26 Nov 2020 12:54:01 +0000 Original-Received: (at 44858) by debbugs.gnu.org; 26 Nov 2020 12:53:44 +0000 Original-Received: from localhost ([127.0.0.1]:40078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiGmN-0003py-Le for submit@debbugs.gnu.org; Thu, 26 Nov 2020 07:53:43 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:50000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiGmL-0003pj-HO for 44858@debbugs.gnu.org; Thu, 26 Nov 2020 07:53:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6qC6TibTEnXE6/sr4JU0Iw57AmsDTFrdO1rND34CxKw=; b=lwraLfHGQeNJyCbvhrOc/NAQ6R +gHop30QKJW+sFVBv91pqNficQk5TNgkZ3055ir50AOTzMaPZC8Mhi3tF0rLt8WJ1NkmZKc1n0gKG 3sizc7QrEUXp5yyNr2kMdpZkBBIGpDNPwMw6+/XYnEi49TG7t0owX3fd3m4OUBEj1fHY=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiGmC-0001P2-5f; Thu, 26 Nov 2020 13:53:34 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEVvja90l8Y6ZZ49 OziJg3iXprT38dn////PMCpNAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QLGgwxNgmIHpEAAAFISURB VDjLpZTBboQgEIYHsvYMdvfu0qQvIH0Cxr23yp43jfL+j9ABQRfUtEn/xBjmY+aHCQDwPzEpxX6Y JFSQD8hMr23QMpuzmn6CM56AAq64uhJQ/t+oBHio1qhrrfzgyt9SKXngUcTl2URw+czBZYhAqEbW qhELsD6uAeoIWJaxgrVUb/aBQIwe1CPq3FLqbLA1Ybl3lzQtGdpkwPmVXzz42AFzRg/Uu3f3oG8F Yesz+H4CcASqsFr0+9gAEzJEYV4NsZTcAB83WwDt7FGVgKXj8VWYzyJyCOrfQB9MO9O5UaM3SuYR DLcJtSmAaXVnraG0EiBir9HkYESk6XbsBsIsN9cab6OmGS0TK6AxItjJTlCdnoHXelAjeKgXN7m7 W6LhKj41McuAorte3gLEFsxXegdEsgHpDSjB8iDYVULC3pPxJ51+ACBzvgDPBT2aAAAAJXRFWHRk YXRlOmNyZWF0ZQAyMDIwLTExLTI2VDEyOjQ5OjU0KzAwOjAwNIQCzQAAACV0RVh0ZGF0ZTptb2Rp ZnkAMjAyMC0xMS0yNlQxMjo0OTo1NCswMDowMEXZunEAAAAASUVORK5CYII= X-Now-Playing: Simple Minds's _Sister Feelings Call_: "Theme for Great Cities" In-Reply-To: (Stefan Kangas's message of "Thu, 26 Nov 2020 04:46:25 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194304 Archived-At: Stefan Kangas writes: > The problem I saw was basically warnings > about symbols only visible after macro expansion, and that warnings > would point to entirely the wrong line and column. Oh, OK, the problem was in the lines/column output, not with detecting the doc strings themselves? Yes, that sounds like a problem, but... I think we can live with inaccurate lines here. >> Yes, the autogenerated docstrings should be fixed, too -- mostly by >> running them through `fill-paragraph'. > > I tried that in e.g. define-derived-mode, but fill.el is loaded after > derived.el. So it seems like there is some fun to be had in figuring > out the dependencies there... Yeah, I guess fill.el is a pretty far down in the list of things that loadup.el loads? However, we could make a super-simple function for filling doc strings -- doing something that's good enough for that particular task shouldn't take more than a few lines. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no