From: Juri Linkov <juri@linkov.net>
To: 44983@debbugs.gnu.org
Subject: bug#44983: Truncate long lines of grep output
Date: Tue, 01 Dec 2020 10:45:29 +0200 [thread overview]
Message-ID: <87v9dlc3ti.fsf_-_@mail.linkov.net> (raw)
[New bug report from emacs-devel]
>>>> For grep output a bigger problem is that grep on binary data
>>>> might output too long lines before the terminating newline.
>>>
>>> (*) We already have this kind of problem with "normal" files which contain
>>> minified assets (JS or CSS). The file contents are usually normal ASCII,
>>> but it's just one line which can reach several MBs in length.
>>>
>>> The usual way to deal with that is with project-ignores and
>>> grep-find-ignored-files. That works for both cases.
>> This is a bug problem - often grep output lines are so long
>> that Emacs freezes, so need to kill the process. Updating
>> manually ignored-files every time a new file causes freeze
>> is very unreliable and time-consuming workaround.
>
> And a non-obvious one (for an average user).
>
> Is the same problem exhibited by commands using the Xref UI? I don't
> remember seeing it, but of course our projects can be very different.
No difference from grep, Xref output has the same problem.
>> I tried to fix this problem, and fortunately the fix is simple
>> with the 1-liner patch.
>> It does exactly the same thing that we recently did to hide
>> overly long grep command lines with 'grep-find-abbreviate'.
>> The patch even uses the same 'grep-find-abbreviate-properties'
>> to allow clicking the hidden part to expand it.
>> diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
>> index dafba22f77..e0df2402ee 100644
>> --- a/lisp/progmodes/grep.el
>> +++ b/lisp/progmodes/grep.el
>> @@ -492,6 +492,9 @@ grep-mode-font-lock-keywords
>> (0 grep-context-face)
>> (1 (if (eq (char-after (match-beginning 1)) ?\0)
>> `(face nil display ,(match-string 2)))))
>> + ;; Hide excessive parts of grep output lines
>> + ("^.+?:.\\{,64\\}\\(.*\\).\\{10\\}$"
>> + 1 grep-find-abbreviate-properties)
>> ;; Hide excessive part of rgrep command
>> ("^find \\(\\. -type d .*\\\\)\\)"
>> (1 (if grep-find-abbreviate grep-find-abbreviate-properties
>>
>> More customizability could be added later to define the
>> length of the hidden part, etc.
>
> Maybe we'll want it to be dynamically determined by fill-column.
>
> Or just be a big enough value (e.g. 256) that the only lines where this
> rule is hit are obviously too long.
Or maybe determined by the frame width.
This will avoid the need of using such workarounds as in bug#44941:
grep -a "$@" | cut -c -200
next reply other threads:[~2020-12-01 8:45 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 8:45 Juri Linkov [this message]
2020-12-01 15:02 ` bug#44983: Truncate long lines of grep output Dmitry Gutov
2020-12-01 16:09 ` Eli Zaretskii
2020-12-01 16:46 ` Andreas Schwab
2020-12-01 18:26 ` Eli Zaretskii
2020-12-01 20:35 ` Juri Linkov
2020-12-02 3:21 ` Eli Zaretskii
2020-12-02 9:35 ` Juri Linkov
2020-12-02 10:28 ` Eli Zaretskii
2020-12-02 20:53 ` Juri Linkov
2020-12-03 14:47 ` Eli Zaretskii
2020-12-03 16:30 ` Rudolf Schlatte
2020-12-03 21:17 ` Juri Linkov
2020-12-05 19:47 ` Juri Linkov
2020-12-06 20:39 ` Juri Linkov
2020-12-06 21:37 ` Dmitry Gutov
2020-12-06 21:54 ` Juri Linkov
2020-12-07 2:41 ` Dmitry Gutov
2020-12-08 19:41 ` Juri Linkov
2020-12-09 3:00 ` Dmitry Gutov
2020-12-09 19:17 ` Juri Linkov
2020-12-09 20:06 ` Dmitry Gutov
2020-12-10 8:18 ` Juri Linkov
2020-12-10 20:48 ` Dmitry Gutov
2020-12-09 21:43 ` Jean Louis
2020-12-10 8:06 ` Juri Linkov
2020-12-10 10:08 ` Jean Louis
2020-12-12 20:42 ` Juri Linkov
2020-12-13 10:57 ` Jean Louis
2020-12-13 15:11 ` Eli Zaretskii
2020-12-13 15:37 ` Jean Louis
2020-12-13 20:17 ` Juri Linkov
2020-12-14 16:15 ` Eli Zaretskii
2020-12-14 20:09 ` Dmitry Gutov
2020-12-24 20:33 ` Juri Linkov
2020-12-24 23:38 ` Dmitry Gutov
2020-12-08 5:35 ` Richard Stallman
2020-12-08 19:15 ` Dmitry Gutov
2022-04-29 11:39 ` Lars Ingebrigtsen
2022-04-29 12:22 ` Eli Zaretskii
2022-04-29 12:41 ` Lars Ingebrigtsen
2022-04-29 13:08 ` Eli Zaretskii
2022-04-30 9:24 ` Lars Ingebrigtsen
2022-04-30 9:36 ` Lars Ingebrigtsen
2022-04-30 10:15 ` Eli Zaretskii
2022-04-30 11:04 ` Lars Ingebrigtsen
2022-04-29 16:02 ` Dmitry Gutov
2022-04-30 9:40 ` Lars Ingebrigtsen
2022-04-30 9:56 ` Lars Ingebrigtsen
2022-04-30 10:09 ` Eli Zaretskii
2022-04-30 10:59 ` Lars Ingebrigtsen
2022-04-30 11:02 ` Lars Ingebrigtsen
2022-04-30 11:12 ` Eli Zaretskii
2022-04-29 17:15 ` Juri Linkov
2022-04-30 0:27 ` Dmitry Gutov
2022-05-01 17:14 ` Juri Linkov
2020-12-01 20:34 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9dlc3ti.fsf_-_@mail.linkov.net \
--to=juri@linkov.net \
--cc=44983@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).