From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45095: [PATCH] lisp/progmodes/compile.el: only use comint-term-environment under comint Date: Mon, 07 Dec 2020 16:57:56 +0100 Message-ID: <87v9ddfw1n.fsf@gnus.org> References: <20201207090450.2225-1-hi@alyssa.is> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21567"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45095@debbugs.gnu.org To: Alyssa Ross Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 07 16:59:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmIuu-0005St-OI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Dec 2020 16:59:12 +0100 Original-Received: from localhost ([::1]:40212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmIut-000890-Qm for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Dec 2020 10:59:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmIuk-00086c-Gz for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 10:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43490) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmIuk-0007va-8Q for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 10:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmIuk-0006ob-7v for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 10:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Dec 2020 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45095 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45095-submit@debbugs.gnu.org id=B45095.160735668726109 (code B ref 45095); Mon, 07 Dec 2020 15:59:02 +0000 Original-Received: (at 45095) by debbugs.gnu.org; 7 Dec 2020 15:58:07 +0000 Original-Received: from localhost ([127.0.0.1]:55032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmItq-0006n3-Sr for submit@debbugs.gnu.org; Mon, 07 Dec 2020 10:58:07 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:38638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmItp-0006mX-Oh for 45095@debbugs.gnu.org; Mon, 07 Dec 2020 10:58:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fbJ9SuUR+dBpuJc6BSeQ2vCEJOLohQdjns+yQscH1m0=; b=nRSfhtV4PweXeQiGbiC3UykZNU IrD9qX1JpBA3EcGg87N3TKgK9WVef3cU5dAavYWMoJpb7QcHo8mzyNG+kP0vwHg+4434iGDlS33WB CKUDLmb5lZ5DHazWbn+16uCmZfbRPhDEfhKkTlhBasLaLAs0W/b35Fo2xBQLL5Q325/o=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmIth-0007Ha-Cu; Mon, 07 Dec 2020 16:58:00 +0100 X-Now-Playing: Alva Noto's _Xerrox Vol. 04_: "Xerrox =?UTF-8?Q?=C3=8Ele?=" In-Reply-To: <20201207090450.2225-1-hi@alyssa.is> (Alyssa Ross's message of "Mon, 7 Dec 2020 09:04:51 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195247 Archived-At: Alyssa Ross writes: > comint-term-environment is used for configuring the environment for > terminal output under comint. If compile is being used with a > different major mode, that mode probably can't handle the fancy > terminfo output that comint can, so comint-term-environment should > only be used under comint or a derived mode. Makes sense -- applied to Emacs 28. [...] > I haven't got my copyright papers sorted yet, so hopefully this change > is also small enough that that doesn't matter. Yup. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no