From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#45361: 28.0.50; tabulated-list-mode: should be sorting by specified sort function Date: Tue, 22 Dec 2020 10:31:35 +0100 Message-ID: <87v9cu9og8.fsf@gmx.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6302"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45361@debbugs.gnu.org To: Jean Louis Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 22 10:33:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kre2X-0001Uo-Ii for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Dec 2020 10:33:09 +0100 Original-Received: from localhost ([::1]:42294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kre2W-0000ge-L3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Dec 2020 04:33:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kre2Q-0000gQ-7f for bug-gnu-emacs@gnu.org; Tue, 22 Dec 2020 04:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kre2Q-0003YQ-0W for bug-gnu-emacs@gnu.org; Tue, 22 Dec 2020 04:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kre2P-0003Vx-Sd for bug-gnu-emacs@gnu.org; Tue, 22 Dec 2020 04:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Dec 2020 09:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45361 X-GNU-PR-Package: emacs Original-Received: via spool by 45361-submit@debbugs.gnu.org id=B45361.160862953913437 (code B ref 45361); Tue, 22 Dec 2020 09:33:01 +0000 Original-Received: (at 45361) by debbugs.gnu.org; 22 Dec 2020 09:32:19 +0000 Original-Received: from localhost ([127.0.0.1]:48937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kre1i-0003Ue-M6 for submit@debbugs.gnu.org; Tue, 22 Dec 2020 04:32:18 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:50481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kre1h-0003UN-0H for 45361@debbugs.gnu.org; Tue, 22 Dec 2020 04:32:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1608629500; bh=0zX/khhSIfSFBFKAIQImkAbZJZdGp6eg4Cqcp/RhB9A=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=W8oaVQJ5tLx5nWNQOqVGncQeW5XNxN1o/59M58reC1z+X9huOZOM+YWp1EIzMlsfT 5ae5tp6aJtCDClmUSD6/fhTfS1I4c5ymrW7OOnRuRaPVX6ib0JsXLLNNvryvpW48Ay DMo6DdXH5F9xlGqzJEloCIHifI68mMCUJ17KwMmk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-jhalfs ([92.73.70.249]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mv31W-1k0mJX3QlE-00r3Sp; Tue, 22 Dec 2020 10:31:39 +0100 In-Reply-To: (Jean Louis's message of "Tue, 22 Dec 2020 08:13:50 +0100") X-Provags-ID: V03:K1:QAZCTwLrL63CFILPXxhXT48kS4nZNHHL1OiM4mOZ6kiGU/1WplI GdJl57CZXo4TIq9ZXd1uFuppNpCoubTZ1gm/axZjjSGULxiFAX2a/O1S/4INobnktL6LBTw vt6aoDIMPiNuzk0qS5zT83YiZUzShdm9wQh8OAYH8K954wcpx7XVDEdvHCNeOOIdUcN/pw9 G8iHAQI2GxJcIJb+1YcUQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:bban4t1jLSk=:4VAeSzilS4kuJLq6qooILR 4z/VCFSWjq961mdmQ6lNd6Apzs1JkDALaitoHa1/qBFZo+wgmAMznRW+4rJ7kf68znODS/MEy DIAcw7pFh5ivWp+9aGsIx0vAmYfVbJZRvcvRrb/6NeZts9+3xE5TgTnwXUYSWzU6rNq3v+zeF fEam3Vv42a2WjvieVhwl32XHLoqy+gmmR622GfF9uT0jv/RE2dk2MEi0NYltEHo9Fwv94x6sD mQWh4a1aDdHFz7SOpFS+TBpCp9zcXiH6It0c1Q5g9N5K1pj3pjSYcPjtb2uv3VR2u8uJgNSjX NBNUjcfwrysacUKNLU99qj2QC3mQokUCLnP9rFc2oWCdZtO31Dnu7tJ5JN0kz/qRf7/MqprTi l5FPUhc5Ab6jNsrVsgub7WqjfoM1k/noVDnRH1cWE8DXWcrKOHb6gzAFDRPbJswCBV7Ge/eDT woyI2WTM+itEFj00SBBBNDaJgG09uqqkFxcLM+/OkAsTj3FkR7ZML9fnyaKV8FueLt8GCGPzB UIaLx0Z0KpuhNT5VerjmlFW9MYZmM80Rur72bq96gPzEOhVQVwaucpgHEnXDcJ+PNMpH2BBua hEJ0AM6YUy04aSeBMFQsx20axd4mFxiE7AIwZ/xtTaCJOYaHM2DMsTvbiLWXfh6YT2DgxVwjR c3mrEean9IJ54uRK3rLzsGnrkCjv8VZNGVtimP1CKkZ0DxtJqnpKrFN06limCCEQZ7y+5j91R WvmwfpkDEe9k5coEansoH5zHUvi2mDOqe4av9vd5ttQpcBBwfv8YjkijfQHL2U2YrqWvrhlR X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196567 Archived-At: On Tue, 22 Dec 2020 08:13:50 +0100 Jean Louis wrote: > PROBLEM: > > The variable `tabulated-list-format' provides for programmer > option to sort columns and I would like to sort number as > strings "12" as numbers, not as strings. I do not know how to > properly provide the sorting function to `tabulated-list-format' so > that it works when actually sorting. [...] > Then I would like to use the function `string-collate-lessp' as that > seem to understand how numbers should be compared. > > For example this is giving me correct result: > > (sort '("121" "117" "1") 'string-collate-lessp) => ("1" "117" "121") But: (sort '("21" "117" "1") 'string-collate-lessp) => ("1" "117" "21") So string-collate-lessp doesn't do what it seems you want. [...] > But when I click on "Count" column or press S then it again gets > sorted rather alphabetic, not by using my function. > > That is where I would need help to understand what is happening. > > Because when I press S in the column "Count" when cursor is on the number, it invokes this function: > > (defun tabulated-list-sort (&optional n) > "Sort Tabulated List entries by the column at point. > With a numeric prefix argument N, sort the Nth column." > (interactive "P") > (let ((name (if n > (car (aref tabulated-list-format n)) > (get-text-property (point) > 'tabulated-list-column-name)))) > (if (nth 2 (assoc name (append tabulated-list-format nil))) > (tabulated-list--sort-by-column-name name) > (user-error "Cannot sort by %s" name)))) > > Then this one: > > (defun tabulated-list--sort-by-column-name (name) > (when (and name (derived-mode-p 'tabulated-list-mode)) > ;; Flip the sort order on a second click. > (if (equal name (car tabulated-list-sort-key)) > (setcdr tabulated-list-sort-key > (not (cdr tabulated-list-sort-key))) > (setq tabulated-list-sort-key (cons name nil))) > (tabulated-list-init-header) > (tabulated-list-print t))) > > And if I read well those functions do not search for my function and > invoke `my-sort', but they should. Am I right there? Actually, tabulated-list-print does call my-sort via tabulated-list--get-sorter. Anyway, buffer-menu.el has the function `tabulated-list-entry-size->', which with a small adjustment does what you seem to want. Try this: (defun my-tabulated-list-entry-size-> (entry1 entry2) (> (string-to-number (aref (cadr entry1) 0)) (string-to-number (aref (cadr entry2) 0)))) (let ((buffer "*tabulated*")) (switch-to-buffer-other-window buffer) (setq tabulated-list-format [("Count" 10 my-tabulated-list-entry-size-> :right-align t) ("Name" 60 t)]) (setq tabulated-list-entries '((6 ["6" "Mercury"]) (7 ["7" "GNU Emacs"]) (8 ["8" "YouTube Videos"]) (9 ["9" "Speedy worker cleaning tables in a restaurant"]) (71 ["71" "Trenching"]) (82 ["82" "Easier trenching idea"]))) (tabulated-list-mode) (tabulated-list-init-header) (hl-line-mode) (tabulated-list-print)) Steve Berman