From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: 45829@debbugs.gnu.org
Subject: bug#45829: 28.0.50; Some tweaks to the color widget, from wid-edit+.el
Date: Fri, 15 Jan 2021 22:22:38 +0000 [thread overview]
Message-ID: <87v9bxg7rl.fsf@tcd.ie> (raw)
In-Reply-To: <5ffe2149.1c69fb81.b9bf6.0d1d@mx.google.com> (Mauro Aranda's message of "Tue, 12 Jan 2021 19:23:03 -0300")
Mauro Aranda <maurooaranda@gmail.com> writes:
> Opinions?
Just some minor nits from me.
> -;; Fixme: match
> (define-widget 'color 'editable-field
> "Choose a color name (with sample)."
> :format "%{%t%}: %v (%{sample%})\n"
> :value-create 'widget-color-value-create
> - :size 10
> + :size (1+ (apply #'max (mapcar #'length (defined-colors))))
Is defined-colors guaranteed to return non-nil?
If not, you need (apply #'max 0 ...).
> +(defun widget-color-match (_widget value)
> + "Non-nil if VALUE is a defined color or a RGB hex string."
> + (and (stringp value)
> + (or (color-defined-p value)
> + (string-match-p "^#\\([[:xdigit:]]\\{3\\}\\)\\{1,4\\}$" value))))
Shouldn't that be "\\`#[[:xdigit:]]\\{3\\}\\{1,4\\}\\'"
or at least "\\`#\\(?:[[:xdigit:]]\\{3\\}\\)\\{1,4\\}\\'"
(if you want to be explicit)?
> +(ert-deftest widget-test-color-match ()
> + "Test that the :match function for the color widget works."
> + (let* ((widget (widget-convert 'color)))
Nit: could also be let.
> + (should (widget-apply widget :match "red"))
> + (should (widget-apply widget :match "#fa3"))
> + (should (widget-apply widget :match "#ff0000"))
> + (should (widget-apply widget :match "#111222333"))
> + (should (widget-apply widget :match "#111122223333"))
> + (should-not (widget-apply widget :match "someundefinedcolorihope"))
> + (should-not (widget-apply widget :match "#11223"))))
Thanks,
--
Basil
next prev parent reply other threads:[~2021-01-15 22:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 22:13 bug#45829: 28.0.50; Some tweaks to the color widget, from wid-edit+.el Mauro Aranda
2021-01-12 22:23 ` Mauro Aranda
2021-01-15 22:22 ` Basil L. Contovounesios [this message]
2021-01-16 7:09 ` Eli Zaretskii
2021-01-16 12:10 ` Mauro Aranda
2021-01-19 6:43 ` Lars Ingebrigtsen
2021-01-19 12:22 ` Mauro Aranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9bxg7rl.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=45829@debbugs.gnu.org \
--cc=maurooaranda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).