From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: "積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Cc: 46052@debbugs.gnu.org
Subject: bug#46052: Colons fooling GNUmakefile mode
Date: Sat, 23 Jan 2021 14:48:22 +0100 [thread overview]
Message-ID: <87v9bnlq6x.fsf@gmail.com> (raw)
In-Reply-To: <87tur914qj.5.fsf@jidanni.org> ("積丹尼 Dan Jacobson"'s message of "Fri, 22 Jan 2021 21:27:32 +0800")
積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
> Perhaps already fixed.
AFAICT this is still reproducible in master (c83590b).
Out of curiosity, I took a look at make-mode.el, thinking it might just
be a matter of adding a [^\t] in a regexp somewhere after a ^ anchor,
but I'm not used to debugging font-lock setups and I don't really know
which occurrence of makefile-targets is responsible for this spurious
fontification (maybe the one paired with makefile-match-dependency,
which relies on makefile-dependency-regex?).
It sure would be nice if make-mode could check whether a line starts
with a tab before slapping the makefile-targets face on it.
(Supporting .RECIPEPREFIX would also be neat I guess, though the fact
that this variable can be set multiple times in a single makefile will
probably pose an interesting challenge.)
next prev parent reply other threads:[~2021-01-23 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 13:27 bug#46052: Colons fooling GNUmakefile mode 積丹尼 Dan Jacobson
2021-01-23 13:48 ` Kévin Le Gouguec [this message]
2021-01-23 14:00 ` Eli Zaretskii
2021-01-23 14:58 ` Kévin Le Gouguec
2021-01-23 17:23 ` Eli Zaretskii
2021-01-23 17:59 ` Kévin Le Gouguec
2021-01-23 18:26 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9bnlq6x.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=46052@debbugs.gnu.org \
--cc=jidanni@jidanni.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).