From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#47252: 28.0.50; [PATCH] Make minibuffer-depth-indicator-function a defcustom Date: Fri, 19 Mar 2021 11:49:32 +0100 Message-ID: <87v99nwh8j.fsf@gmail.com> References: <6054682b.1c69fb81.4e70b.3ed7@mx.google.com> <87h7l7mqvb.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5782"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gabriel , Mauro Aranda , 47252@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 19 11:50:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNChq-0001Q3-IE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Mar 2021 11:50:14 +0100 Original-Received: from localhost ([::1]:57970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNChp-0005li-1a for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Mar 2021 06:50:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNChh-0005lZ-Vk for bug-gnu-emacs@gnu.org; Fri, 19 Mar 2021 06:50:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNChd-0005fE-Vo for bug-gnu-emacs@gnu.org; Fri, 19 Mar 2021 06:50:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNChd-0001Df-Q0 for bug-gnu-emacs@gnu.org; Fri, 19 Mar 2021 06:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Mar 2021 10:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47252 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 47252-submit@debbugs.gnu.org id=B47252.16161509834653 (code B ref 47252); Fri, 19 Mar 2021 10:50:01 +0000 Original-Received: (at 47252) by debbugs.gnu.org; 19 Mar 2021 10:49:43 +0000 Original-Received: from localhost ([127.0.0.1]:48916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNChK-0001Cz-Pw for submit@debbugs.gnu.org; Fri, 19 Mar 2021 06:49:43 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:34415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNChI-0001Ck-Em for 47252@debbugs.gnu.org; Fri, 19 Mar 2021 06:49:41 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id j7so8632104wrd.1 for <47252@debbugs.gnu.org>; Fri, 19 Mar 2021 03:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=vYvYxZZEVvvA1E8eqdaTOh2zS6jKY0anJVpYlMcAGws=; b=Z0ld2owUEmQwj7SX/TvNImCeX1WsWeUQCy39bA2GijgkRNgMnRcrA7A+DWgOx64HpO rWIMGfVFbTHj3V+D5GxNEQloSaMqUtf94W2RqDVmp38ElzjmghU/TABWjCHGRcFh7CU9 SUKoFA37WtzepR+uqAgp3h2Vo5hQCoU5LCIFQ2/0wUcgAUeTiL2Zqzi/TYIHRxPxPvRa rdzTMg3TT9tjm0IrHBVccBUR57NvskEarWBJPbvDnJWa/6Udk/69FZj4YfD7Io7hS49x 10PV10ZaAeYs99D2MqsEJUXnLPCqWCdTrqN655o93a7CwxkDyDltBkqttO8/H6UzWnju 71IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=vYvYxZZEVvvA1E8eqdaTOh2zS6jKY0anJVpYlMcAGws=; b=MYf5gtJlxJyBhchNIuPcSeDhka0wrA3dFlw664kS4zx9iLt6ezk9eQeLPs3IQi39am ilQF5K1RC+gP0A8aTTbpOXufXmP1fNqXwwj+J+mb5RvSN5T5/45lol2J2hlpNPGrMPm4 /B/iTbuJZnjk8K/fePNyANQRq4jEdD6ZRysvYv0XAWAkXDbkZBogQ0vmOmiKQDVhQB3p bUFIAXt9ChRkLBHnEko7SzswLjmKxR68Q4CD3lPRPvy+EDm+h9lWA+OmapK3hgfI/4Od eec2zXa+h5hVnexuM6gw4wF1dJYE+9GC+yfelaL9kQONEOMoBiYuyHY60JNb+AQmqS4h tv9A== X-Gm-Message-State: AOAM532gzb0ouRWR4b/y70LNCQlOUc+sfm8bHXVg3Z2+aDwMNA7QWUZg fLt0cPIn+30faM4WKdaPpjqLm5QUQdI= X-Google-Smtp-Source: ABdhPJwkCxZWQAwkyjHL61HJbnZV9oxCwzqCuMWdd4r7SDwb9JgmT89bYXUxdT3Q7XjlUBZHBd5L8A== X-Received: by 2002:a5d:5256:: with SMTP id k22mr3994600wrc.162.1616150974140; Fri, 19 Mar 2021 03:49:34 -0700 (PDT) Original-Received: from rltb (91-175-207-237.subs.proxad.net. [91.175.207.237]) by smtp.gmail.com with ESMTPSA id u9sm5469159wmc.38.2021.03.19.03.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 03:49:33 -0700 (PDT) In-Reply-To: <87h7l7mqvb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 19 Mar 2021 10:31:36 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202682 Archived-At: >>>>> On Fri, 19 Mar 2021 10:31:36 +0100, Lars Ingebrigtsen said: Lars> Mauro Aranda writes: >> Gabriel writes: >> >>> This simple patch makes 'minibuffer-depth-indicator-function' a >>> defcustom. >> >> Since the default value is nil, I made a change after Lars pushed your >> patch to include nil as a supported value; else, the Customize interface >> reports a mismatch Lars> Thanks. But shouldn't Lars> + :type '(choice (const :tag "Default" nil) Lars> + (function)) Lars> be Lars> + :type '(choice (const :tag "Default" nil) Lars> + function) Lars> ? >> (and I think we do have tests to check for this?) Lars> Yes, what's the test for this again? admin/cus-test.el Robert --