From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47125: 28.0.50; pdumper assumes compile time page size remains valid Date: Sun, 28 Mar 2021 17:46:09 +0200 Message-ID: <87v99bp9ha.fsf@gnus.org> References: <83r1kigut8.fsf@gnu.org> <90eb70a9-e482-3c08-9f14-8b813bdf0042@dancol.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2429"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47125@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 28 17:48:04 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQXe0-0000VP-7H for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 17:48:04 +0200 Original-Received: from localhost ([::1]:33396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQXdz-0000Wi-3p for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 11:48:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQXd0-0008Pc-Nm for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 11:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35258) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQXd0-0004fD-Fz for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 11:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQXd0-0006DG-Di for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 11:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Mar 2021 15:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47125 X-GNU-PR-Package: emacs Original-Received: via spool by 47125-submit@debbugs.gnu.org id=B47125.161694638423817 (code B ref 47125); Sun, 28 Mar 2021 15:47:02 +0000 Original-Received: (at 47125) by debbugs.gnu.org; 28 Mar 2021 15:46:24 +0000 Original-Received: from localhost ([127.0.0.1]:46801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQXcN-0006C3-Ma for submit@debbugs.gnu.org; Sun, 28 Mar 2021 11:46:23 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:57024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQXcL-0006Bp-PD for 47125@debbugs.gnu.org; Sun, 28 Mar 2021 11:46:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7Vx2gYN3onsWL6DxSlCdxcexYt/SnT5Ip3rtcX88icc=; b=J7ipB5hu5/un/NMF7uEvFSF/HG cdkiAdwCbhXOtbcbx8wj4W0+pcU0Cr+SksQdsfxH10OekTs6011Ss96R3jV9dyx3HULWMYecEC1N7 rHTY8WZ7xsiymsJZ0tj1oqSC36I8DRu+o/9mX4X7rSW/qQ+aT2v/roIEueBUpOsSlYt0=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQXcB-0003qT-29; Sun, 28 Mar 2021 17:46:14 +0200 X-Now-Playing: King Crimson's _The Complete 1969 Recordings (13): Sessions 1_: "I Talk to the Wind Takes 1 to 4" In-Reply-To: (Pip Cet's message of "Sun, 14 Mar 2021 08:16:21 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203183 Archived-At: Pip Cet writes: > Linux also offers 64KB pages, so I believe Andreas is correct, that > would be better. > > Should we verify that getpagesize isn't problematic when loading the dump? This was two weeks ago, and there was no followup here. Everybody seemed to agree that we should use 64K here... So is the following patch correct? diff --git a/src/pdumper.c b/src/pdumper.c index 337742fda4..bdaba0269f 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -162,11 +162,7 @@ ptrdiff_t_to_dump_off (ptrdiff_t value) static int dump_get_page_size (void) { -#if defined (WINDOWSNT) || defined (CYGWIN) return 64 * 1024; /* Worst-case allocation granularity. */ -#else - return getpagesize (); -#endif } #define dump_offsetof(type, member) \ -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no