From: handa <handa@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stephen.berman@gmx.net, stefan@marxist.se, juri@linkov.net,
styang@fastmail.com, monnier@iro.umontreal.ca,
45379@debbugs.gnu.org
Subject: bug#45379: 28.0.50; Degraded Performance of describe-buffer-bindings
Date: Fri, 02 Apr 2021 00:06:40 +0900 [thread overview]
Message-ID: <87v996rqm7.fsf@gnu.org> (raw)
In-Reply-To: <838s65ktvk.fsf@gnu.org> (message from Eli Zaretskii on Tue, 30 Mar 2021 10:01:19 +0300)
In article <838s65ktvk.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:
> > > Is the patch for the above improvement the one included in the file
> > > 0001-Fix-describe-buffer-bindings-performance-regression.patch?
> >
> > Yes, it is.
It seems that the main intention of that patch is to avoid unnecessary
call of char_table_ref_and_range introduced by the commit below:
> > Don't show key ranges if shadowed by different commands
> >
> > * src/keymap.c (describe_vector): Make sure found consecutive keys
> > are either not shadowed or, if they are, that they are shadowed by
> > the same command. (Bug#9293)
In describe_vector, if VECTOR is a char-table, char_table_ref_and_range
is already called at the fairly beginning of the main loop. So, we do
not have to call it again, and thus, I think the patch is doing the
correct thing.
But, I don't know whether the following part in the patch is correct or
not.
+ /* Ignore `self-insert-command' for performance. */
+ && !EQ (definition, Qself_insert_command))
---
K. Handa
handa@gnu.org
next prev parent reply other threads:[~2021-04-01 15:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 6:01 bug#45379: 28.0.50; Degraded Performance of describe-buffer-bindings styang
2021-01-08 16:47 ` Sheng Yang
2021-01-08 17:00 ` Stefan Kangas
2021-01-08 17:08 ` Stefan Kangas
2021-02-04 15:43 ` Sheng Yang
2021-03-06 4:44 ` Stefan Kangas
2021-03-06 8:15 ` Eli Zaretskii
2021-03-07 1:42 ` handa
2021-03-07 6:15 ` Eli Zaretskii
2021-03-30 7:01 ` Eli Zaretskii
2021-04-01 15:06 ` handa [this message]
2021-04-14 3:06 ` Sheng Yang
2021-03-07 8:12 ` Stefan Kangas
2021-03-07 8:38 ` Eli Zaretskii
2021-05-04 23:31 ` Stefan Kangas
2021-05-06 10:11 ` Eli Zaretskii
2021-05-13 10:10 ` Eli Zaretskii
2021-06-26 21:51 ` Sheng Yang
2021-06-27 5:56 ` Eli Zaretskii
2021-09-07 18:53 ` Eli Zaretskii
2021-09-18 10:37 ` Eli Zaretskii
2021-09-18 12:34 ` Stefan Kangas
2021-09-18 13:24 ` Eli Zaretskii
2021-09-18 14:39 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v996rqm7.fsf@gnu.org \
--to=handa@gnu.org \
--cc=45379@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
--cc=stefan@marxist.se \
--cc=stephen.berman@gmx.net \
--cc=styang@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).