From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#47810: 28.0.50; pulse no longer accepts a face argument Date: Tue, 04 May 2021 07:33:37 +0300 Message-ID: <87v97z15jy.fsf@protesilaos.com> References: <87pmyvxrw8.fsf@protesilaos.com> <7dee3f42357b0b950c58@heytings.org> <87blae4hb2.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14961"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47810@debbugs.gnu.org, Stefan Kangas To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 04 06:34:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldmlA-0003mS-SE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 May 2021 06:34:12 +0200 Original-Received: from localhost ([::1]:49978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldml9-0005aE-W4 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 May 2021 00:34:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldml0-0005a1-Hs for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 00:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldml0-0007P8-Ad for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 00:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldml0-0003t2-7J for bug-gnu-emacs@gnu.org; Tue, 04 May 2021 00:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 May 2021 04:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47810-submit@debbugs.gnu.org id=B47810.162010282914933 (code B ref 47810); Tue, 04 May 2021 04:34:02 +0000 Original-Received: (at 47810) by debbugs.gnu.org; 4 May 2021 04:33:49 +0000 Original-Received: from localhost ([127.0.0.1]:50634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldmkn-0003sn-1G for submit@debbugs.gnu.org; Tue, 04 May 2021 00:33:49 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:37947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldmkk-0003sh-Pz for 47810@debbugs.gnu.org; Tue, 04 May 2021 00:33:47 -0400 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 216E220003; Tue, 4 May 2021 04:33:38 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Tue, 20 Apr 2021 19:02:36 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205571 Archived-At: On 2021-04-20, 19:02 -0500, Stefan Kangas wrote: > Protesilaos Stavrou writes: > >> On 2021-04-16, 08:32 +0000, Gregory Heytings wrote: >> >>>> >>>> I would expect the following two expressions to produce pulse effects >>>> that differ in colour (tried with emacs -Q): >>>> >>>> (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight) >>>> (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region) >>>> >>>> Instead they use the background of pulse-highlight-start-face. >>>> >>> >>> Indeed; patch attached. >> >> Thank you! I can confirm that this works. > > I guess we are still waiting for Gregory's copyright papers to come > through before this can be applied? Hello Gregory! Has your copyright assignment process been finalised? Maybe Stefan can help install your patches. There is this bug report as well as #47960. All the best, Protesilaos or "Prot" -- Protesilaos Stavrou https://protesilaos.com