From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#41438: [PATCH] Allow windmove keys to be bound without prefix or modifiers Date: Tue, 25 May 2021 07:25:10 +0000 Message-ID: <87v977p961.fsf@icterid> References: <87imgpw7k3.fsf@warpmail.net> <87mu36enhl.fsf@posteo.net> <8735uru1py.fsf@gnus.org> <871r9yjyv5.fsf@posteo.net> <87h7irqtvf.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8699"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41438@debbugs.gnu.org, Juri Linkov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 25 09:26:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llRS5-00026n-L6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 09:26:09 +0200 Original-Received: from localhost ([::1]:37440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llRS4-00062Y-NA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 03:26:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llRRy-00062O-1Y for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 03:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llRRx-0002di-PM for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 03:26:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llRRx-000142-Md for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 03:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 May 2021 07:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41438 X-GNU-PR-Package: emacs Original-Received: via spool by 41438-submit@debbugs.gnu.org id=B41438.16219275234045 (code B ref 41438); Tue, 25 May 2021 07:26:01 +0000 Original-Received: (at 41438) by debbugs.gnu.org; 25 May 2021 07:25:23 +0000 Original-Received: from localhost ([127.0.0.1]:44550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llRRK-00013A-Jy for submit@debbugs.gnu.org; Tue, 25 May 2021 03:25:23 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:46321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llRRI-00012t-GC for 41438@debbugs.gnu.org; Tue, 25 May 2021 03:25:21 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 026772400E5 for <41438@debbugs.gnu.org>; Tue, 25 May 2021 09:25:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1621927514; bh=68dTJRDeJqr3cU8g/H72gI+Y5JYcxmbhbOgvgKvTGvU=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Hpew7Kt5ZkVnIAGVFoTYUUzUDp41h0hyletEah+WVXYoyGmsob5m2tD1PmyecnTqp 44UBVaUX00H4NLtCvOgC3w2D7gSDJuzsz3vJ6q13sB497/0QH2ZpD4HpzryhyrRi9X N4wIiYaDCryOkqjvfgUVuXSyDcJIqNr8fdKwLOsubyeTaBa6azq6I44jIJBHFVfkqN /Lm4ngdetYT87fkxXbDQFjxHuqDJNZtwb+MQpUkantUPsDmIEm3z/t/6tDBtKEFTiu UhknVuS32lZ3Hnj2sUgSwyAjSK5OvYWel/1c+Mwis72ovyNyJTllgOOkwj/FLvFqvj bUT53nMmLLgcQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Fq5Fg6Sngz6tmL; Tue, 25 May 2021 09:25:11 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=mutual; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <87h7irqtvf.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 25 May 2021 07:12:36 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207173 Archived-At: Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >> The code should probably be refactored, moving more of the common >> functionality into it's own function, but I am primarily wondering if >> using emulation-mode-map-alists the way I am proposing it here is ok. Or >> should I prefer minor-mode-map-alist? > > Making windmove into a regular (global) minor mode would be less > surprising, I think, but I'm not really familiar with windmove, and > whether that would be an easy rewrite? >From my experience, it should be possible, I'll try preparing a patch. The only issue is that most people won't realize there is a minor mode at first, but that should be OK as long as the actual windmove commands do not depend on said minor mode. -- Philip K.