From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#41438: [PATCH] Allow windmove keys to be bound without prefix or modifiers Date: Tue, 25 May 2021 11:42:56 +0000 Message-ID: <87v977ghtr.fsf@icterid> References: <87imgpw7k3.fsf@warpmail.net> <87mu36enhl.fsf@posteo.net> <8735uru1py.fsf@gnus.org> <871r9yjyv5.fsf@posteo.net> <87h7irqtvf.fsf@gnus.org> <87im37p2b4.fsf@icterid> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32832"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41438@debbugs.gnu.org, Lars Ingebrigtsen , Juri Linkov To: Arthur Miller Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 25 13:44:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llVTp-0008MK-2e for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 13:44:13 +0200 Original-Received: from localhost ([::1]:46022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llVTo-0006RT-1H for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 07:44:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llVTe-0006RL-MZ for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 07:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llVTe-0006Zk-EM for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 07:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llVTe-0001Yk-B2 for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 07:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 May 2021 11:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41438 X-GNU-PR-Package: emacs Original-Received: via spool by 41438-submit@debbugs.gnu.org id=B41438.16219429935921 (code B ref 41438); Tue, 25 May 2021 11:44:02 +0000 Original-Received: (at 41438) by debbugs.gnu.org; 25 May 2021 11:43:13 +0000 Original-Received: from localhost ([127.0.0.1]:44862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llVSr-0001XR-4E for submit@debbugs.gnu.org; Tue, 25 May 2021 07:43:13 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:48843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llVSj-0001Ws-0C for 41438@debbugs.gnu.org; Tue, 25 May 2021 07:43:12 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id AF50424002A for <41438@debbugs.gnu.org>; Tue, 25 May 2021 13:42:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1621942978; bh=xHYuraZUuITAKxINTlA2UMGUQzxhB99L90Vo6JQAfyA=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=N/yFrKBnt4s8EJlcQZTAt4GMq21a7NU85wdvRxopLB4nsBDoIdptw4pvBVzdyCCj0 DcD5iXf0bmX0x9aclt2n/Lbgw1ppIwIbeYtrELWyUryEF/YWMEfxjWpV3ixcnzLkGG XPedNuygWxJijNwimKAo3r1R9mJAXTM/+E9Mezj+tFI0eqMxHvH0colJ0X9xjSr+fP /rbJY4qC4wbKR/ExR4dDUyStWkUz4Ty6lhJ975lemvijhH6E0xWswt06jwYgwd2/3n ySNKGHWy+LXZb0RkpIFlF45IWr0PQytkUQUaSQxA7HSixbXUz1ksLseHXXIlazug/p x4U2f96yRRnoA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FqBz51v7Nz6tmR; Tue, 25 May 2021 13:42:57 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=mutual; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: (Arthur Miller's message of "Tue, 25 May 2021 13:16:24 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207194 Archived-At: Arthur Miller writes: > Philip Kaludercic writes: >> +(defvar windmove-default-map (make-sparse-keymap) >> + "Map used by `windmove-install-defaults'.") > > Sorry if I ask, but wouldn't ordinary windmove-mode-map do here? You are probably right -- my thought was that the minor mode exists for the sake of the map. > Since it is a convention to have mode maps called modename-mode-maps, > if people would like to change, or add a binding in the windmove mode > they would probably automatically try to alter windmove-mode-map instead > of windmove-default-map. That's the question: should windmove-default-map be accessed by default or only via the -default-keybindings functions? Either way something should be changed, if windmove-default-map it should be renamed to windmove--default-map to explicitly mark it as an internal map. Otherwise it should be renamed to windmove-mode-map as you suggest. -- Philip K.