From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: pillule Newsgroups: gmane.emacs.bugs Subject: bug#48493: 28.0.50; quit-window doesn't work Date: Wed, 09 Jun 2021 15:00:38 +0200 Message-ID: <87v96ni41i.fsf@riseup.net> References: <87h7j0wwkf.fsf@gmail.com> <87cztg41zy.fsf@host.localdomain> <878s434ls1.fsf@host.localdomain> <877djn3r3i.fsf@host.localdomain> <8735u94gt4.fsf@host.localdomain> <87r1hd8bsd.fsf@riseup.net> <87bl8gzov4.fsf@riseup.net> <3f8bf130-2723-27ed-8333-5db4de3515d8@gmx.at> <87y2bji58t.fsf@riseup.net> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6426"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Sujith Manoharan , 48493@debbugs.gnu.org To: pillule Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 09 15:04:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqxsR-0001Ow-T2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Jun 2021 15:04:12 +0200 Original-Received: from localhost ([::1]:36072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqxsQ-00009Y-0q for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Jun 2021 09:04:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqxsI-00009O-3F for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 09:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49198) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqxsH-0005UZ-Rp for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 09:04:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqxsH-00025W-Id for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 09:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: pillule Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Jun 2021 13:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48493 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 48493-submit@debbugs.gnu.org id=B48493.16232438087962 (code B ref 48493); Wed, 09 Jun 2021 13:04:01 +0000 Original-Received: (at 48493) by debbugs.gnu.org; 9 Jun 2021 13:03:28 +0000 Original-Received: from localhost ([127.0.0.1]:60744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqxrk-00024M-0h for submit@debbugs.gnu.org; Wed, 09 Jun 2021 09:03:28 -0400 Original-Received: from mx1.riseup.net ([198.252.153.129]:50978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqxrf-000241-ON for 48493@debbugs.gnu.org; Wed, 09 Jun 2021 09:03:26 -0400 Original-Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4G0S2t1KXszDqr8; Wed, 9 Jun 2021 06:03:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1623243798; bh=YycYdiygrUFX8+7IGvJxJxO+/YRUW+yaB7k0W/Wlf8M=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=GrE96895pkQFKqjNF5/BkZ3s2VIAG4EgM8MnrMpoPOrgbXzPsLog86edKFJxSPbdn Za62bE37FTZAfb5LGQsO+4pN6ITZnNVyy3psAQWbJ0NNLK/XtTXyjOzaupxf++/oGw uBL05U4FtADjvPLBfUwa2sl66Oairi2srSgswhUI= X-Riseup-User-ID: 14952E984E211583A02FCC9DF0C0C83C95FCB4D69F58517FABE93123813957AD Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4G0S2n4vvDz1y6h; Wed, 9 Jun 2021 06:03:13 -0700 (PDT) In-reply-to: <87y2bji58t.fsf@riseup.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208291 Archived-At: >> What's wrong with putting the first disjunct into the >> conditional as in >> the below? In general, always try to avoid larger indentation >> changes - >> they can make forensics cumbersome while bisecting. >> >> (cond >> ;; First try to delete dedicated windows that are not >> side windows >> ((and dedicated (not (eq dedicated 'side)) >> (window--delete window 'dedicated (eq bury-or-kill >> 'kill)))) >> ((and (not prev-buffer) >> (eq (nth 1 quit-restore) 'tab) >> (eq (nth 3 quit-restore) buffer)) > > The difference is a window dedicated with flag t may not be > deletable, and in this case, we want it > to pass through the others conditionals branch of > quit-restore-window, so it can try to use the > 'quit-restore parameter, close the tab or to fallback in t, etc. > Explaining it makes me thing I could use 'window-deletable-p' in > its conditional and ... > I guess, problem solved > I read it again and think you were right, when (window--delete window 'dedicated (eq bury-or-kill 'kill)) is part of the conditional, it indeed already fail if the window is not deletable ; I will correct that in the next revision. --