From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#49247: 28.0.50; [Feature Request] Make tab-bar-lines dragable Date: Thu, 08 Jul 2021 01:54:10 +0300 Organization: LINKOV.NET Message-ID: <87v95ld9bh.fsf@mail.linkov.net> References: <87czs64p5j.fsf@gmail.com> <87lf6tkc1x.fsf@mail.linkov.net> <87r1gl6om0.fsf@mail.linkov.net> <83o8boopit.fsf@gnu.org> <0b86ca8e-d540-12c8-94ac-2f7327f82126@gmx.at> <878s2r9mr8.fsf@mail.linkov.net> <077cf4b1-76ed-4a8c-7c46-bbf5d657ff03@gmx.at> <83r1gil7zk.fsf@gnu.org> <87mtr17r3y.fsf@mail.linkov.net> <4b315d03-599e-47b7-7a39-3ca9c4f9f381@gmx.at> <87eecc32io.fsf@mail.linkov.net> <87eecbcs47.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13741"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 49247@debbugs.gnu.org, s930054123yaoyao@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 08 00:56:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1GSg-0003DV-7G for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Jul 2021 00:56:10 +0200 Original-Received: from localhost ([::1]:44128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1GSf-0000hh-3d for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Jul 2021 18:56:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1GSY-0000hT-Jk for bug-gnu-emacs@gnu.org; Wed, 07 Jul 2021 18:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42183) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1GSY-00011h-Co for bug-gnu-emacs@gnu.org; Wed, 07 Jul 2021 18:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m1GSY-0007IQ-DT for bug-gnu-emacs@gnu.org; Wed, 07 Jul 2021 18:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Jul 2021 22:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49247 X-GNU-PR-Package: emacs Original-Received: via spool by 49247-submit@debbugs.gnu.org id=B49247.162569851127983 (code B ref 49247); Wed, 07 Jul 2021 22:56:02 +0000 Original-Received: (at 49247) by debbugs.gnu.org; 7 Jul 2021 22:55:11 +0000 Original-Received: from localhost ([127.0.0.1]:53729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1GRj-0007HH-9D for submit@debbugs.gnu.org; Wed, 07 Jul 2021 18:55:11 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:42509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1GRc-0007GY-VU for 49247@debbugs.gnu.org; Wed, 07 Jul 2021 18:55:09 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 97466240003; Wed, 7 Jul 2021 22:54:57 +0000 (UTC) In-Reply-To: (martin rudalics's message of "Wed, 7 Jul 2021 09:31:16 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209638 Archived-At: >> Why buffer's mode keymap affects the behavior of clicking >> on the tab-line? > [...] >> The difference is that in the broken case it says: >> >> "Those are influenced by `mouse-1-click-follows-link'" >> >> and translates to , where is a valid >> binding that closes the tab. But translating to >> is a bug, I don't know how to fix it. > > It might happen in `mouse--click-1-maybe-follows-link' but that is > written in terms of `pcase' which I cannot read fluently. Honestly, > key translations are a mystery to me. > > I see two possibilities to fix this without further hassle. Either I > revert my changes Please don't revert your changes: 'drag-with-tab-line' is a valid feature. > or you give up on binding mouse-1 and mouse-2 to different actions. I can't give up on binding mouse-2 to closing the tab because this is what browsers do where mouse-2 closes the tab. > I think that the mouse-2 binding at hand is not > useful because not all people can use it reliably (for example here the > scroll wheel may always slip slightly before pressing it) and all your > remaining keymaps bind mouse-1 and mouse-2 to the same action. Drew suggested to make an exception for the tab-bar. This could solve the problem when the exception will be added somewhere in mouse--click-1-maybe-follows-link. > BTW, I think that the mouse wheel should scroll the tab-line, > if applicable. The mouse wheel already scrolls the tab-line when it's long enough.