From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49869: Revert buffer? Yes/No/Maybe Date: Thu, 05 Aug 2021 12:43:34 +0200 Message-ID: <87v94ki33d.fsf@gnus.org> References: <87im0la99d.fsf@mail.linkov.net> <83pmutl8iv.fsf@gnu.org> <83im0ll7oi.fsf@gnu.org> <83h7g5l6al.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13235"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Gregory Heytings , 49869@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 05 12:44:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBarG-0003Fj-EF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Aug 2021 12:44:14 +0200 Original-Received: from localhost ([::1]:57656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBarE-0005pa-PF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Aug 2021 06:44:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBar6-0005nf-4t for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2021 06:44:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBar4-0001tj-Nu for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2021 06:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBar4-0005n9-FW for bug-gnu-emacs@gnu.org; Thu, 05 Aug 2021 06:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Aug 2021 10:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49869 X-GNU-PR-Package: emacs Original-Received: via spool by 49869-submit@debbugs.gnu.org id=B49869.162816022622231 (code B ref 49869); Thu, 05 Aug 2021 10:44:02 +0000 Original-Received: (at 49869) by debbugs.gnu.org; 5 Aug 2021 10:43:46 +0000 Original-Received: from localhost ([127.0.0.1]:45992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBaqn-0005mU-Rd for submit@debbugs.gnu.org; Thu, 05 Aug 2021 06:43:46 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:51868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBaqm-0005mG-9J for 49869@debbugs.gnu.org; Thu, 05 Aug 2021 06:43:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jE8P2efZ3/gc8Q6xUi9V6lEOQ/4A6ZWEvOWJZqeQiV0=; b=LICGC3Fi2gmoORhl/Tp7smraHd pkZNY07fIHYPjULohJE0SdtN57YYxkSoru6RJ6mqwvQgEQ2vDjpHer5MDWVRyNYk8ROMn0ZgNW4jP iGDqDi04JtxUkdwI1K3XjNYTYoTCk/0jSMo8RCDLCj438PRq/ymaRPUPulnG0hPx01XA=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBaqc-0002dq-Hn; Thu, 05 Aug 2021 12:43:37 +0200 In-Reply-To: <83h7g5l6al.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 04 Aug 2021 15:53:54 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211212 Archived-At: Eli Zaretskii writes: > I don't think we need to cater to personal preferences by adding new > commands. The `C-x x g' binding is new in Emacs 28, and we can bind it to a command that we thing is a good one. Eli Zaretskii writes: > And second, are you talking only about reverting when there are no > unsaved changes? If so, what are the use cases when you need to do > such a thing, and why? When a file changes outside of Emacs. It happens a lot, especially after doing "git pull". But... looking at how Emacs handles this in other similar commands, I'm not convinced that the `y e s RET' is excessive in `C-x x g': For instance, if you `C-x C-f M-n RET' (which was the previous way to revert the buffer (but didn't work reliably because of DWIM)), it'll also ask you to type `y e s RET' afterwards. So for user interface consistency, I think it might make sense to leave `C-x x g' as is -- at least in the default case. Perhaps there should be a user option to customise the level of prompting here. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no