From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#49980: 28.0.50; [PATCH] Should we have project-save-buffers? Date: Fri, 13 Aug 2021 10:12:24 +0300 Organization: LINKOV.NET Message-ID: <87v949ddif.fsf@mail.linkov.net> References: <87czqlodpl.fsf@gmail.com> <871r70lnyi.fsf@mail.linkov.net> <87y297azuu.fsf@mail.linkov.net> <3ea58870-6b9a-41b9-c06e-d045ff9764b9@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37541"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Giap Tran , 49980@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 13 09:16:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mERQJ-0009WS-PG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Aug 2021 09:16:11 +0200 Original-Received: from localhost ([::1]:57960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mERQI-0000SA-4w for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Aug 2021 03:16:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mERPD-0007zd-75 for bug-gnu-emacs@gnu.org; Fri, 13 Aug 2021 03:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mERPD-0007vZ-0t for bug-gnu-emacs@gnu.org; Fri, 13 Aug 2021 03:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mERPC-00081A-SY for bug-gnu-emacs@gnu.org; Fri, 13 Aug 2021 03:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Aug 2021 07:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49980 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49980-submit@debbugs.gnu.org id=B49980.162883887730741 (code B ref 49980); Fri, 13 Aug 2021 07:15:02 +0000 Original-Received: (at 49980) by debbugs.gnu.org; 13 Aug 2021 07:14:37 +0000 Original-Received: from localhost ([127.0.0.1]:40420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEROm-0007zj-S6 for submit@debbugs.gnu.org; Fri, 13 Aug 2021 03:14:37 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:55051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEROj-0007z1-L7; Fri, 13 Aug 2021 03:14:35 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id E4FC31C0006; Fri, 13 Aug 2021 07:14:25 +0000 (UTC) In-Reply-To: <3ea58870-6b9a-41b9-c06e-d045ff9764b9@yandex.ru> (Dmitry Gutov's message of "Fri, 13 Aug 2021 05:06:17 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211719 Archived-At: tags 49980 fixed close 49980 28.0.50 quit >> Or to a new prefix map, e.g. 'C-x p x s' with mnemonics "eXecute Shell". > > That would also displace project-execute-extended-command, which seems > gratuitous. And if we were putting different commands together to save > keymap space, 'project-compile' seems closer in purpose to 'project-shell' > than 'project-execute-extended-command'. > > Anyway, 'e' as a mnemonic for 'Eshell' or 'shEll' seems good enough for me. Then maybe 'C-x p e e' for 'Eshell' with a mnemonic "Execute Eshell", and 'C-x p e s' for 'Shell' with a mnemonic "Execute Shell". >>> Is there any reason not to just use 'save-some-buffers' (C-x s)? >> In bug#46374 we are adding a new option 'project-root' >> to 'save-some-buffers-default-predicate' that will allow >> 'C-x s' to save only files under the same project root. > > That also seems to indicate that we don't need a separate command. Indeed, so after pushing the patch to use the project root in bug#46374, now closing this request too.