From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: p.stephani2@gmail.com, pipcet@gmail.com, 33414@debbugs.gnu.org
Subject: bug#33414: 27.0.50; inhibit-changing-match-data can be t in syntax-propertize functions, breaking backtrace and looking-at
Date: Sun, 05 Sep 2021 11:45:50 +0200 [thread overview]
Message-ID: <87v93fmk35.fsf@gnus.org> (raw)
In-Reply-To: <83v93ftl6e.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 05 Sep 2021 12:40:25 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> FWIW, I don't share the above view. We bind variables to affect
> behavior of functions all over the place, and that is perfectly okay,
> IMO.
This one leads to really hard to debug problems, though.
>> -@defun looking-at regexp
>> +@defun looking-at regexp &optional inhibit-save
> ^^^^^^^^^^^^
> A typo?
Yup. I changed the name of these parameters five times while writing
the patch.
>> +(make-obsolete-variable 'inhibit-changing-match-data nil "28.1")
>
> Really? why obsolete it?
Because it's not used (and shouldn't be used). `save-match-data' is the
proper way to achieve this in normal code.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-09-05 9:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 13:30 bug#33414: 27.0.50; inhibit-changing-match-data can be t in syntax-propertize functions, breaking backtrace and looking-at Pip Cet
2018-11-17 13:46 ` Eli Zaretskii
2018-11-17 14:14 ` Pip Cet
2018-11-17 14:36 ` Eli Zaretskii
2021-08-12 13:11 ` Lars Ingebrigtsen
2021-09-04 18:39 ` Philipp
2021-09-04 19:33 ` bug#33414: [External] : " Drew Adams
2021-09-05 9:29 ` Lars Ingebrigtsen
2021-09-05 9:40 ` Eli Zaretskii
2021-09-05 9:45 ` Lars Ingebrigtsen [this message]
2021-09-05 9:55 ` Eli Zaretskii
2021-10-07 18:49 ` Lars Ingebrigtsen
2021-10-07 19:07 ` bug#33414: [External] : " Drew Adams
2021-10-07 19:11 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v93fmk35.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=33414@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).