From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuchen Pei Newsgroups: gmane.emacs.bugs Subject: bug#50497: [PATCH] Adding eww-{next,previous,up,top}-path. Date: Fri, 10 Sep 2021 22:50:45 +1000 Message-ID: <87v938wq56.fsf@ypei.me> References: <87lf45xh86.fsf@ypei.me> <87ee9wpt38.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=====-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31391"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.13; emacs 27.2 Cc: 50497@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 10 14:54:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOg2r-0007vd-5C for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Sep 2021 14:54:17 +0200 Original-Received: from localhost ([::1]:56134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOg2p-0005PU-TS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Sep 2021 08:54:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOfzi-0001yR-QH for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 08:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53886) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mOfzi-00017j-Ij for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 08:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mOfzi-0005yQ-Ge for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 08:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuchen Pei Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Sep 2021 12:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50497 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50497-submit@debbugs.gnu.org id=B50497.163127825922952 (code B ref 50497); Fri, 10 Sep 2021 12:51:02 +0000 Original-Received: (at 50497) by debbugs.gnu.org; 10 Sep 2021 12:50:59 +0000 Original-Received: from localhost ([127.0.0.1]:37199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOfze-0005y7-Ki for submit@debbugs.gnu.org; Fri, 10 Sep 2021 08:50:58 -0400 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:57723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOfzc-0005xv-FS for 50497@debbugs.gnu.org; Fri, 10 Sep 2021 08:50:56 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id B11DF32009A0; Fri, 10 Sep 2021 08:50:50 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 10 Sep 2021 08:50:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ypei.me; h= references:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; s=fm2; bh=uKqd5wzpyxKS3HwSxdSsPTXt3m 0cqdTUSkqSsbZHMR8=; b=RjK6Tl7cJvPFNHa+WKCIUe5LFZni5hX3kemRLJBA7I vA56OeG5VTUn7y5ldsjw6tlDi++8GgXMJjspBlNXXJel9UOzdtpMJE1G3/u9kM+p 1NPH5zinnYw9c5IDff97NnbGbeCM7k1niTGyympHf56Ee8XD+oowHdMy7RacmsEO xMQgVcsPHfQtdJ2H6wotv0s/o9WNF5NEKMG2/EUBk5K4bDrNTo5wP4InJcaOgELi 75bNf8M6GJuT9C3rvoDJMx3gjkH4XkZVdr9fyXe4WC7zMn+nwqR1b6cu8Ba+lIrt DACGPHBu3/g6EVak7RnE7ynrVy/quxx0kmEjZO7CyjPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=uKqd5w zpyxKS3HwSxdSsPTXt3m0cqdTUSkqSsbZHMR8=; b=RrgIDHkpGgqhHfEhAMdQZe mc8blrAILez7qvVrInmkYlvwaqNW+bcNw+t9aV1qu4Pmvo1CsVDGThjp2LW/q9v9 WqEsFfkm+NpZwikb6r47RB+GKHQKQ6ivwm68Mhq6MwecXfDds4bv0Z8b+7+uyIiK H43yp3NLBJEuPckMBcerTsNdqqXeL+yGBV7c+7MnxG5QDMguvL8Kjm7CCnPQm8yv 3riuqS05e/IgXMpFAu4edN3x6nCagzWRXpol4o45Olcwv0iZHpiAXaG+CKOzOC3x 7Wbut5V69NDyJ1gZubnP/90iEhvS9eCRUbJUyQCiVOjGNcLkf2YHROcAsfIojJeQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeguddgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufgjfffkgggtsehgtderredtredtnecuhfhrohhmpegjuhgthhgv nhcurfgvihcuoehhiheshihpvghirdhmvgeqnecuggftrfgrthhtvghrnhepudetgeegtd fgleefiedtffevgfdvteevkeffhedvteegteetveejfeetveefhfevnecuffhomhgrihhn pehlihgsrhgvphhlrghnvghtrdhorhhgpdihphgvihdrmhgvnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhiseihphgvihdrmhgv X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Sep 2021 08:50:48 -0400 (EDT) In-reply-to: <87ee9wpt38.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214005 Archived-At: --=====-=-= Content-Type: text/plain; format=flowed Lars Ingebrigtsen writes: > Yuchen Pei writes: > >> I often find myself wanting to navigate paginated web pages >> (e.g. ), or to go >> up or >> all the way up when visiting a web page, which is why I added >> these >> functions to my eww. >> >> Does this change make sense? If so I will amend the patch to >> include >> tests, doc and bug number. > > I'm not sure this is general enough to include in eww -- these > are > commands that will fail in 99.7% of all web pages, because they > don't > have URLs that are structured this way. OK, how about having them as a fallback to eww-{nex,previous,up,top}-url, as Juri mentioned? From my experience these -url functions don't work for most web pages either, so adding my functions as a fallback would increase the chance that the keys will work in some meaningful way. -- Best, Yuchen PGP Key: 47F9 D050 1E11 8879 9040 4941 2126 7E93 EF86 DFD0 --=====-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIEEARYIACkWIQRH+dBQHhGIeZBASUEhJn6T74bf0AUCYTtUpQscaGlAeXBlaS5t ZQAKCRAhJn6T74bf0LQIAQDLUywZCqDDF4Ef95Ll8esIMNpaDK2xAE5g5ywWm9oE JQD/e95MzVTnCPkRppBtjBI83uyUlgb4LSfEXLk9PDEWIgI= =RXQk -----END PGP SIGNATURE----- --=====-=-=--