From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: miha--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50806: 27.2; [PATCH] Optimize ansi-color.el Date: Mon, 04 Oct 2021 12:07:09 +0200 Message-ID: <87v92df6ia.fsf@miha-pc> References: <87tui8wakb.fsf@miha-pc> <25ed8125-3f78-c9c9-9324-d75e48e702c6@gmail.com> <87fsthc21u.fsf@miha-pc> <87czolp2bd.fsf@gnus.org> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34872"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , 50806@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 04 12:04:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXKpc-0008oh-Gl for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Oct 2021 12:04:24 +0200 Original-Received: from localhost ([::1]:42022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXKpb-0002dj-0c for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Oct 2021 06:04:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXKpG-0002Rn-IR for bug-gnu-emacs@gnu.org; Mon, 04 Oct 2021 06:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52428) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXKpG-00048o-8m for bug-gnu-emacs@gnu.org; Mon, 04 Oct 2021 06:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mXKpF-00025q-VN for bug-gnu-emacs@gnu.org; Mon, 04 Oct 2021 06:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Oct 2021 10:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50806 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50806-submit@debbugs.gnu.org id=B50806.16333418218016 (code B ref 50806); Mon, 04 Oct 2021 10:04:01 +0000 Original-Received: (at 50806) by debbugs.gnu.org; 4 Oct 2021 10:03:41 +0000 Original-Received: from localhost ([127.0.0.1]:35741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXKov-00025C-4l for submit@debbugs.gnu.org; Mon, 04 Oct 2021 06:03:41 -0400 Original-Received: from kamnitnik.top ([209.250.245.214]:41860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXKos-000253-Tf for 50806@debbugs.gnu.org; Mon, 04 Oct 2021 06:03:39 -0400 Original-Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43]) by kamnitnik.top (Postfix) with ESMTPSA id 2DBB59C700; Mon, 4 Oct 2021 10:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top; s=mail; t=1633341817; bh=uF6b/QmLbxqgOKPJaidVpeq//qotNBRS4jEmQaLuqO4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=n9ZTBGE1i1OheqqK9SYYmWSYENrP7S2q9tNu4Dc9h5reW+sdnvNMp+cB21KJ1MevW U7TCrC6nm0LrxH+j4c8WSS77B1h5cVRV2n7rttpY9udUY2v+xT5Fu8sHHy3OFHVB/m i4i3kcWkSJMfe09PchRf+vVz+GJ5nmctbF6p4lYByJOJmCtpR5o1h8BIvB0Jia6hMl qJPCdkd0XSUL3ZSOYOSKWPhb6fy9k/6Q7HfyYctCPJFZBq+w2ZjSzx1acyqQJFZaf7 IcG9aRTrQDEd78DpTGhJ1W1Hw7N+1WQf3UU6j6qjrr/Cy/nOEASHNJFwxH4VAArAXK +LUe/VIQzWZ3w== In-Reply-To: <87czolp2bd.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216339 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > writes: > >> Ok, thanks. I have actually already prepared patches for all these >> features: full-color in ansi-color.el and term.el and also "basic" ANSI >> escapes 1-8 for term.el that you mentioned. >> >> I guess there's no harm in sending them right now. > > We could apply both the patch to optimize ansi-color.el and add this new > stuff now (to the Emacs trunk, i.e., Emacs 29), but there was some > discussion about merging... er... something? That I didn't quite > understand? :-) Yeah sorry for the confusion. We were talking about "merging" two vector variables of length 8 into one vector variable of length 16, specifically, replacing the two 'ansi-color-*-colors-vector' variables with one 'ansi-color-colors-vector'. These two variables are public and introduced in Emacs 28. If we wanted to merge them, we'd have to do it on the Emacs-28 branch. However, the performance gain from having them merged is negligible, so I think there will be less complications if we just leave them as they are. This means that patching Emacs-28 isn't required and all my patches from my second mail onward are meant for Emacs 29. > > So just to clarify --=20 > > Subject: [PATCH] Optimize ansi-color.el > > and > > Subject: [PATCH 2/4] Add support for 256-color and 24bit ANSI colors in a= nsi-color > > are independent patches, and they should both be applied to Emacs 29? Yes, [PATCH] Optimize ansi-color.el (from my second e-mail) and [PATCH 2/4] Add support for 256-color and 24bit ANSI colors in ansi-col= or are meant to be applied to Emacs 29 on top of each-other. > > --=20 > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmFa0k0THG1paGFAa2Ft bml0bmlrLnRvcAAKCRCzCRoakhWZPzPND/0dZ1g0eBNyseOofNj/BIuX/ICJh+FX fREQEMpIsFbyd8Q0/Ac4TwQu2BBUsUMhD7zGfTCOveo1dJeblStUq3yPKbE504rE cDOeA3TQ7hBcydS1Cmk9o1718h+ggwHIyUyd/ubqZ2FVxp77NDu0H8uOWPFSQUeX cv0qJxyvkWfWUZecOgXqsDw038kxKW+EpiJU6bJJlEQ636FtgJlO9NupLK3HUCVV Oa2H4X1dlb+WMAYaAXKiJJ4Xpq/2B6hdis0VybfxfUQWFPrMxdmNDjZgovPA0KED R0fKpchG+tUo5h13IJynUOpWtqR8oHonIaZE16mewYD6ci35Au70um+VzNJg+Frj JwAhBWp3C9vsGV6CiUQ5lxWHWqXe4uwoSZJo3ZLkNRccCUCBjZFs6I/O139RMaTE e3fXaIQvU8oqGePYaSiehn4Yc7OdiS0E5C5p4T+8thZcbKTHFmX7G7brI6szbI0u rm2Hr1mc0wrHk9CjgpPjxzzQjVWQMsN2T6sYFIRCRcF7REBSlpVihjsXcD/m96SO EohHb/R/CjaKMnUwO08mc0yh6GdWuX5kgIuCeCl73kidGSgr3QdNwKNujj8w+jkq nnbAv5hZF+DBVSrGlITBbSqofD5ovoQcmq3op7mJWfmsO4BUg14FErMkQ8X5MAbS KC999/IMjlipmg== =ub0E -----END PGP SIGNATURE----- --=-=-=--