unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#51009: 29.0.50; [PATCH] Fix small error in comint-send-input
@ 2021-10-04 14:21 miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-10-05  7:42 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-10-04 14:21 UTC (permalink / raw)
  To: 51009


[-- Attachment #1.1: Type: text/plain, Size: 306 bytes --]

To reproduce this error, emacs -q:

1) M-x shell
2) Press RET a few times to make some shell prompts
3) Press C-p to go to the end of a non-last prompt
4) M-x comint-set-process-mark
5) type "echo foo" RET

An error is then signaled:
ansi-color-apply-on-region: Invalid search bound (wrong side of point).

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-Fix-small-error-in-comint-send-input.patch --]
[-- Type: text/x-patch, Size: 905 bytes --]

From 0a445ba23f18a902f807b36489695648b2e20b9a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miha=20Rihtar=C5=A1i=C4=8D?= <miha@kamnitnik.top>
Date: Mon, 4 Oct 2021 13:49:43 +0200
Subject: [PATCH] Fix small error in comint-send-input

* lisp/comint.el (comint-send-input): Run
comint-output-filter-functions with comint-last-output-start set
correctly.
---
 lisp/comint.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/comint.el b/lisp/comint.el
index 1e5b990c77..a0873c0b6a 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -1990,6 +1990,7 @@ comint-send-input
 
         ;; This used to call comint-output-filter-functions,
         ;; but that scrolled the buffer in undesirable ways.
+        (set-marker comint-last-output-start pmark)
         (run-hook-with-args 'comint-output-filter-functions "")))))
 
 (defvar comint-preoutput-filter-functions nil
-- 
2.33.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#51009: 29.0.50; [PATCH] Fix small error in comint-send-input
  2021-10-04 14:21 bug#51009: 29.0.50; [PATCH] Fix small error in comint-send-input miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-10-05  7:42 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2021-10-05  7:42 UTC (permalink / raw)
  To: miha; +Cc: 51009

miha@kamnitnik.top writes:

> * lisp/comint.el (comint-send-input): Run
> comint-output-filter-functions with comint-last-output-start set
> correctly.

Thanks; applied to emacs-28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-05  7:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-04 14:21 bug#51009: 29.0.50; [PATCH] Fix small error in comint-send-input miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-05  7:42 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).