From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware? Date: Sat, 30 Oct 2021 17:43:24 +0200 Message-ID: <87v91eself.fsf@gmx.de> References: <69264ece-bb7f-4db1-f461-dacd33db2402@gmail.com> <87cznqev5g.fsf@gmx.de> <2c3dffbc-9af0-f318-15bc-cce91a106898@gmail.com> <8735olwp95.fsf@gmx.de> <94c1e53f-98cb-8891-77d9-81f3c401149e@gmail.com> <878rydxfgl.fsf@gmx.de> <5cbecece-e982-6362-9eac-1610f00f4929@gmail.com> <87k0hwgs1x.fsf@gmx.de> <6753920a-655a-7aa2-b0fa-a1ac01b80eac@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12378"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51426@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 30 17:44:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mgqWo-00035P-SW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Oct 2021 17:44:18 +0200 Original-Received: from localhost ([::1]:51968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgqWn-0007MB-Q6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Oct 2021 11:44:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgqWY-0007M1-83 for bug-gnu-emacs@gnu.org; Sat, 30 Oct 2021 11:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46654) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgqWX-0007ro-Vs for bug-gnu-emacs@gnu.org; Sat, 30 Oct 2021 11:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgqWX-0005VU-RT for bug-gnu-emacs@gnu.org; Sat, 30 Oct 2021 11:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Oct 2021 15:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51426-submit@debbugs.gnu.org id=B51426.163560861421117 (code B ref 51426); Sat, 30 Oct 2021 15:44:01 +0000 Original-Received: (at 51426) by debbugs.gnu.org; 30 Oct 2021 15:43:34 +0000 Original-Received: from localhost ([127.0.0.1]:58200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgqW6-0005UX-E8 for submit@debbugs.gnu.org; Sat, 30 Oct 2021 11:43:34 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:49991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgqW4-0005UI-Rp for 51426@debbugs.gnu.org; Sat, 30 Oct 2021 11:43:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1635608606; bh=2+IfkvlCQ5Q7HE6+AIsi431ddIWJjq60FJNPUWHem5U=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=bHdaBLnNogN79l8U0mIQwzGKoJTxIIYUuTycPsfIfsknJ2mXIfabKQjYYvTW38W9x k7H3OaDdvCarGbKyv29qF3UP8lMfriimTSZRu3mVCOjcD80oO0QJ/RqSRAgsJifPtF 4ygmGNdflSGj+qJWtvX2PcnpcpikhT4NE6yXnFB4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.238.22]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MO9z7-1mIJVc32Ub-00OUds; Sat, 30 Oct 2021 17:43:25 +0200 In-Reply-To: <6753920a-655a-7aa2-b0fa-a1ac01b80eac@gmail.com> (Jim Porter's message of "Fri, 29 Oct 2021 09:39:15 -0700") X-Provags-ID: V03:K1:LW89PiPqZqEHFdoeyxvl5s0KdfilkPuOeXuB6sOviiEovtOrZM4 9pPRKkCH9XWsWSlGvtSPtWeMhw29VfaTlqn1BvWo6j8sLNNtIKcvYzrIKdt+e5LPot1YzSU PhoNAOVyf4OLMS+AE+3Gz56F2xEHO633t9OMwPhSM5rBBJz7JjNOCXp3zEc5nULgrw1mom5 fjneaNlydAOUzenb52xSA== X-UI-Out-Filterresults: notjunk:1;V03:K0:cpFGL47FRnY=:2l3szEJBYGC0lbRjatWWA/ +Wh9PW3zTYtJhcoc2a3pdUz6XpEF1M7GWb6wXwMXNNzMDFPypo65DDP4RKFFzF7uR6qur8TPw gS+lRW+vGR+SY+o5BMJS6J80QRYMQpvt7nX1ENKg9Z2diL7y8OpdRuM7p4Ogy7cV8ETa+7Ft4 A/VhU0FDNcv5zA0qzrqeH+74EWmKHzb58VAh3Cw/pD2KmH5/URsn3oDL8KCcNdEI1GweJiRm6 /Rn3D1Bhhf3xemtT4/qYmX5hCUwuKFtO/YZB8UsWq80FqlLRv/i4NTJs4HXdq9ZrWkw0TV7GP gnNGYED9PiEj8971VZsY91Tr9SFlG3nSI90TWNjWOjEqvNvd8m8TM8bprv3uTEv9baWmKWaKz APa4ICBaADQNCsPVVLMkrsx2V3vr/axwseK6ajl9EJuiHxjO1EXVKGWJFzMTzVpb2ut0QrV17 re3CH0YVoSQoQ61Ag2VXh+9jYWrhLAVtYfZPk/E7rBu1f3fcLMBoAHRPcCZ6jbDeIthlGRscG kH1tK/Dt6280SlHz0uYykctIX2sifUuVxfmUHNBXeYyG7sGj6TleEHV9NgdYS74lRMs93K6Hr 6k7FY9SiNBYImS8TbgEOTOr0W/yds+MqfrSvSHi2yyvmyAu/Gl4kwcZ7cYYMnKZOu1hpyZnN+ R48vVSoXvaoXPcUF0Bfew+9OWBfzsSIBnKdp3BccYEFXXxyUL1pFh2bsJtphs4LBPBLoxqbEs LCT9FMmI6i9gZdXeAG8Yzov69DAElh8SHcSMH4j4U/slpWlX0Re5kTJlRot6aa0JxlkH8dXn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218620 Archived-At: Jim Porter writes: Hi Jim, >> Thanks. However, you don't show the second setting, >> comint-terminfo-terminal. Is it obvious to the reader that this shall be >> changed as well? > > I didn't change it initially because I wasn't sure it's a value that > people are likely to change connection-locally. `system-uses-terminfo' > is definitely important to be able to set connection-locally: while > many systems support terminfo, some don't (e.g. FreeBSD and MS > Windows). `comint-terminfo-terminal' seemed less consequential. > > However, after doing a bit of archaeology, I think it might make sense > to `comint-terminfo-terminal' connection-locally in the example, so > I've attached an updated patch. `comint-terminfo-terminal' was only > added in Emacs 26.1, and I believe the "dumb-emacs-ansi" terminfo file > was added to Debian's ncurses after that, so it makes sense that > someone would want to set this differently when connecting to a newer > host vs an older host. (I think TERM=dumb-emacs-ansi is the best > setting to use if your terminfo database has it, since it reflects > comint's capabilities more accurately than TERM=dumb.) > > I didn't explain the above reasoning in the manual though, since it > won't be so relevant as time goes on. Once people see that you can do > this, it should hopefully be reasonably obvious why. If we need more > explanation beyond this, it probably makes sense to expand the > docstring for `comint-terminfo-terminal'. Thanks. I've pushed your patch almost as-it-is to master (adding a missing space). Best regards, Michael.