From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51411: NS port cleanups Date: Sun, 31 Oct 2021 19:26:05 +0800 Message-ID: <87v91digfm.fsf@yahoo.com> References: <87mtmwt3mc.fsf.ref@yahoo.com> <87mtmwt3mc.fsf@yahoo.com> <87h7d4t0er.fsf@yahoo.com> <87ee86q7jm.fsf@yahoo.com> <87ilxhmlwc.fsf@yahoo.com> <87lf29jxeg.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4622"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 51411@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 31 12:27:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mh8zm-0000wb-VT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Oct 2021 12:27:27 +0100 Original-Received: from localhost ([::1]:50662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mh8zl-0002Uc-0Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Oct 2021 07:27:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mh8zO-0002St-Lp for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 07:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mh8zO-0000Kk-Dc for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 07:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mh8zO-0003Rq-7p for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 07:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Oct 2021 11:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51411-submit@debbugs.gnu.org id=B51411.163567958613209 (code B ref 51411); Sun, 31 Oct 2021 11:27:02 +0000 Original-Received: (at 51411) by debbugs.gnu.org; 31 Oct 2021 11:26:26 +0000 Original-Received: from localhost ([127.0.0.1]:59135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mh8yo-0003Qz-25 for submit@debbugs.gnu.org; Sun, 31 Oct 2021 07:26:26 -0400 Original-Received: from sonic316-22.consmr.mail.ne1.yahoo.com ([66.163.187.148]:39803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mh8yl-0003Ql-TO for 51411@debbugs.gnu.org; Sun, 31 Oct 2021 07:26:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1635679577; bh=qcRkW/rKtm8M0moeMBwzCaTKr7ks77EtvzN6p4n0QOA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Z6K6Lw0V2ezTKM71nc47T9IhQ2zO9NSgeKJD/1AVKXVO1K8KuTnvPtNyn/V4eA3Ac2gmirIyvG90c2w8zDbDl88VEDRUkJPvQkxzvSNF4bZiuA4i/OrpNaYDa4ribRdwIeoAx2JEvP9kiWiKV/KG47KsQYzcEEcoIuIje+zMzBKpd7LwVceCU85pAkZB43WMPGpubATkdCyYBKEoBvlCH1m40F8iPIofMn7u5a/uQ23UCFwlFaxJFcRwT1KNdAzA/KxxlxXT1PKU1LWVBbNBvjLAdUVQdHpOjymTSXr56CGn+Wc1SHzcnSC+9gW/T8XoYr9cH21Ta3Th2exjoLJSwg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1635679577; bh=xZ0V4dEzDkeBR7KJKGozDDK4foGuL+kzCrisxw8cQOw=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=grKignXeut8nZfG8iVDCZhug9Gr339WS/w7lvF6BwXBaN/14pZ6fAE1GMU6UEzIL5lRhakaKmGSUZEDTJfLDJAnLVw6DqPMTiISdXAGMy0LRm/3ICzXEbx6MPX241uimkLaQLKCTvsTQc91CsTAT3qxDk8fVaQTbiQvZBjoCkgBGNY7WRE4S8UUfiE4YtmmQmE2HLi4zojFDzwWXurYgJ7/vN/U5xZkJkn1WWAz2CpvSdDo1qF4KVt6Imouz5KIzh0yVmCl1bNQcDcjiiTBWxIAmE55wGXbc+MRDoddR+CgPnIEAo2qokQhg9F3IgMUYV7oNx7ST1fd4XRsjhHwsaw== X-YMail-OSG: zPVRwGwVM1ne1oWgiRJ44ZvAYR8KxMzQWpPeoWbtA9I4SHiQho_ydepi59B6lGg EbKnLqI2kixF5CH06PBMlGhw9rhFogSuEr_q97KdmpOq5cI7Ugec4ZP2r53g8qD2IpqiTyaR27gp A7567ZVIe6xX_ST_xDLFXiSORojgQU76_V9Bu6QmwhOuQwjVD61AXqVKjgEvPXiA.3vUyllTcqI2 UjBd9XcwA27QwQcHN2JoB7kILQU4HW9FMKxSPVBhhyfPHhFs.6mzICCZ5zwD9E5vfBlUZ7KNYZcG OX_iNmQEOpqMEa665wGblSJHZEok2IvCD_Dnl1Zf70.TI9QC3DvPSVuwjU.TKhpmx7HX5eOK4.O9 ruTK3dtCt2M1Ja6bA.kBacWCYPGLmQ1wx3qnGttSMqR.doKRHV3OvHx.7EjEQ9afgxQxG68rMInT Uxyhyr7n3Ko4_fKbFPFOklvRsHIor29kZ2GXfpX8JBFqE.3nV7EXtKr2n1nv0CMM698Ij7QvVuxm y55t72q6qgt5awVpPVk3Xqyjfb_veyLazGFiPyeGx2_jdJL9POkYs0q2jav.b8QlAzsbffFEcpxC 5Y6GvBv.cg_QaDra3v7ADbeofBaY47_gKSWFEOpioTBlvwi4LFrdGCP0mCCWC1TtA5m2Al0k4YJa ZobGttxCLXLvSoRkXhL3.yEg782F6SVGMy96mwuyHuXan2zAhFJeBuLEnTk6GbvR9RH09bzUZx1D I7oXbt6u9fDiypZeNcE8aOwa7QxbA3KxltqbnbVjXTBQTElr1aU8kFH17VPQQfR8vpmKkP7rX5IL UB.kyZ.o1b7IyapWRgiIRKQDicZ9IR1Lb6.uHrPoRQ X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Sun, 31 Oct 2021 11:26:17 +0000 Original-Received: by kubenode512.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID d9c1bdb9a9eb2dc171e9f68fa0b3a273; Sun, 31 Oct 2021 11:26:09 +0000 (UTC) In-Reply-To: (Alan Third's message of "Sun, 31 Oct 2021 10:59:40 +0000") X-Mailer: WebService/1.1.19198 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218674 Archived-At: Alan Third writes: > I noticed that you removed all calls to ns_focus in > ns_draw_window_cursor and thought you'd removed all calls to ns_focus, > but now I see that's an older change. > > Is that a good idea? I think ns_draw_window_cursor is sometimes called > without matching ns_update_begin/end calls, so it needs to focus, or am I > misunderstanding the flow? I don't know if ns_draw_window_cursor is called outside ns_update_begin/end, but if that's the case then I'm not sure how, for instance, double buffering would work on the X port. Thanks.