From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Feng Shu" Newsgroups: gmane.emacs.bugs Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Date: Sat, 20 Nov 2021 07:03:18 +0800 Message-ID: <87v90nhhop.fsf@163.com> References: <87bl2nhbyp.fsf@163.com> <87o86nfs2l.fsf@gnus.org> <83czn3w7c2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2042"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 51821@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 20 00:04:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moCvb-00008f-H3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 00:04:19 +0100 Original-Received: from localhost ([::1]:59488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moCvZ-0001by-Jl for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 18:04:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moCvK-0001bV-A4 for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 18:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moCvK-0005Vq-1o for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 18:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moCvJ-0006qb-Ta for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 18:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Feng Shu" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Nov 2021 23:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51821 X-GNU-PR-Package: emacs Original-Received: via spool by 51821-submit@debbugs.gnu.org id=B51821.163736301526280 (code B ref 51821); Fri, 19 Nov 2021 23:04:01 +0000 Original-Received: (at 51821) by debbugs.gnu.org; 19 Nov 2021 23:03:35 +0000 Original-Received: from localhost ([127.0.0.1]:40750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moCus-0006po-U9 for submit@debbugs.gnu.org; Fri, 19 Nov 2021 18:03:35 -0500 Original-Received: from m12-14.163.com ([220.181.12.14]:56643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moCuj-0006pU-0D for 51821@debbugs.gnu.org; Fri, 19 Nov 2021 18:03:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=oyQaw 7OI/3AetJA789HCJVPrdtPBnWdKpYcAk32kGV4=; b=LCu0mKlESTlAGXMdTh5FN FvmM2RGvMspu1nomdoYpBAr/c/S1bv1+IHpJHh1g1GnJ3bTuqeNPSM+zzncJNHYK vyYUT4gKqB4LFkR05HvOYQRSgBPuRmst9RCIKxTpw8LeDiFyrtWP2pKtIqoGDtQG ZJDmRPLy/GB3KBbNErUhyg= Original-Received: from tumashu (unknown [49.88.37.140]) by smtp10 (Coremail) with SMTP id DsCowACnnMo3LZhh2Y3dTQ--.24636S2; Sat, 20 Nov 2021 07:03:19 +0800 (CST) In-Reply-To: <83czn3w7c2.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Nov 2021 08:59:41 +0200") X-CM-TRANSID: DsCowACnnMo3LZhh2Y3dTQ--.24636S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7KFW7JF1DXr1DtrW5tFW5KFg_yoW8JF43pa sFgwn5GrZ3GF4rZw4kCFnY9FZFgrs3XFW2kF9aka4jvF4kGryIvrW7trs0kr9Fyr1Uur4j q3y2kr1xGa4xAa7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRy5lnUUUUU= X-Originating-IP: [49.88.37.140] X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/xtbBLBdQ1F++OAn+AAAAsR X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220439 Archived-At: Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> Date: Sun, 14 Nov 2021 02:23:46 +0100 >> Cc: 51821@debbugs.gnu.org >> >> "Feng Shu" writes: >> >> > Maybe we should add a variable or frame parameter: line-height >> >> Sounds good to me. Perhaps call it min{imum,}-line-height, though. > > IMO it should be line-height, for similarity with line-spacing. Hi Eli and Lars yestaday, I have tested with hack version of your patch, I think line-height or line-height-factor is not a proper way to solve my core problem. My core problem is how to let tab/mode/header-line and minibuffer's height do not change depend Chinese exist or not. line-height-factor can let their height do not change, but the problem is that the result looks very ugly, for line-space very large, It will be painful in daily use. so I think the good approach maybe is providing a simple way, by which we can easy let no-ascii font use small height if a face is not used in table like environment. In my opinion "1 Chinese char width = 2 * ASCII char width" is *only* useful in table like environment. let Chinese char's height <= ASCII char's height will work well in other situation, and have no tab/mode/header-line height change problem too. --