From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#52324: 29.0.50; "Padded" mode line lacks uniform border Date: Sun, 12 Dec 2021 08:58:32 +0800 Message-ID: <87v8zu1vwn.fsf@yahoo.com> References: <877dciyusl.fsf@protesilaos.com> <83k0gh23ka.fsf@gnu.org> <837dcbqmmr.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9316"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: 52324@debbugs.gnu.org, info@protesilaos.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 12 01:59:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwDCn-0002DV-SH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 01:59:09 +0100 Original-Received: from localhost ([::1]:44742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwDCm-0004Q4-Hv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Dec 2021 19:59:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwDCg-0004Ok-3O for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 19:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38776) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwDCf-0001MV-RM for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 19:59:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwDCf-0007Ul-MZ for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 19:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 00:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52324 X-GNU-PR-Package: emacs Original-Received: via spool by 52324-submit@debbugs.gnu.org id=B52324.163927073128794 (code B ref 52324); Sun, 12 Dec 2021 00:59:01 +0000 Original-Received: (at 52324) by debbugs.gnu.org; 12 Dec 2021 00:58:51 +0000 Original-Received: from localhost ([127.0.0.1]:50322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwDCV-0007UL-5t for submit@debbugs.gnu.org; Sat, 11 Dec 2021 19:58:51 -0500 Original-Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]:44686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwDCT-0007U9-Rb for 52324@debbugs.gnu.org; Sat, 11 Dec 2021 19:58:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639270724; bh=VfY4iMpBdWut2vMIg1YqXOUWxBDm55qfQ1Wmwdwm7bM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=GsE+Hy+r1/JJNWEnlHQt7jLT4MrwXsbp+UcF16MSYKJxkrlI6olpOX63i7GE8XoONArVaebH/H53p3ePC3OIX0qsoJMhlZPRNFVyMMhJav49LIKNwhtE9KZfGapV0VWZ4xUNPFqEEwcd8cY1Dw+hWDTnEDrdXU9+ZHULsUgCKk7NYDye3zHxqWtY83Ez4MApM7blp6Wd/uTzB5Sg4ejPxtZ7jv4oI1e0JK+VYSagnwm+ossL6Zi+X3VVwT2oUMISKXXBvKX/OoLEPQMMVBFa66/g7eVcslsr4qogBBn4kbecG5UUoUOmk1tB7BkHqKgFnVPs3jZ6DoD4hoNc3qSU6g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639270724; bh=UyhDXY1pDMTAOahLDUXCfUueM/BkdnUDzjKwrZp58DQ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=e+XI5Cg/Fw5Lu4mRxCtV2ScOXzJFkrd1RZR3ZEclsnSMWOpwNoaWl79OefT9sayjGkxN1yoItkoR4Xj0Tk70MDae0z9Z9kN6RpbS0v1EnYESGdouxcmmn01p2XUId2J0gE9VxfHm0gRt+LCEtCfuyJ4eAuswdqpVKd4xrdg4dhSgJsLQ2L/Nnr1c07zJBmIqcQAzzWQ37CftcTOwsGNIYDeV/7AvfoeoEzR209DOKcex4cycRf46ixk15SZWV7wI3MUamjG1hg+MJgoaMudnDUZI46QiR71wIlAfb8THE08g3ws9RBnswl/ecp0FCDva4xeFBxCbnycM67Hk/s1JWg== X-YMail-OSG: dKqjr.wVM1nvE1xqJJFkVSHnz9PjKtb.LJ8CO_Cu88G0hjGy8qTei16wF6lykgP P1GeXiclQuoz604fESDJWCqs.3Ny2ExdFCPu2MJOVmW9a8OQ8EpVpFrHETfsGqqAXQuRP7PyFXB1 SibmuUZxPXpllENN6QkJVhkP0jRfLY_JbbeegorY3UgbZc3U1rE0mJDtXPiTqMsDbUn_iYnNNZAU wfZGPt1Fr.vaOHMI72PLOxZXajLALEp8b8GVBYrmuIIaT5XT5gfdv7VHLaWIi2x9CEu3r5YgBNBc pda_HaIbPTG.89P2lKRWy.RCvvNiCH6.fNXMsbF_DMUrXGjTkHjCLr6qnvRudJoxnDCaU7ERRxGs fLayT69plKIRn7CGvquSQH7R8xc02n2Yl5a6Bi5DwUVbVJXcnndfB4O1NpXrHU3BpejdWmMiZvni mnA9iNDdGFeMucOF_eSG6SZEwi9CSrrOJfaFdtw6NoWpfQTAJRYpksh_NJrFnz3CmX1I_xFW.dz2 fnAqWzWUH5eFAn8OhY4gjwFCWs3wHhtYUoNMb.9hsE0wi7GD32L0yhVj2YAdZPZ2XiXRomQ6.7KS VjpLqPlkBq0K98_1d8SEnHfuRVAtbh20lPYdf476zvn7kAT9DVuA_SyxERiyOCWw0M4Nb.l9tb4e JANEK3v2A3SYoljkRdbhariz1hQqb_nPM.zp1OVCcHTUNQc0RtdMCtmfM6PRLpzaGHjgIIACmghL FjhwOBJgztiqVn643.KCv3X2VsRooCWkpjDK79ByWF_lJ.RK.RvAqWFYDijUyER8vvCQDxk5N082 a_cR5DBX6gMtg79w5czf4H6u34ouxkm3ORQgZpZGkt X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sun, 12 Dec 2021 00:58:44 +0000 Original-Received: by kubenode504.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 6bc14e5058f907dce74d84b8db9320ec; Sun, 12 Dec 2021 00:58:36 +0000 (UTC) In-Reply-To: <837dcbqmmr.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 11 Dec 2021 15:47:24 +0200") X-Mailer: WebService/1.1.19415 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222157 Archived-At: Eli Zaretskii writes: > Lu, can you help? This has something to do with clipping, because the > overline disappears in this call to x_reset_clip_rectangles at the end > of x_draw_glyph_string: > > > /* Reset clipping. */ > x_reset_clip_rectangles (s->f, s->gc); <<<<<<<<<<<<<<<<<<<<<<<<< > s->num_clips = 0; > > Before that call, I see the overline and underline of the stretch > glyph on the mode line as expected. But I cannot understand what is > missing to avoid this removal of the overline and underline. That's a red herring. The problem is that the box (which is already present on the mode-line face) is drawn after the overline on top of non-character and non-composition glyph strings, such as stretch strings. The correct solution is to move this code: /* Draw relief if not yet drawn. */ if (!relief_drawn_p && s->face->box != FACE_NO_BOX) x_draw_glyph_string_box (s); To run before drawing the overline. I tested and it works here, so if you have no objections I will make that change in xterm and on the other *terms as well. Protesilaos, you should also turn off x-use-underline-position-properties; otherwise, the underline will appear somewhere inside the modeline and not underneath it.