From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Newsgroups: gmane.emacs.bugs Subject: bug#52467: 29.0.50; Use pop-to-buffer for shell Date: Tue, 14 Dec 2021 16:59:09 +0100 Message-ID: <87v8zrch4i.fsf@miha-pc> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29005"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Theodor Thornhill To: sds@gnu.org, 52467@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 14 16:54:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mxA8D-0007Jp-8X for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Dec 2021 16:54:21 +0100 Original-Received: from localhost ([::1]:54328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mxA8B-00058C-Dr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Dec 2021 10:54:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxA7u-00057u-St for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2021 10:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mxA7u-0000Xm-JP for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2021 10:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mxA7u-0006Hb-8c for bug-gnu-emacs@gnu.org; Tue, 14 Dec 2021 10:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Dec 2021 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52467 X-GNU-PR-Package: emacs Original-Received: via spool by 52467-submit@debbugs.gnu.org id=B52467.163949723324136 (code B ref 52467); Tue, 14 Dec 2021 15:54:02 +0000 Original-Received: (at 52467) by debbugs.gnu.org; 14 Dec 2021 15:53:53 +0000 Original-Received: from localhost ([127.0.0.1]:59335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxA7l-0006HE-8q for submit@debbugs.gnu.org; Tue, 14 Dec 2021 10:53:53 -0500 Original-Received: from kamnitnik.top ([209.250.245.214]:47858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxA7i-0006H5-SC for 52467@debbugs.gnu.org; Tue, 14 Dec 2021 10:53:51 -0500 Original-Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43]) by kamnitnik.top (Postfix) with ESMTPSA id D5C079C719; Tue, 14 Dec 2021 15:53:49 +0000 (UTC) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222376 Archived-At: Steingold writes: > Hi > I would like to request reverting of the patch > > 70b64e0d040e9c57f1a489c9ebee553264033119 "Use pop-to-buffer-same-window for shell" > > When I already have a window with shell, this patch creates a second > such window. Maybe you could try customizing display-buffer-alist. To prevent creation of duplicate windows showing the same shell buffer, do (add-to-list 'display-buffer-alist '("\\`\\*shell\\*\\'" display-buffer-reuse-window)) > It seems much more reasonable to use pop-to-buffer in eshell rather than > break shell's behavior. For old behaviour of popping up a new shell window, do (add-to-list 'display-buffer-alist '("\\`\\*shell\\*\\'" (display-buffer-reuse-window display-buffer-pop-up-window))) > If you insist on your desired behavior, please add a user variable > `shell-pop-to-buffer-action` that you would set to > `display-buffer--same-window-action`. display-buffer-alist is flexible enough to customize this behaviour, no need for a new user option in my opinion. Best regards.