From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#53255: highlight-regexp should show faces with their properties applied when selecting a face Date: Sat, 15 Jan 2022 12:36:46 +0100 Message-ID: <87v8ylnsc1.fsf@gmail.com> References: <87y23hl729.fsf@gnus.org> <87zgnxnwkf.fsf@gmail.com> <877db1wboq.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="882"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: ndame , 53255@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 15 12:37:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8hMw-000Aae-4N for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 12:37:14 +0100 Original-Received: from localhost ([::1]:36214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8hMu-0005tM-N8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 06:37:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8hMk-0005tE-0v for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 06:37:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46357) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8hMj-0002tN-No for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 06:37:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8hMj-0005uk-Lt for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 06:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jan 2022 11:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53255 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 53255-submit@debbugs.gnu.org id=B53255.164224661622720 (code B ref 53255); Sat, 15 Jan 2022 11:37:01 +0000 Original-Received: (at 53255) by debbugs.gnu.org; 15 Jan 2022 11:36:56 +0000 Original-Received: from localhost ([127.0.0.1]:39260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8hMe-0005uO-04 for submit@debbugs.gnu.org; Sat, 15 Jan 2022 06:36:56 -0500 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:36626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8hMc-0005u9-7E for 53255@debbugs.gnu.org; Sat, 15 Jan 2022 06:36:55 -0500 Original-Received: by mail-wm1-f48.google.com with SMTP id n19-20020a7bc5d3000000b003466ef16375so12488079wmk.1 for <53255@debbugs.gnu.org>; Sat, 15 Jan 2022 03:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=gQXIMs6n4w11kp77H/kwVfuaF1TxFD9wnv6sij8eAR0=; b=WI/QT8AKjs4PPXKNk71+rKEzR8r/fVYTudlZbh+TX34GtW7a1Akcjv40GZFgQUR/bD w5BktaUrGXgrhw5Tf9eEMhOXNZbWbSpVWNTzsKW8TsCJgYFTHFOwtxHhiUl8h/Oc5+3V WIv0TEGsqX325Q5fTyQwFw6N9G01oCPugml/hnjnDkdrZ/02eDi307BzT44Wd3is0ajQ EB5ttDopZH+ndzJL799zrhaf6U9iW4EoCINVlm7ItPOqZH4vipbqTyR4K0umoVdaNEFA tnad24vOvxOHyKxzviDE/cBrXrqU3QU9A4g8h+fNVRwR0+OLtH3euFe7zBcQwxhOOFOa o70A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=gQXIMs6n4w11kp77H/kwVfuaF1TxFD9wnv6sij8eAR0=; b=BWE69jrwPgl7F6ZNVZRbpaPqGqXahZWTgQe8XX8xvnyOfy9/qzDjhKkaUaNapERXpH Afq31XtcB2XZiuC02Z0k7nKWpw554LCHDR6kzg03A21I7zdQmmgc4Chg0CwzXkszSe86 gE9PGu3mw/IrGjjoCpgAD4IFMpjo3vQWMCwHcDgS235NAA5xSOZ9qLFmxRrvA9lL6HO/ gXppfqRjn9D9xOta6jgmBva69RAOhbDpADUyN7NE8vZV2mOfZqmt4DM1w83iTmu4WSTu RJqSCD24wg2iHnz2iLfjxDV7+HmIAGDbgrXyGEE0QbK6+/UkUFvJAH6LiiCjnCCPfvU4 PKgQ== X-Gm-Message-State: AOAM530bQPiVyFhz9788d0hkee4KtkBwRc/bFJxEb83BJJO32EGhdqSR r16ofc4DVKSwwfWtez/BGksioEY+t7A= X-Google-Smtp-Source: ABdhPJxKJ/AFf2pdzQewJCOB97U8M8ilSvmtaVFn4Dgb7D/KXwFev6pMGaXgy0mbQQYfXDSRbdUvwA== X-Received: by 2002:adf:e751:: with SMTP id c17mr12410808wrn.171.1642246607851; Sat, 15 Jan 2022 03:36:47 -0800 (PST) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id u7sm7561068wmq.39.2022.01.15.03.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jan 2022 03:36:47 -0800 (PST) In-Reply-To: <877db1wboq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 15 Jan 2022 11:11:33 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224290 Archived-At: --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: >> Maybe using an affixation function (like read-char-by-name) would make >> things less jarring? E.g. fontifying the same string for every face >> (say "x" or "example") and using that as suffix (rather than prefix, to >> keep the face names aligned)? > > Hm, yes, that sounds like a good idea. Serving suggestion attached, for discussion purposes; there might be smarter things to do wrt alignment (using :align-to specs? let-binding tab-width?). FWIW it looks pretty good with icomplete-vertical-mode, IMO. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=hi-lock.patch diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el index b70d4a7569..05584b8dc3 100644 --- a/lisp/hi-lock.el +++ b/lisp/hi-lock.el @@ -712,6 +712,13 @@ hi-lock-regexp-okay (error "Regexp cannot match an empty string")) (t regexp))) +(defun hi-lock-decorate-face-names (faces) + (mapcar + (lambda (face) + (list face "" (concat "\t" + (propertize "EXAMPLE" 'face (intern-soft face))))) + faces)) + (defun hi-lock-read-face-name () "Return face for interactive highlighting. When `hi-lock-auto-select-face' is non-nil, just return the next face. @@ -726,6 +733,8 @@ hi-lock-read-face-name (defaults (append hi-lock--unused-faces (cdr (member last-used-face hi-lock-face-defaults)) hi-lock-face-defaults)) + (completion-extra-properties + '(:affixation-function hi-lock-decorate-face-names)) face) (if (and hi-lock-auto-select-face (not current-prefix-arg)) (setq face (or (pop hi-lock--unused-faces) (car defaults))) --=-=-=--