From: Michael Albinus <michael.albinus@gmx.de>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 30725@debbugs.gnu.org, yegortimoshenko@riseup.net
Subject: bug#30725: eshell: built-ins do not handle command substitution
Date: Tue, 18 Jan 2022 09:33:40 +0100 [thread overview]
Message-ID: <87v8yh8mu3.fsf@gmx.de> (raw)
In-Reply-To: <ca55805f-1270-4883-da19-05db4944932e@gmail.com> (Jim Porter's message of "Mon, 17 Jan 2022 11:41:47 -0800")
Jim Porter <jporterbugs@gmail.com> writes:
Hi Jim,
> Attached is a patch that fixes this, plus a unit test (I've verified
> that the test fails without the patch and passes with it). Note that
> the test *does* rely on the system having an external "echo" command,
> but I think some of the tests in that file already rely on the
> presence of an external "sleep" command, so this should be
> ok. However, if it causes issues on some systems (MS Windows maybe?),
> just let me know and I can try to put a guard around the test so it
> doesn't run on such systems.
(skip-unless (executable-find "echo"))
Best regards, Michael.
next prev parent reply other threads:[~2022-01-18 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 4:34 bug#30725: eshell: built-ins do not handle command substitution Yegor Timoshenko
2022-01-17 19:41 ` Jim Porter
2022-01-18 8:33 ` Michael Albinus [this message]
2022-01-18 18:06 ` Jim Porter
2022-01-20 13:38 ` Lars Ingebrigtsen
2022-01-21 3:10 ` Jim Porter
2022-01-21 9:32 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8yh8mu3.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=30725@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=yegortimoshenko@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).