From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#30725: eshell: built-ins do not handle command substitution Date: Fri, 21 Jan 2022 10:32:27 +0100 Message-ID: <87v8ydv3h0.fsf@gnus.org> References: <1fe5dea514d7a42c46ff8e80396ca3b1@riseup.net> <87v8yh8mu3.fsf@gmx.de> <9228db8b-303a-4dd1-12b1-8d6649f57a90@gmail.com> <87v8yezfwc.fsf@gnus.org> <616b5ec8-c872-7fe8-7548-2c7bec9f8cd5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24791"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 30725@debbugs.gnu.org, Michael Albinus , yegortimoshenko@riseup.net To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 21 11:24:05 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAr5Q-00068n-KB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jan 2022 11:24:04 +0100 Original-Received: from localhost ([::1]:56338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAr5P-0003Ql-ML for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jan 2022 05:24:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAqIF-0000Dp-GC for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 04:33:15 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39061) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAqI2-0004ir-Iy for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 04:33:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAqI2-0001gS-Gg for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 04:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jan 2022 09:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30725 X-GNU-PR-Package: emacs Original-Received: via spool by 30725-submit@debbugs.gnu.org id=B30725.16427575606433 (code B ref 30725); Fri, 21 Jan 2022 09:33:02 +0000 Original-Received: (at 30725) by debbugs.gnu.org; 21 Jan 2022 09:32:40 +0000 Original-Received: from localhost ([127.0.0.1]:60195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAqHf-0001fh-TV for submit@debbugs.gnu.org; Fri, 21 Jan 2022 04:32:40 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:60320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAqHe-0001fT-4O for 30725@debbugs.gnu.org; Fri, 21 Jan 2022 04:32:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iE0qmJ4Cp9sa94UD7SHa1tcy+/CH2rXy84b/1vRZuJ8=; b=cAKVYoMYRXL5kwJerEQFoQiCxN us+xN8Wn2U5kJm1lRHzYtUlr8v+SMCtqvxxXx7xONsOCsJmlznYgYRl0zoXzXxDxJomYOE+mLNgAQ fCUxSb6f/v4cLaKIPhrOuvFv/a9kxEA0U8HYaEMqcvQLaqwhWjs1OjLAOgNuPqNukxOc=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAqHU-0008Je-Cl; Fri, 21 Jan 2022 10:32:30 +0100 X-Now-Playing: Brian Auger & Julie Driscoll's _Open_: "Goodbye Jungle Telegraph" In-Reply-To: <616b5ec8-c872-7fe8-7548-2c7bec9f8cd5@gmail.com> (Jim Porter's message of "Thu, 20 Jan 2022 19:10:31 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224738 Archived-At: Jim Porter writes: > This new patch should be considerably more robust, since it searches > recursively for any `(eshell-as-subcommand FOO)' forms to check > them. That way we don't require the command form to look *exactly* one > way. I used a generator for this, since that's the clearest to my > eyes, but I'm open to other implementations. Looks fine to me. Pushed to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no