From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#53897: 28.0.91; regression: rcirc overwrites completion-cycle-threshold Date: Wed, 09 Feb 2022 12:54:57 +0000 Message-ID: <87v8xo2o9q.fsf@posteo.net> References: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8305"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53897@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 09 14:26:43 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHmza-0001wm-FW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Feb 2022 14:26:42 +0100 Original-Received: from localhost ([::1]:39718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHmzZ-0005Nb-8m for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Feb 2022 08:26:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHmW7-00057I-56 for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 07:56:16 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56229) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHmVu-0002X4-0E for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 07:56:14 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHmVt-0006K0-WF for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 07:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Feb 2022 12:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53897 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.164441131124230 (code B ref -1); Wed, 09 Feb 2022 12:56:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Feb 2022 12:55:11 +0000 Original-Received: from localhost ([127.0.0.1]:50126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHmV4-0006Ij-Gi for submit@debbugs.gnu.org; Wed, 09 Feb 2022 07:55:10 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:47564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHmV3-0006IZ-1e for submit@debbugs.gnu.org; Wed, 09 Feb 2022 07:55:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHmUy-0004p7-VY for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 07:55:08 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:46887) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHmUw-0002Q3-4S for bug-gnu-emacs@gnu.org; Wed, 09 Feb 2022 07:55:04 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id F0577240104 for ; Wed, 9 Feb 2022 13:54:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1644411300; bh=R+8rHRTSd8vYK335kF/Hw+Y/S+qDhCgbk94Cmf+Hh0s=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=mY5ZUWSdNyl15v98QC1ugZoEDe2vUNYHQ2waw36E6FwjoNH4xLDcd/IoJEcCEl0To dG9Jra0PAfl7QimMaxnXQ86If9iOLJh3AJB1MDwGJVl5nIteIdVg/PD4lR8/qgzAKo 9AzeCWHS++Q4ZGLIzkH19d8zrBXS7P+HIqlzFrorB4Pc37XPLlQx1jRsnMbFjK50Mj JTIlQwYtA7jcrjFfslgUL26dr1pbSCsIgMn+ILC8vpm2zwnu8vievFlwpiox+5OVr4 yaPAJP5KbCnCkzmgoo3dHvI6Eho3e0TamzJ3mfcUh8md46iuD5KQj1OI3KHD4zQUMw 27mEQNs4Qb7GQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Jv0GB70Z7z6tpc; Wed, 9 Feb 2022 13:54:58 +0100 (CET) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> (Daniel Mendler's message of "Wed, 9 Feb 2022 12:10:09 +0100") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226478 Archived-At: Daniel Mendler writes: > rcirc-mode started to set `completion-cycle-threshold' to t. This > setting is intrusive and interferes with user completion setups. It is > better left to the user to tweak this setting in their user > configuration, since users may want to configure completions coherently > across the different modes in Emacs. Note that rcirc.el is the only > file/mode which sets `completion-cycle-threshold'. Therefore it is > better to revert the change which added this setting. The change that introduced this was that the custom cycling implementation was replaced with one based on completion-at-point (0b367ec), mainly to simplify the code. The reason `completion-cycle-threshold' is set is to preserve the appearance of the previous behaviour, as a complete reversion to completion-at-point seemed like too much of a change. I could imagine introducing a user option to decide what you want to use. My inclination would be to set it to "cycle by default", but it doesn't need that way. Perhaps we could test non-cycling (regular capf) for a while, and see if there are any complaints or other feedback? > In GNU Emacs 28.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, > cairo version 1.16.0) > of 2022-02-09 built on projects > Repository revision: 82e74e4559b8becd44f3e7ac0134e2baddd69921 > Repository branch: emacs-28 > Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 > System Description: Debian GNU/Linux 10 (buster) -- Philip Kaludercic