From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#53897: 28.0.91; regression: rcirc overwrites completion-cycle-threshold Date: Mon, 14 Feb 2022 18:33:56 +0000 Message-ID: <87v8xhb8mj.fsf@posteo.net> References: <2dd2216d-9ca0-c242-9681-985584e20dd3@daniel-mendler.de> <87v8xo2o9q.fsf@posteo.net> <87bkz9co1d.fsf@posteo.net> <5525a90a-4613-cf73-a120-19862977d2d2@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34775"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53897@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 14 20:02:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJgcE-0008s5-LH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Feb 2022 20:02:26 +0100 Original-Received: from localhost ([::1]:60792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJgcD-0002Pw-JN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Feb 2022 14:02:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJgBk-0002Pq-S6 for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2022 13:35:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJgBj-0002oL-3y for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2022 13:35:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nJgBi-0002ae-28 for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2022 13:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Feb 2022 18:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53897 X-GNU-PR-Package: emacs Original-Received: via spool by 53897-submit@debbugs.gnu.org id=B53897.16448636479876 (code B ref 53897); Mon, 14 Feb 2022 18:35:02 +0000 Original-Received: (at 53897) by debbugs.gnu.org; 14 Feb 2022 18:34:07 +0000 Original-Received: from localhost ([127.0.0.1]:42526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJgAo-0002ZE-O1 for submit@debbugs.gnu.org; Mon, 14 Feb 2022 13:34:06 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:55863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJgAm-0002Yi-Kk for 53897@debbugs.gnu.org; Mon, 14 Feb 2022 13:34:05 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 82C6B240028 for <53897@debbugs.gnu.org>; Mon, 14 Feb 2022 19:33:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1644863637; bh=NF9jYUtgSQ8rSoGOJsGcXZcyvnhnuSb1Xu5218cCr6M=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=EZqHjlohJ+3+KjR9ybITVTMO0rOrAV4b+DU/QxZm0qA+BPZR2+sKIjpycemjor7Hv 23hfVwYwAt1xEH6YGKAFCz7WoINgocON6Qbfh2/SPPcvAA2p7anY6bD4YfxBWmpbMO j9V0arXvxuNbQTc/WYPUM90s7mGkIgdopBZyLmONw2kdjUX1wBoxDDrYAwGS/eg2m2 +kqZV4sEJeJnbuFZzZYWmFWxWEW5JFgskT8TdQkLM3BHNrlbFRIKbK7F3nAO7wCKxE jdISEjAABjPpwQIsEWr8K6tZCTw5QribJ06CENx238l0N7Iroe2b7/2WzE8Dq5fFz2 oJdiFpdL4pseg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JyCY06qR7z6tpX; Mon, 14 Feb 2022 19:33:56 +0100 (CET) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <5525a90a-4613-cf73-a120-19862977d2d2@daniel-mendler.de> (Daniel Mendler's message of "Mon, 14 Feb 2022 19:18:53 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226914 Archived-At: Daniel Mendler writes: >>>> I could imagine introducing a user option to decide what you want to >>>> use. My inclination would be to set it to "cycle by default", but it >>>> doesn't need that way. Perhaps we could test non-cycling (regular capf) >>>> for a while, and see if there are any complaints or other feedback? >>> >>> Yes, I would go with normal Capf behavior, which is the usual behavior >>> across all of Emacs. If a user wants to restore rcirc-complete, it seems >>> easy enough to add this to a user configuration? >>> >>> (defun rcirc-complete () >>> (interactive) >>> (let ((completion-cycle-threshold t)) >>> (completion-at-point))) >> >> Or, this could be added as rcirc-complete, binding TAB back to this new >> command and documenting that if you want to complete using the default >> CAPF, you should rebind it to completion-at-point? > > That's an option too. But then you will still keep the old cruft around. > I would rather break backward compatibility here and document that > binding `completion-cycle-threshold=t` will restore the old behavior. > Most users will appreciate that a Capf is directly available, which is > more capable than `rcirc-complete`! I honestly don't know. I understand both sides, but cannot decide. One also has to consider the current stage of Emacs 28 development, and that these kinds of changes aren't appreciated right now. That means disabling completion-cycle-threshold would have to be installed in 29.1. -- Philip Kaludercic