From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#54487: 29.0.50; connection-local value for `shell-file-name' not set in Dired buffers over Tramp Date: Mon, 21 Mar 2022 15:06:28 +0100 Message-ID: <87v8w7pfh7.fsf@gmx.de> References: <87y213bo13.fsf@gmx.de> <83wngneawo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38414"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: jporterbugs@gmail.com, 54487@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 21 15:07:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWIh0-0009r4-I6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Mar 2022 15:07:30 +0100 Original-Received: from localhost ([::1]:55360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWIgz-0004bg-6K for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Mar 2022 10:07:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWIga-0004aO-3b for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2022 10:07:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWIgY-0001GR-IM for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2022 10:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nWIgY-0004Ge-7M for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2022 10:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2022 14:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54487 X-GNU-PR-Package: emacs Original-Received: via spool by 54487-submit@debbugs.gnu.org id=B54487.164787160016369 (code B ref 54487); Mon, 21 Mar 2022 14:07:02 +0000 Original-Received: (at 54487) by debbugs.gnu.org; 21 Mar 2022 14:06:40 +0000 Original-Received: from localhost ([127.0.0.1]:37725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWIgC-0004Fx-8H for submit@debbugs.gnu.org; Mon, 21 Mar 2022 10:06:40 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:50799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWIgA-0004Fj-CJ for 54487@debbugs.gnu.org; Mon, 21 Mar 2022 10:06:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1647871591; bh=+Kp6LSr2QksTe862L0pez+bXMeJN4N6I0S3zZKHpkco=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=XcciRACJ+KdeK9+7n4ExH+vTmYJPdxjsIa5srcBoNUOv/uHm+kulBGQWefdNtZuaG r2ADEu4WhtIHrmfdlR83md1esSHskgcv/I7HqsxH2UY+tWpxRPjGLGzOrHmBn6b6Sw CaZ/hWfgFarApSuqhmgR0LM0mI0UpcAGhx+4OZOI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.118.124]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MjS9I-1nux6y40BW-00kwNb; Mon, 21 Mar 2022 15:06:31 +0100 In-Reply-To: <83wngneawo.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 21 Mar 2022 14:40:39 +0200") X-Provags-ID: V03:K1:RCaMSbXlLMuoAPiyPYEg08x07k23QS2erHgmvvhMrFh33HZa0yC 2jB+Hf6S6DEdgRPYs9mGj1t/PQmjI3xHfDEDush0srng1YuIuP8X1rWm1ubu3K7A16kncx1 SKOVkUTjg9DG7GX9XAB3RaasX1kPkuxxuaiXIzcasJZvJNUXa9b2z7laZdA/b0wrSqTb+7+ jVuF+XYorRDvrqT5/AZAQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:9k3Nym4aVhQ=:dpyzgiUO6XIkJXWZZtPnvy pUPrCrWoUn+sG2+oKWDy/I0aj1GPvCif0EMvGmjiHywp3jbsgiY6bObnoGtJpUiXD71a6vxN3 asClovUtwSQ1epgmZaOMVrKWKDF9gXQoT1FK7KQo5AjgzR5fTXi5uiqAambSyJcg0y7+pFfdi JaeuzvDHwP45e+mDhqMDB9nwzSogeXfM+wVtRCBWqutP9qqwHFcfn9JlLjejZmsF6wi9yjA+y xfSHOC1a5zYeV4T2oqalOiDQLW1bZUzaOaEmoVHlaN4Kw+dLAnqVcZjD5uRx9qX8SU2AjtVdo 07Z79YAnygG8dA/iIiod8bphMg1DlovMVWYRDebmcVloFUHlolYZ6WsXny3dq5FjtIZDJ/RRF UKKkJPBJoTZtixROs8Js41yLvnCLEba58tdsIEhF8OWAwBrqn49/Fd+CixbEa5u7AMkyKNj8R FBFctEKGowV5yZg9UpTT+DNfcvud9CevUiMwZatEQ8c5Z56V/HPVmlLYP3s7cxbxmXzdu0IB/ Hq1i8wfQxRpiFGVgoplWU99n0qVdhTYDYfner4fZoDof6vQ1TZVDQ18waCGn5cmRfzKePZ+Hu POarWhC79P9wwcq1vs6qTtnreYDwgChWIvoMYKxW7XbRFQR6IWqjLMSHN9jiVPEg/1WzHLAdQ 3Awb3lUww8cV2i3uA5hPIcF9ZFeHM3xBEsbWizu4yNkyLaYN6cm+o2zR888I8Xpjod4DOCwGg glgetytBRSsyzIol76YLvc9dPckP8Je80L5GqHCc0mf0wzCNa62D4fb1wHsgSq4Uhs3QRe7+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228670 Archived-At: Eli Zaretskii writes: Hi Eli, > Is it really a good idea to solve this only for Grep? Shouldn't shell > quoting always use this logic (with some variable that callers could > bind in exceptional cases, which I presume will be rare)? Or am I > missing something? I had the same feeling after sending the patch, so I've started to rework this. I came out with the following solution: --8<---------------cut here---------------start------------->8--- shell-quote-argument is a compiled Lisp function in =E2=80=98../../../src/emacs/lisp/subr.el=E2=80=99. (shell-quote-argument ARGUMENT &optional POSIX) Quote ARGUMENT for passing as argument to an inferior shell. This function is designed to work with the syntax of your system=E2=80=99s standard shell, and might produce incorrect results with unusual shells. See Info node =E2=80=98(elisp)Security Considerations=E2=80=99. If the optional POSIX argument is non-nil, ARGUMENT is quoted according to POSIX rules. --8<---------------cut here---------------end--------------->8--- I'll wait until Jim confirms that this works in general, then I would apply a patch along this spec. Best regards, Michael.