From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#54603: 29.0.50; [PATCH] Eshell's external pipe module interferes with other argument parsing hooks Date: Thu, 31 Mar 2022 15:55:56 -0700 Message-ID: <87v8vtbukj.fsf@athena.silentflame.com> References: <70677cd2-f741-16d1-b38f-c39b507cc95e@gmail.com> <87ilru73b2.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40151"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 54603@debbugs.gnu.org, John Wiegley To: Lars Ingebrigtsen , Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 01 00:57:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1na3jI-000AEJ-UV for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Apr 2022 00:57:26 +0200 Original-Received: from localhost ([::1]:40946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1na3jH-0002rX-HO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Mar 2022 18:57:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1na3iz-0002qR-BG for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 18:57:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46219) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1na3iv-0000BL-OJ for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 18:57:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1na3iv-0004TN-KX for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 18:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Mar 2022 22:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54603-submit@debbugs.gnu.org id=B54603.164876736617117 (code B ref 54603); Thu, 31 Mar 2022 22:57:01 +0000 Original-Received: (at 54603) by debbugs.gnu.org; 31 Mar 2022 22:56:06 +0000 Original-Received: from localhost ([127.0.0.1]:40116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1na3i1-0004S1-Oa for submit@debbugs.gnu.org; Thu, 31 Mar 2022 18:56:05 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:38309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1na3hz-0004RY-Or for 54603@debbugs.gnu.org; Thu, 31 Mar 2022 18:56:04 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9386E5C01EF; Thu, 31 Mar 2022 18:55:58 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 31 Mar 2022 18:55:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; bh=5IqSrhPyYf9RYF5XzskChIAr8ajlhY HIlSaSJwDSIGk=; b=VC94Ve95FKNaVwt534aWb8aHL5iXQmDY6xXbdD/eJjOrbq CVW/L3pfIy2loAsFRyqW/VaLrLNgaugHEq1yb1bYtPubCppNOMGt+nv+HXJ55PwH GKMPR8+L2yFeDmhbErD5Deha18+gPaSVnf8dJL+6Vx8/IVkLAhf91ZvC1/3TVXmB H8TW8Bo6mlcnSelS0GqDjQN2E5pldSP9Ny2Adq24Zj2zxRoNVN3NouSPZIofBHoF DSHQm503pp+EHBV/Sc2q/tImgXphPc7D+65mpReShKUd3P+VAnI/f916tjgBVKIW A7cxrRI52GkfkRJoTEZpinRQmy+0vfaEhVhgU3Dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=5IqSrhPyYf9RYF5Xz skChIAr8ajlhYHIlSaSJwDSIGk=; b=dDsnV9bNP9tpFTU8om+n9z6BMglKgvWqy RZU+LEm3Bi5wMIPSlKCO9VuaYe75Mz8z5nBCp20avIldjONCUPBUYknO3i6P7qVB 01jv6B3lPH6cIiXmvPxC4yDSpe0LThqlsWyHd8YWkOJKnyxBeeQpu1Xveo+T0APS evMh6ivI7jhDQqukzV0902vPIOwHU71WKgigT34E07a9coCClwqSubh0RgGfO/Rh CLlGc8Sau3/r3fafk1TBcEKt4a1Rq57JuKDAlGqCgZ9TzWOKeHzjc8XBORaUcJ+B +pMq2FU2W4ddwBFR4+48PXByaIrhfsp90YLWiOHipOP2xM46papcw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeihedgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepleeggefgvdeijedvhfdugfegtefgkeekueeileejjeehudeg geefteeghfeuffeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Mar 2022 18:55:57 -0400 (EDT) Original-Received: by athena.silentflame.com (Postfix, from userid 1000) id D2F421C9F3F; Thu, 31 Mar 2022 22:55:56 +0000 (UTC) In-Reply-To: <87ilru73b2.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229190 Archived-At: Hello, On Thu 31 Mar 2022 at 01:46pm +02, Lars Ingebrigtsen wrote: > Jim Porter writes: > >> The attached patch resolves the issue for me, but I'm not sure if it's >> the best strategy. If possible, I think it would be better for >> `eshell-parse-external-pipeline' to solely focus on finding the >> external pipe operators ("*|", "*<", and "*>")[1] and then for >> `eshell-rewrite-external-pipeline' to prepare the command string to >> pass to sh. This would also have the advantage[2] of making it >> possible to support a richer set of Eshell features with external >> pipes, such as the following: > > I think that sounds like a good idea (but I don't use eshell regularly, > so I don't really have much of an opinion here). Perhaps John does; > added to the CCs. As discussed down thread, this would kind of be a different feature -- one purpose of the extpipe syntax is to make it easy to have the operating system shell interpret complex shell syntax rather than Eshell. Jim has an idea about making ordinary Eshell pipes automatically use the external shell where possible, which would satisfy this usecase better if it works out, I think. -- Sean Whitton