From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Nacho Barrientos Newsgroups: gmane.emacs.bugs Subject: bug#54989: 28.1; url-http.el: chunked response: wait for the last CRLF Date: Mon, 18 Apr 2022 11:13:23 +0200 Message-ID: <87v8v6sqas.fsf@cern.ch> References: <87zgkkuo4i.fsf@cern.ch> <87fsmcas9r.fsf@gnus.org> <87k0boq6oo.fsf@cern.ch> <87y2049bs4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5487"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.10; emacs 28.1 Cc: 54989@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 18 16:21:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngSFn-0001HF-4p for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Apr 2022 16:21:23 +0200 Original-Received: from localhost ([::1]:48588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngSFm-0002gq-42 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Apr 2022 10:21:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngSFS-0002ZT-Gw for bug-gnu-emacs@gnu.org; Mon, 18 Apr 2022 10:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46493) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ngSFS-0003do-7S for bug-gnu-emacs@gnu.org; Mon, 18 Apr 2022 10:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ngSFS-0000JG-4f for bug-gnu-emacs@gnu.org; Mon, 18 Apr 2022 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nacho Barrientos Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Apr 2022 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54989 X-GNU-PR-Package: emacs Original-Received: via spool by 54989-submit@debbugs.gnu.org id=B54989.16502916191093 (code B ref 54989); Mon, 18 Apr 2022 14:21:02 +0000 Original-Received: (at 54989) by debbugs.gnu.org; 18 Apr 2022 14:20:19 +0000 Original-Received: from localhost ([127.0.0.1]:40384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngSEk-0000HX-CR for submit@debbugs.gnu.org; Mon, 18 Apr 2022 10:20:19 -0400 Original-Received: from mail-eopbgr50067.outbound.protection.outlook.com ([40.107.5.67]:32258 helo=EUR03-VE1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngNWg-0005fH-Jn for 54989@debbugs.gnu.org; Mon, 18 Apr 2022 05:18:31 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WlGAgQrM/Xl+djqLdbD4IITyjh0DGkRCM8RycAtigWxUf/eoJpEOrfVHKamePhVzK7mIVUI5CR/PtkUQSDbzwPFJIhSkPyFXrm6pwOYX7KONCw5h+wz9xPonozKdoGLN4eDWGLt3oU0tPAHJZ3dG33vKtExoffmClWX2QTADu2d7GlpbqfA39qw8yW8oDaEPnQD+An8Rwyy3r/idLH//MiBCpA+fTNn+kNJdYn8KdnZBLqAxwH5QVsl50rbpdQ++Em5LrfeJRVBq1c0vCijcBDoBrpsvUfr80sIP2ZTQaLnqljf8WfXDalxbzr5LnKMTSircvqueJLB0Nu9QkSt+hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H0g9nNoBPNq89m1CiKWG2TvhnQlTNYi53sig0X0JgOQ=; b=NOFHyGYLumZkZIfZS1IgHBy/vJqYTjmNYIt4M6gkUl+YZBewSGMvJuc06fxLt3+RjqH5nul5UAdaD8geoL54EzSgYbgNRjAR7j6DYIlLI5tkN4AIzKmeBFvfo1E9HYsZAo8VW+rNuoCa+mkPrV/8gwC2z88KdQ/Xrxyo2YcUN5VmxVXhKGEtWSwGsz6g/OHSvhBMKINPJLvwNvh2qo3RManGuTbX5Yvv0TSHa2Zzucf014sComhEGwhT+3FpW7hF52gojo3nR0WiAGMZrTmRCcomUoo9Qpq28x6z4i9V9eUxEWxZdWwvNz88hqExFzM9OQ3kc0+03+0LJvjHD18BEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 188.184.36.17) smtp.rcpttodomain=gnus.org smtp.mailfrom=cern.ch; dmarc=bestguesspass action=none header.from=cern.ch; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cern.onmicrosoft.com; s=selector2-cern-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H0g9nNoBPNq89m1CiKWG2TvhnQlTNYi53sig0X0JgOQ=; b=gzTylBviI1JadAbMBgQV142CDWY/FJ47+QMMndvSAfLF9vt6cFp8nCs9+wmHCKTK85q82CYtlcA0ECcU2X7bGbx3vters+k2EUJkKqqh0LwfxBtGKKbOl/CRfPRRIYfJAqBxxb5HvzPaovASDemXbhNSfn4My5YJIHN8UcUsta8= Original-Received: from AS9PR06CA0312.eurprd06.prod.outlook.com (2603:10a6:20b:45b::21) by PAXPR06MB7566.eurprd06.prod.outlook.com (2603:10a6:102:152::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr 2022 09:18:23 +0000 Original-Received: from AM5EUR02FT012.eop-EUR02.prod.protection.outlook.com (2603:10a6:20b:45b:cafe::db) by AS9PR06CA0312.outlook.office365.com (2603:10a6:20b:45b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend Transport; Mon, 18 Apr 2022 09:18:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 188.184.36.17) smtp.mailfrom=cern.ch; dkim=none (message not signed) header.d=none;dmarc=bestguesspass action=none header.from=cern.ch; Received-SPF: Pass (protection.outlook.com: domain of cern.ch designates 188.184.36.17 as permitted sender) receiver=protection.outlook.com; client-ip=188.184.36.17; helo=cernmx.cern.ch; Original-Received: from cernmx.cern.ch (188.184.36.17) by AM5EUR02FT012.mail.protection.outlook.com (10.152.8.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5164.19 via Frontend Transport; Mon, 18 Apr 2022 09:18:22 +0000 Original-Received: from postfix-mta-10.cern.ch (2001:1458:d00:3c::100:2d4) by cernmx.cern.ch (2001:1458:201:65::100:18) with Microsoft SMTP Server id 14.3.498.0; Mon, 18 Apr 2022 11:18:22 +0200 Original-Received: from outstanding (unknown [85.195.208.5]) by postfix-mta-10.cern.ch (Postfix) with ESMTPSA id 0250D340002; Mon, 18 Apr 2022 11:18:22 +0200 (CEST) In-Reply-To: <87y2049bs4.fsf@gnus.org> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6a30781-1f1e-4c7c-9339-08da211c62e0 X-MS-TrafficTypeDiagnostic: PAXPR06MB7566:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i2lRH2jl36zBBlp8nr6S+0wu4tVtm/hmA6nh7t03y659XH2zLlAC0MbHedY6AoJ3waGQEJekOC8DVxDndvl75YxaXx+ERc5Yzj/GAWDLEj5ttXpvW1IZAmV+y5rOSrI/RVlTQL5sCF8pwUvCoOouMld7lH3leE4ynIZRKTCAexw06tpPAP5gkPZu1ACGtT4uyvWxfZfWR0HitLZSJXFeVFTV0k034ZOQ/FnarZA+AJC5j75iY1c4r41H/9t83IsOP56jyXYgV9uTsDV+F42EBQk5SoOWGOINbUJud5pmGVgE58FBJvbyEQe13FreV/7ys4J0B/8J/PT5vjfZHVPC5XecAaF+5sGIMGOGIlanbzlHGqQimoQuQoq15TwrX5pxRBX5C4gfUhB2PjL9O99BTwmMUZpPogccqv6VdJx2A9vJwSAhavTLl7tNorzMkjqMPkcYrFiGEqiFgcaOezj+NbTeZoUKE5vRHb/3DpxIQizxlseppGCx448E1XnCOBYRjpZELLxeynDhW0YBDPYSIk8I4OU8XRBI8voiSbaHPsguPLNRP0CM4Ns2BfPDzwfOzxJ15XQTFs8hCAZKpLq+BJZRhsmi7VKZxBzQnY0zPgcLA6B1lOIbZzSb557OYNqAU4olU6zVM7/4rLpWS4FFCmgPVtQ8Jyk1jBR77tIU7TgUhQmW85MiUFPRLk9kXcCWYu3NeCOZNjK8LoVGnUXEnd+U2+rkxBt1EHxB8bU8hLfoOdXUpYdhRHujVjX3A jUcHdW5HDbMnIi4f522m53c5LvznHMsy1jwWU/K3/3Jsno= X-Forefront-Antispam-Report: CIP:188.184.36.17; CTRY:CH; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:cernmx.cern.ch; PTR:cernmx15.cern.ch; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(70206006)(966005)(6266002)(8676002)(53546011)(36756003)(4326008)(82310400005)(6966003)(70586007)(40460700003)(356005)(316002)(2906002)(26005)(83380400001)(36860700001)(86362001)(5660300002)(786003)(8936002)(2616005)(7636003)(508600001)(47076005)(34020700004)(186003)(336012)(426003)(44832011)(6916009)(956004); DIR:OUT; SFP:1101; X-OriginatorOrg: cern.ch X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 09:18:22.5688 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f6a30781-1f1e-4c7c-9339-08da211c62e0 X-MS-Exchange-CrossTenant-Id: c80d3499-4a40-4a8c-986e-abce017d6b19 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c80d3499-4a40-4a8c-986e-abce017d6b19; Ip=[188.184.36.17]; Helo=[cernmx.cern.ch] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR02FT012.eop-EUR02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR06MB7566 X-Mailman-Approved-At: Mon, 18 Apr 2022 10:20:17 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230185 Archived-At: --=-=-= Content-Type: text/plain Hi Lars, Lars Ingebrigtsen writes: > Oops. I'll send a query about what's up. Thanks in advance for any help you can provide. Any news you might have please feel free to send me an e-mail. BTW, here's a patch for your consideration. It's related to the diff I initially sent, that's why I'm bothering you again over here. Nothing big, just some cosmetics. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename="0001-Unify-local-variable-initialisation.patch" >From 5c1c53a0969b07d1487a9751b8849a1818680cb7 Mon Sep 17 00:00:00 2001 From: Nacho Barrientos Date: Mon, 18 Apr 2022 11:04:55 +0200 Subject: [PATCH] Unify local variable initialisation Treat url-http-chunked-last-crlf-missing as any other buffer variable by declaring and initialising it the same way as the other related ones. --- lisp/url/url-http.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el index 7f55866eec..b950a8994f 100644 --- a/lisp/url/url-http.el +++ b/lisp/url/url-http.el @@ -36,7 +36,7 @@ (defvar url-current-object) (defvar url-http-after-change-function) (defvar url-http-chunked-counter) -(defvar url-http-chunked-last-crlf-missing nil) +(defvar url-http-chunked-last-crlf-missing) (defvar url-http-chunked-length) (defvar url-http-chunked-start) (defvar url-http-connection-opened) @@ -1163,7 +1163,7 @@ the end of the document." (progn (url-http-debug "Spinning for the terminator of last chunk...") - (setq-local url-http-chunked-last-crlf-missing + (setq url-http-chunked-last-crlf-missing (point))) (url-http-debug "Removing terminator of last chunk") (delete-region (match-beginning 0) (match-end 0)) @@ -1354,6 +1354,7 @@ The return value of this function is the retrieval buffer." url-http-after-change-function url-http-response-version url-http-response-status + url-http-chunked-last-crlf-missing url-http-chunked-length url-http-chunked-counter url-http-chunked-start @@ -1378,6 +1379,7 @@ The return value of this function is the retrieval buffer." url-http-noninteractive url-request-noninteractive url-http-data url-request-data url-http-process connection + url-http-chunked-last-crlf-missing nil url-http-chunked-length nil url-http-chunked-start nil url-http-chunked-counter 0 -- 2.35.3 --=-=-= Content-Type: text/plain Thanks again, -- bye Nacho http://cern.ch/nacho --=-=-=--