From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45999: 28.0.50; repeat does not work when saving files modified outside emacs Date: Tue, 07 Jun 2022 16:29:52 +0200 Message-ID: <87v8tcfswv.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28657"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 45999@debbugs.gnu.org To: Gabriel do Nascimento Ribeiro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 07 16:31:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyaEk-00079D-9r for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jun 2022 16:31:14 +0200 Original-Received: from localhost ([::1]:43128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyaEi-00028r-V8 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jun 2022 10:31:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyaEZ-00025l-0T for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 10:31:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyaEY-0003lx-N0 for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 10:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nyaEY-0006S1-IO for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 10:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jun 2022 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45999 X-GNU-PR-Package: emacs Original-Received: via spool by 45999-submit@debbugs.gnu.org id=B45999.165461220621021 (code B ref 45999); Tue, 07 Jun 2022 14:31:02 +0000 Original-Received: (at 45999) by debbugs.gnu.org; 7 Jun 2022 14:30:06 +0000 Original-Received: from localhost ([127.0.0.1]:41078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyaDd-0005SY-Av for submit@debbugs.gnu.org; Tue, 07 Jun 2022 10:30:05 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyaDb-0005P5-Fx for 45999@debbugs.gnu.org; Tue, 07 Jun 2022 10:30:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wyCi0ErnLBpi+r9GoitC+rNcnxImuP03UNwZraIkcuA=; b=ou0bnhmYjGcuBd4cy+xB4wKyW0 ExqtiCXX08r8wUfVVxBGobVfSFKbvXSKN7VPFhDjYidhBVehYYrU8Sr+klZkhgp3Vq/P8ghe27WGX ZWUpyEGOEOgS1nJE+9PROJWK1m50i4Cf74oRtXkhlEvVspV4R9iCwju00TrB36ogFso8=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyaDS-0003lo-Il; Tue, 07 Jun 2022 16:29:56 +0200 X-Now-Playing: The Wake's _Harmony & Singles_: "The Old Men" In-Reply-To: (Gabriel do Nascimento Ribeiro's message of "Tue, 19 Jan 2021 21:45:10 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233897 Archived-At: Gabriel do Nascimento Ribeiro writes: > 2) Problematic case: > 2.1) Run 'emacs -q' > 2.2) Open a file with 'C-x C-f' > 2.3) Make some modification without saving the buffer > 2.4) Edit the same file outside emacs (with another text editor or with > shell command 'touch') > 2.5) Save the buffer with 'C-x C-s'. You will see the message > ' has changed since visited or saved. Save anyway ?'. Type > 'yes' > 2.6) Repeat last last command with 'C-x z'. You will see the message > 'Repeating (find-file t)' indicating that the last command before > 'save-buffer' was repeated, which in this case was 'find-file' command > with 'C-x C-f'. It's possible to test with some other command before saving > the buffer to see what happens with the '(repeat)' command. I can't reproduce this exactly -- in Emacs 29, `C-x z' executes `exit-minibuffer', since that's the value of `last-repeatable-command' after typing "yes". (Most likely due to yes-or-no-p being reimplemented as non-modal.) I'm not at all familiar with how `last-repeatable-command' is supposed to work -- it's just set from command_loop_1, and there's no blocklist of commands or anything, so it seems like any commands that prompts with yes-or-no-p/completing-read/etc aren't repeatable (now). (defun foo () (interactive) (yes-or-no-p "Foo") (message "%s" last-repeatable-command)) and examine last-repeatable-command I guess a way to fix this would be to introduce a blocklist (containing minibuffer-exit/self-insert-command/etc/etc), but I'm not sure how much etc this would be. Or perhaps there's a different way around this. Any opinions? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no