From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56487: xgselect race condition leading to abort when USE_GTK not defined Date: Mon, 11 Jul 2022 11:13:04 +0800 Message-ID: <87v8s4z6in.fsf@yahoo.com> References: <871qus1kkt.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25976"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 56487@debbugs.gnu.org To: Tom Gillespie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 11 05:14:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAjsB-0006fW-IY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jul 2022 05:14:11 +0200 Original-Received: from localhost ([::1]:33944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAjsA-0000XE-3U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jul 2022 23:14:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAjs4-0000Wt-0M for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 23:14:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44200) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAjs1-0001JY-WF for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 23:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oAjs1-0006oT-PW for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 23:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2022 03:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56487 X-GNU-PR-Package: emacs Original-Received: via spool by 56487-submit@debbugs.gnu.org id=B56487.165750920426130 (code B ref 56487); Mon, 11 Jul 2022 03:14:01 +0000 Original-Received: (at 56487) by debbugs.gnu.org; 11 Jul 2022 03:13:24 +0000 Original-Received: from localhost ([127.0.0.1]:38097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAjrQ-0006nO-4N for submit@debbugs.gnu.org; Sun, 10 Jul 2022 23:13:24 -0400 Original-Received: from sonic304-20.consmr.mail.ne1.yahoo.com ([66.163.191.146]:44781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAjrN-0006n9-Ps for 56487@debbugs.gnu.org; Sun, 10 Jul 2022 23:13:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657509195; bh=DFexJaCi9aOJVXP9J3BmcOsGw8jOAa+CnQg0g5+Smis=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=CHT7L8S5BpkWC+3Jwk5XH5yuMWmEFMs4LkSDUBqX3ZSovDcScc3KbtzRRDNw2k6gq/bfFjr/Pq2PquhheK+jQw2qba5wC4kqAdVruhQ6XxMYYghcmjFiW/aLDZ7Xp4P5leSvMzqskalf3K2NdYQLYHcqrJ097xk5RbRxpT65+NW8OuqaajRsv4hs0VS9EnBlxwASLcS0JUpfmD6ZeBig0zyv9QMTAcTwnQNgjDSnGmkxvfYsRv7qNN41A9irm3/V0IPJ9zHHkdsx3h+vMUD+DXw9/79WXjxb97QsLcK0ssqvd60IjXV4iurZzi/2U3+PNCP0/zwaV2VOmbG8P4HzMA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657509195; bh=14U6JrkWOhC/YzRtytpm8msAj8XHw5dkVAjSJEGd72o=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ZQ3FEXfMGYvoO9Hl3idgVznbK4eWE5gwOr1+gtFgHoh617c/zsESruqCL/VBU5LJUAypnhWfHu3y6lM0YoK2B6lV7iaOu8UVdNJhZ8It7RyhqvJmzJNWayTvBJlf1yU1Jw3KnenvYARaAQpBDKCauRA8olqeFiJWZctGBW3355jovt1wZyhS/ExzDwDyuqPHwdWxq0ilW3E8YS7FTJqTmNKtKNM/IXsK5nhAVjoitxVqLDesbxKJgwrWvY0OSuZtTfFQRaUjFioIA14xeTfZXTTPpK4Kwz6IlH4rZeSFOz+jlhvxHUzqSeHvirufbVx6LqwPB6Wfx/mkfQQS3H1BTg== X-YMail-OSG: X7zTW.sVM1lD77o94ureUHzP0pzOTKCyP8N5ZqpjLxMYpmcGT7V8IaXHan7LY45 sAHjswINo0VwdSI3wZEExAd0fHzBuGI.U7GjDlhwS8ao3Zd9rQHQdg0pMXghgq_ZQ1PufdkrwYo5 p5D_xiZD9SOFvW6PXcjkTjsIa_AcI4ko7ZFyRZmIq4obajaOBrFbRPfqlftkBuxTvh3JTmib75Jd dpIYSS9UBnOu2qM26UvEnJPNJJVUB_1vUi2J6VQuQC9c.rXNDvGEbsSSJwzqXeol.w.zOo1KshIJ s2UE0EFAST0NwENCMVOXYNRHf0BLsS8nCAcAoe_sg.SciEKuNXuw2_SreO_b8PVLqICkxXqBREpf JG1_QEcwqGSehwkoR4CfW5RKyjk3_qBhYT6_36rpoOD2N3IQVD9TjxXd_bJtk6HVXjD5SS0.lTSj 93__YH7IaV8M3HfWWHO8uEs_Ih5Lszq9PzJUeQgII5EigyL3.3f0Uq6ENZyQpGzo1Q0jjv4m49fp kUsRMJqhQABpuvF0QbpxVYSKOhgncxti0hW5N55W0_bF.lL6Hk5YpN8hBFITBjAc4b2..m8ldphI oxR3YwnmKUGg3GENXkPJ2WnevCvA62RnJYFk7lm1yZnKrKBIL.Um13Jk48fQBp_SFZGyNudCWZBI 4MPSrke5KjrNXdXYyfzxxl5D6N6j0DFvW0zzgdQ9t31hVmMqoCo5I1eVVuMTydJPcFJXqtvf6geZ 9PLsaJqVQXqSdA3a4SSNU4rdS4DS4w3lgPaVXeTJF7.FNm4_7YT5tAtkJ9psp9gkE1F0EOWK7zUh sq3gREsAp_jT5CqPa4Wbf32z_NXjiUpBv42SLLo7sh X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Mon, 11 Jul 2022 03:13:15 +0000 Original-Received: by hermes--canary-production-sg3-67975bbd4b-w2clr (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 2ed4ea7632ac2e7c9bb6dc343d46ac18; Mon, 11 Jul 2022 03:13:08 +0000 (UTC) In-Reply-To: (Tom Gillespie's message of "Sun, 10 Jul 2022 19:50:08 -0700") X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236603 Archived-At: Tom Gillespie writes: > -#ifdef USE_GTK > bool already_has_events; > -#endif > > if (xg_select_suppress_count) > return pselect (fds_lim, rfds, wfds, efds, timeout, sigmask); > @@ -126,8 +132,8 @@ xg_select (int fds_lim, fd_set *rfds, fd_set *wfds, fd_set *efds, > context = g_main_context_default (); > acquire_select_lock (context); > > -#ifdef USE_GTK > already_has_events = g_main_context_pending (context); > +#ifdef USE_GTK > #ifndef HAVE_PGTK > already_has_events = already_has_events && x_gtk_use_native_input; > #endif > @@ -179,12 +185,6 @@ xg_select (int fds_lim, fd_set *rfds, fd_set *wfds, fd_set *efds, > tmop = &tmo; > } > > -#ifndef USE_GTK > - fds_lim = max_fds + 1; > - nfds = thread_select (pselect, fds_lim, > - &all_rfds, have_wfds ? &all_wfds : NULL, efds, > - tmop, sigmask); > -#else > /* On PGTK, when you type a key, the key press event are received, > and one more key press event seems to be received internally. > > @@ -217,7 +217,6 @@ xg_select (int fds_lim, fd_set *rfds, fd_set *wfds, fd_set *efds, > FD_ZERO (efds); > our_fds++; > } > -#endif > > if (nfds < 0) > retval = nfds; > @@ -248,11 +247,7 @@ xg_select (int fds_lim, fd_set *rfds, fd_set *wfds, fd_set *efds, > > /* If Gtk+ is in use eventually gtk_main_iteration will be called, > unless retval is zero. */ > -#ifdef USE_GTK > need_to_dispatch = retval == 0; > -#else > - need_to_dispatch = true; > -#endif > > /* xwidgets make heavy use of GLib subprocesses, which add their own > SIGCHLD handler at arbitrary locations. That doesn't play well Thanks. Why did the code previously under !USE_GTK have to be removed?