From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend Date: Fri, 15 Jul 2022 20:58:46 +0800 Message-ID: <87v8rymt15.fsf@yahoo.com> References: <87wnch16as.fsf@elite.giraud> <87k08gtsz0.fsf@yahoo.com> <87cze8t4i9.fsf@elite.giraud> <87k08goud8.fsf@yahoo.com> <87h73jq1dp.fsf@elite.giraud> <874jzjp1st.fsf@yahoo.com> <87ilnysi72.fsf@elite.giraud> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33044"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 56538@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 15 15:00:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCKwA-0008Mm-GX for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jul 2022 15:00:54 +0200 Original-Received: from localhost ([::1]:52404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCKw5-0003aP-GA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jul 2022 09:00:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCKvM-0003ZV-Pv for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 09:00:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCKvL-0006Mk-6U for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 09:00:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCKvK-0000Eq-2J for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 09:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jul 2022 13:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56538 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56538-submit@debbugs.gnu.org id=B56538.1657889954836 (code B ref 56538); Fri, 15 Jul 2022 13:00:02 +0000 Original-Received: (at 56538) by debbugs.gnu.org; 15 Jul 2022 12:59:14 +0000 Original-Received: from localhost ([127.0.0.1]:39795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCKuY-0000DP-9v for submit@debbugs.gnu.org; Fri, 15 Jul 2022 08:59:14 -0400 Original-Received: from sonic305-21.consmr.mail.ne1.yahoo.com ([66.163.185.147]:34282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCKuL-0000Ci-5j for 56538@debbugs.gnu.org; Fri, 15 Jul 2022 08:59:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657889935; bh=PnkyYCD25i1pBYsHwlGCA9zDAiBhRVeef66n/MAgO/w=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=myWY4NgGqDTowhbm0GnMuTFjQIwJr9Q2hmXeSCcdqMpPUX3uOHTly1sFbdBQsrLI8XMye6P5/vaOexc20Gm4wfKp+pJhvt77InjL4lxJ2U+q2evP0KUueg6PqHY8RjTHbRRMxqBEhPe/6G8M523IQ7CrEUBH3xoFO1b+Rd9i5RSeoZwPErbTFyxwqw9kx0oI8wnW0I/EFk0RbAkufrB1Zkga5Rcoq1CcBwY7qbCyhpSr9ECdGWq/zzEfiHtEIBlgQgKoWY3XcwioxmXcifpKWHM86fodgtBp6eJynpZbBueoiMv8IogwKk48HMr44FKJdgYUFO7Js8YRKLIcw4w1GA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657889935; bh=0joNNkW5uiMxLzpMAGWloDiDY3UrYKlXeK9Hxz84YyR=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=apeupy5/R3RphUvBP7FFYeKZwPeIqJuMBDWirdpw6hTNHHD5lj7IpPEjyDJZBJirWU4qpAFwSjCCKp/Ufz1iZOlzsVG6m8h0BYFt/9YJyObGH+HhjnVfcUHp4Y+N5neHkBpOtoNHJaIRE84RS1i01fagJBrm8PwQftm9NuNZyHvVxBV4aVOQGg4M6W12ukbO8SpLAwgPaSnQyeqUOZ/7UKu7I8FCRBYhzIrnCGkrhFAFaHyOwNnYIafho8fo1vg+6YsECC3euZdoMoDaSbT6+CbyN9critof+GTCoJvuTyL9wcOE3BOJWnsaVSr27bJ/ha2PSf16HrM/V6N9+2lDyw== X-YMail-OSG: mO3GQgAVM1nuVz5j6dBDFPAlDvMK12lnD7AI8aW4AARa2JdrPsleOPQXoBo3T2Q 2rhUQOp.HNKG1i7duiVDpaQH7pDubRglqGxTXOFEPh7WNkFuoz0w0WqpmUf9fiKKg_DaalOZnm3b yQcCVSnPhTvRr5pwGT..8gZYMbY.Gbjdzkn_N44Y1mX0N_.4qHQRA9QoUccCAXPT0RlYvZ6UBPZ_ v51lrNOsKS0gk2Tb_Vss5oQzeUBY_WvNo0NEHZk.Ju2pmEiw_7eViK_ufYn4SFYltdnZItlJKS6R AClgWQZ0yAdZ.SbgtWoDCBD.4v9l7Psc2ty7VB2oqS_j1GBbZuzqW8cHfeCkdTfy_n0kt61N2Ne1 n7Qg_YGmsdQy5DGH3aZsYVBMoGYdhp89e7MD5odqrAvbMF1NKYpK9ZeJXvPBPAzcVSM.EbH7Qx2K sHOAJmC7xGDKd3H7AKbbjA0qYu4TUVVWHqm4gCG_HRW4egtKAJdwK8mLFRXSpezJli7cGLlpYUbn 4zZjxymNTSv4p85jKOYBieJFpzEhGAXWrHGV1_yd84PYrRKa8dQHSetpznhT4EFTDdTMWyfX.FCy b5E20ykBICan6G8p7QwuH_yHPPNnraALbMsBA760ZaBqENZM4mnzeSmANyz24KOhTli2uLLW7BVS Y1RvcX0WDmu.RuXDYYo_XEMgys8IgY5EOR7qNdOaSg_i5N2Uzmr_SXb8paor086gad_ZY35kM03u NW9Ozj8epRFTr8Cf3LemCbEfHRXIxWKzpaOaV9Ex4Np9lA_Wd.FWTcPu94g5G5aNc6RIXgTMIpyF jrcLJatRZyBbspfTnSw02.BLl5KAEV6KRzyC84X674 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Fri, 15 Jul 2022 12:58:55 +0000 Original-Received: by hermes--canary-production-sg3-67975bbd4b-w2clr (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0f53437e286836a93d42175b2551ada2; Fri, 15 Jul 2022 12:58:51 +0000 (UTC) In-Reply-To: <87ilnysi72.fsf@elite.giraud> (Manuel Giraud's message of "Fri, 15 Jul 2022 13:56:17 +0200") X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237092 Archived-At: Manuel Giraud writes: > Here is a new version of this patch. What's new: > > - fix some comments > > - format arguments list on both new functions and the one I have > modified their arguments > > - add some forgot freeing in `release_shadow_gcs' Thanks. One (late) last comment on the documentation: > +@item highlightForeground > +Foreground color for a highlighted menu item. > +@item highlightBackground > +Background color for a highlighted menu item. Shouldn't this say "the menu item highlighted by the mouse"? Otherwise, what "highlighted" means is not exactly clear. > +** New X resources: "highlightForeground" and "highlightBackground" > +Only in the Lucid build, this controls colors used for highlighted > +menu item widget. And here, shouldn't "widget" be in plural?