From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#57082: 29.0.50; emacs-news-view-mode breakage Date: Tue, 09 Aug 2022 22:18:53 +0200 Message-ID: <87v8r1xj9u.fsf@gmx.net> References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26853"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 09 22:20:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLViQ-0006qa-Mj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 22:20:38 +0200 Original-Received: from localhost ([::1]:40802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLViP-0001PJ-Qp for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 16:20:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLVhq-0001P8-JP for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 16:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLVhq-0007LX-As for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 16:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLVhq-0001fg-6b for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 16:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Aug 2022 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57082 X-GNU-PR-Package: emacs Original-Received: via spool by 57082-submit@debbugs.gnu.org id=B57082.16600763446330 (code B ref 57082); Tue, 09 Aug 2022 20:20:02 +0000 Original-Received: (at 57082) by debbugs.gnu.org; 9 Aug 2022 20:19:04 +0000 Original-Received: from localhost ([127.0.0.1]:45162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLVgt-0001e2-JV for submit@debbugs.gnu.org; Tue, 09 Aug 2022 16:19:03 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:33499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLVgq-0001dX-Qo for 57082@debbugs.gnu.org; Tue, 09 Aug 2022 16:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660076334; bh=EOths1oWYU2vdGNTv+SXVecZRqmr2XCXKKpYUllwwPo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=ROXJ/ITIKj5YI4nswIekA69496qMgCDhtcJ3U/xNEhrNPFpAWD3SdXYzCxTz/HnI/ QzIwcGWNBDZpVCyoW2Cia0woVZqFfrq5r9+4dyJS75jl2ErUt1xo9aZ20sULHZmA98 wivFpgJtcUGVLkzC6Zwa//nauJzYIlEqDyQ+d+cg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobelfs2 ([89.246.38.154]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MKsnP-1o7Qg72uIX-00LD7a; Tue, 09 Aug 2022 22:18:54 +0200 In-Reply-To: <865yj1p6o2.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 09 Aug 2022 22:18:21 +0300") X-Provags-ID: V03:K1:Y7FeNWA/wxD5uFbOtxQqU0hkdHifhsiVmpF9bQLY3SWmgS1cEwV YbEHUDzwjh8up6VuPoHOYtSWTYJlsZWmy6+Th1a/vvfSoC851BImHqOs6sS5S444RDtrpsl eyzZJbTe7i8SO7nD+OkvJoe+X/55wWtFGfD76Y2HyeFVqrOvk6j+qScpyO92vtv5PvWMGP9 1KTynvzSdJ6/YSxYf908A== X-UI-Out-Filterresults: notjunk:1;V03:K0:dF/ha5afKMI=:LRrLFj/nw3x4VcRLsUYh3W POKjt5kJvjQdiovkX/C7fG2valdi7llhnDSuPGYbvz0gTHSipgj1JnU6QueA2YEVqkE0Qccub WUr4HwP/m2mxBOaEToqwrvN+R4rDQCA3ymJP66klvgOOkBx+9VkGSHPpgnX8+u9l0+pEBuWJa DztmPOxwqTOBjxT/M+Xx+Bj9kGcbgfm3ntzN7hog/m/2+3XaDf/LCn897BNufmYnykifVGEDe t64NYAkZbQF1DSq1UqoGG25QbpIKGPDQtIYNYBIJAExGwgdfs+/9DsUyTzT5dftOoIt/3FFKd CGWusLhH/6Gro/UdDgoHw8pL/H+XrDHwZx8h311REPyF1aIodeb1aLdWlwWMzgv2VW6ylWgla 29ERvG2gjEu9IUXe6X+V0988LTyO72JofMSS1FDj6CCVRbnUaZs9yQY9GUudPYOsR3HYsfn6M CYayy0cOXhs9R/yHHaDfGEeK+7KPYz6NOEELdNUZI9ra8ct9H/cuOJtaxOQYXHsM9Bpp/Hd4K JRhfgRwjWIAWjHHh9so4lSX/adMGKqsJfjTxVql1bRFyYKZVfRq5P+hD3EOLHuw41zVQVeMG4 9fBVlCpPuNlWlr0bI0XIcbxOYYwQkeuvyeb6iKNt7+Fku/T3eEAOZW9nFeHJjIhrIYFVSul9/ 64PjbACC2mbc76/owdjclHl2k1jrmJApedL9FEGDQtWOagO5yf0vTis53ZjLcd0bYi7QXySbZ oy9Wivf83mhk/G0SE8kp8Th4SVkE4+pdNeBY97/V6nW+E0GJSQ2u7dtRDNh9WcUjrfua7EnR X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239224 Archived-At: On Tue, 09 Aug 2022 22:18:21 +0300 Juri Linkov wrote: >>> The attached patch appears to fix the problems described above, but the >>> only buffer using outline-minor-mode beside NEWS that I've tested it on >>> is *Help* showing the output of describe-bindings, and the seems to work >>> as expected with the patch (and due to the patch is not flagged as >>> modified, though that isn't important for *Help*.) >> >> Thanks; patch applied to Emacs 29. Thanks Lars. > I noticed more problems: arrow directions are inverted - when an outline > is hidden the arrow direction is open; when it's shown then the button has > the closed state. The arrows behave the same as in *Help* with describe-bindings: outline-close (downward-pointing) when the body is hidden, outline-open (leftward-pointing) when the body is shown. Is that wrong? > S-TAB (outline-cycle-buffer) is very slow: takes ~3 seconds on a small > NEWS buffer. > > Also don't understand why is this change: > > (when outline-minor-mode-highlight > - (if (and global-font-lock-mode (font-lock-specified-p major-mode)) > - (progn > - (font-lock-add-keywords nil outline-font-lock-keywords t) > - (font-lock-flush)) > - (outline-minor-mode-highlight-buffer))) > + (when (and global-font-lock-mode (font-lock-specified-p major-mode)) > + (font-lock-add-keywords nil outline-font-lock-keywords t) > + (font-lock-flush)) > + (outline-minor-mode-highlight-buffer)) > > `outline-minor-mode-highlight-buffer' is intended only for buffers > that don't support font-lock highlighting. Yes, but with that change, arrows are displayed on first visiting the NEWS buffer; without it, they only appear when typing TAB on an outline heading. >> The outline button stuff is still a work in progress, as you've found >> out. I'm not quite sure whether it should be switched on by default in >> NEWS buffers -- it doesn't seem to bring much value there. (As opposed >> to in `describe-bindings', where it seems very helpful (since we're >> starting out with some parts already folded.) > > It would be nicer if the color of the button depended on the outline's color, > e.g. blue for the top-level blue outline face, etc. I guess that would require using suitable images rather than emojis. Steve Berman