From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved Date: Tue, 11 Oct 2022 02:23:21 +0200 Message-ID: <87v8orky2u.fsf@gnus.org> References: <87mta7lb3o.fsf@bernoul.li> <87k05asa8w.fsf@gnus.org> <871qrivsoz.fsf@bernoul.li> <87ilktqdwe.fsf@gnus.org> <87pmf0c5g9.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26613"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58363@debbugs.gnu.org, Eli Zaretskii To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 11 02:24:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oi344-0006ld-Qm for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Oct 2022 02:24:08 +0200 Original-Received: from localhost ([::1]:58608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oi343-0005xY-Ey for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 20:24:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oi33y-0005xN-Dc for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 20:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51177) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oi33y-00066u-54 for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 20:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oi33x-00057l-Pl for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 20:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Oct 2022 00:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58363 X-GNU-PR-Package: emacs Original-Received: via spool by 58363-submit@debbugs.gnu.org id=B58363.166544781419659 (code B ref 58363); Tue, 11 Oct 2022 00:24:01 +0000 Original-Received: (at 58363) by debbugs.gnu.org; 11 Oct 2022 00:23:34 +0000 Original-Received: from localhost ([127.0.0.1]:50255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oi33V-000571-IW for submit@debbugs.gnu.org; Mon, 10 Oct 2022 20:23:33 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:60340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oi33U-00056m-Fb for 58363@debbugs.gnu.org; Mon, 10 Oct 2022 20:23:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mz788a/uqg0y2Iv/+Q4zE4Lkeqs3iZX0uKNpVgDCATY=; b=cT+EtHLYo8QvDqTY9RsLC7QOB2 8qHoRzJ1B1FpI9ex+mUGcS/nKstW6vkE8viIq8k/Ba/BS56ZPKkWBJRVpDB7qRWphKV9fxX5I4Qia FNF45s+YmTxGX1986DLo275NVftxEqLxueJJL/riX2zSfnyuKiMbKOikcNq0Pv3wrJ9o=; Original-Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oi33K-00069L-If; Tue, 11 Oct 2022 02:23:25 +0200 In-Reply-To: <87pmf0c5g9.fsf@bernoul.li> (Jonas Bernoulli's message of "Mon, 10 Oct 2022 12:56:38 +0200") X-Now-Playing: Lemon D's _15 Years of Metalheadz_: "This Is LA" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245058 Archived-At: Jonas Bernoulli writes: > You should probably do the same for sqlite-execute. Now done. > So I would encourage you to always (i.e., not only in sqlite-select) > signal > > (sqlite-error sqlite_errstr() sqlite_errmsg() sqlite_errcode()) Patches welcome. > By the way, for one particular error sqlite-execute already uses a > separate signal: Qsqlite_locked_error. But only that function does it > and only for that one error. That seems highly inconsistent. I would > recommend removing this signal and replacing it with Qsqlite_error and > using that for every error and to always include all available data, > filling in nil when a particular piece is not available. It's a retryable error, so it's nice to be able to differentiate easily.