From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type Date: Sat, 22 Oct 2022 17:32:07 +0200 Message-ID: <87v8obri14.fsf@bernoul.li> References: <87v8orky2u.fsf@gnus.org> <20221021210636.13329-1-jonas@bernoul.li> <20221021210636.13329-2-jonas@bernoul.li> <83czakuziw.fsf@gnu.org> <874jvwrvbl.fsf@bernoul.li> <83y1t8t730.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27498"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58363@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 24 05:41:06 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omoKo-0006zo-EO for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Oct 2022 05:41:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omhyD-0004hq-NE for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Oct 2022 16:53:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omGUg-00017G-Jp for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 11:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omGUg-0008Sm-Bb for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 11:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1omGUf-0001xm-V5 for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 11:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Oct 2022 15:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58363 X-GNU-PR-Package: emacs Original-Received: via spool by 58363-submit@debbugs.gnu.org id=B58363.16664527337487 (code B ref 58363); Sat, 22 Oct 2022 15:33:01 +0000 Original-Received: (at 58363) by debbugs.gnu.org; 22 Oct 2022 15:32:13 +0000 Original-Received: from localhost ([127.0.0.1]:42193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omGTs-0001wg-UO for submit@debbugs.gnu.org; Sat, 22 Oct 2022 11:32:13 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:40438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omGTq-0001wX-96 for 58363@debbugs.gnu.org; Sat, 22 Oct 2022 11:32:11 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id E5A83165D1; Sat, 22 Oct 2022 17:32:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1666452727; bh=FVh94vm9+URXGNOSo2s+DJpB +4kM31pVNesWKgS6KmI=; b=WnMYXLzLHeCOdhWmRDxOeM45CjRLOIKr9gA4P6Hn 2HlxHY8uXmzczlL02VL0SOcvaWdlBz3oUlEPwNH4fqvtedJyY2ShdYW6IL/7QEdY q9OxrHAu3CQ4UQfaTbaVQW/zVrsfcEt/0KfJjJn7XW9R1N/Xnvt/7PSD8aeqYVZb hlA= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id Vfo-Iy-4bJi8; Sat, 22 Oct 2022 17:32:07 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id B808416572; Sat, 22 Oct 2022 17:32:07 +0200 (CEST) In-Reply-To: <83y1t8t730.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:246067 Archived-At: Eli Zaretskii writes: >> From: Jonas Bernoulli >> Cc: 58363@debbugs.gnu.org >> Date: Sat, 22 Oct 2022 12:45:02 +0200 >> >> Eli Zaretskii writes: >> >> >> - xsignal (Qerror, build_string ("Module name not on allowlist")); >> >> + xsignal1 (Qerror, build_string ("Module name not on allowlist")); >> > >> > Why Qerror here and not Qsqlite_error? And if the more general Qerror >> > is deliberate, then why not Qmodule_load_failed, for instance? >> >> This commit just fixes a bug. >> Qsqlite_error is introduced in the next commit. > > This is one reason why I prefer a single patch to series of patches. > (I believe Lars prefers that as well.) It avoids the need to review > patches that are superseded by the following ones, especially when > network delays cause the different parts of the series to be delivered > out of sequence. > > So, unless this totally disrupts your workflows, please post patches > as a single coherent changeset, bypassing intermediate steps that are > later superseded. TIA. I will do as you wish but I completely disagree that this is the right thing to do. But let's agree to disagree, and since you are the maintainer, you get to say how it ought to be done around here. (Is there anything you would like me to do, aside from squashing these two (or all three?) commits?)