From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Danny Freeman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Thu, 10 Nov 2022 17:57:30 -0500 Message-ID: <87v8nmv2cx.fsf@dfreeman.email> References: <8cf8ba5d-c604-b2dc-274a-7597b19fb73f@dfreeman.email> <87ilk5xq01.fsf@gmail.com> <87r0yrwfn3.fsf@gmail.com> <37716e41-5955-99f6-5204-e760a716fbf6@yandex.ru> <9bb290c8-f000-31d8-265d-b5441c33eb38@dfreeman.email> <4d50b820-7053-75eb-5b11-d3d36a02b013@dfreeman.email> <87v8nxsrq6.fsf@gmail.com> <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> <87fseqtpiu.fsf@dfreeman.email> <875yfm8lzf.fsf@gmail.com> Reply-To: Danny Freeman Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25734"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , dgutov@yandex.ru, felician.nemeth@gmail.com, 58790@debbugs.gnu.org, stefankangas@gmail.com To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 11 00:04:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otGav-0006Qb-7V for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Nov 2022 00:04:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otGab-00086v-2Q; Thu, 10 Nov 2022 18:04:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otGaY-00086i-BZ for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 18:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otGaY-0005LP-3R for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 18:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otGaX-0006dD-IC for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 18:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Danny Freeman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Nov 2022 23:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166812143325476 (code B ref 58790); Thu, 10 Nov 2022 23:04:01 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 10 Nov 2022 23:03:53 +0000 Original-Received: from localhost ([127.0.0.1]:44608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otGaO-0006cq-Ln for submit@debbugs.gnu.org; Thu, 10 Nov 2022 18:03:52 -0500 Original-Received: from out0.migadu.com ([94.23.1.103]:17841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otGaJ-0006cf-Dr for 58790@debbugs.gnu.org; Thu, 10 Nov 2022 18:03:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1668121426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xuhS6qaIKMfZnbXJ5U4n5ApWlPJ+nyScYCvUVcx9lvc=; b=WDqqBJC3MmB7PyfwckGAYunxPExVqv95WzShIISvqbFMyt+ahlEplcmNaV30nrOG4vZRtj xatIdyuH2EH3oAl6AWi3RwscnIQLQllHeGbenot7vuDs8BBLnkto0pzuIKgASDNNt0bvPk +1LLMMiyUiRDFGssAG6T1CiEmCKCVOU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <875yfm8lzf.fsf@gmail.com> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247560 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > I've now pushed the first patch, but I held off the second patch. > > I don't see this OPERATION=3Dnil option documented in the docstring of > find-file-name-handler, so I'm not sure we should rely on it. > > I think we should provide OPERATION here, because what we want to check > is if we, Emacs, can actually visit the file designated by the URI. So > I think passing something like 'access-file' as the OPERATION argument > makes more sense. But Eli probably has more knowledge here. Maybe > passing nil is indeed correct. If we want to not use nil I think a real operation argument like `access-file' or `expand-file-name' would be more warranted then. The made up one I initially used I was not a big fan of. --=20 Danny Freeman