From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#59139: closed (Re: bug#59236: 29.0.50; [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore) Date: Mon, 14 Nov 2022 11:50:44 +0000 Message-ID: <87v8nh21rf.fsf@posteo.net> References: <87edu7wc77.fsf@posteo.net> <9364482a-c29a-cc28-34a8-f596cf019bfa@orange.fr> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3401"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59139@debbugs.gnu.org, Eli Zaretskii To: David Ponce Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 15 00:32:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ouiwI-0000eJ-0A for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Nov 2022 00:32:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouinU-0007kR-NW; Mon, 14 Nov 2022 18:23:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouiff-0006Df-Ne for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 18:15:20 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouXzS-0006kR-Ks for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 06:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ouXzS-0003rf-2D for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 06:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Nov 2022 11:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59139 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59139-submit@debbugs.gnu.org id=B59139.166842665314840 (code B ref 59139); Mon, 14 Nov 2022 11:51:02 +0000 Original-Received: (at 59139) by debbugs.gnu.org; 14 Nov 2022 11:50:53 +0000 Original-Received: from localhost ([127.0.0.1]:49081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouXzI-0003rI-PW for submit@debbugs.gnu.org; Mon, 14 Nov 2022 06:50:53 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:38529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouXzG-0003r4-UU for 59139@debbugs.gnu.org; Mon, 14 Nov 2022 06:50:51 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 49E3F240027 for <59139@debbugs.gnu.org>; Mon, 14 Nov 2022 12:50:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668426645; bh=+PII++uJ0M5JuQq1o+pybWfRWFqYp7/WkFKT166ah9I=; h=From:To:Cc:Subject:Date:From; b=KxZiAFerMm8AoJvTRJ1Tif61twB0rcWGmsKuBdLrA+kmPBQOwo3gKSiAXfEe6BWQK DKYWRTnNUj47FROhCWGPyFVwYWp5UVQqeZCkG2FqZJe7oWpBbvQWrDdNSSjfaEjSr3 I0NuvvM6pVupV7Cd6xTkEhuGoO4pVM9vo6ZzA06Vpym9CrBook41xrw6TCNLMoXE7a 3suhxpbB1HBJDuvxO7sWAFT+fJ39xfrZ+tZk2xWcbpg7ezUmRtPwM4KJ6rWzyPqp3M zJHHeHSSHWsnfLBYuBjz9auzXj5VQNS5sAVKR1nIUt+6y7Txis7GGPIO6Yc9MnLWa9 tgjnhhq9XQtXw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N9ngm34B3z6tmF; Mon, 14 Nov 2022 12:50:44 +0100 (CET) In-Reply-To: <9364482a-c29a-cc28-34a8-f596cf019bfa@orange.fr> (David Ponce's message of "Sun, 13 Nov 2022 11:12:30 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247830 Archived-At: David Ponce writes: > On 13/11/2022 08:23, GNU bug Tracking System wrote: >> Your bug report >> #59236: 29.0.50; batch-byte-recompile-directory doesn't recompile >> file as expected >> which was filed against the emacs package, has been closed. >> The explanation is attached below, along with your original report. >> If you require more details, please reply to 59139@debbugs.gnu.org. >> > > As mentioned in bug#59236 and my reported bug#59139, the patch > 8638aace3f to use the variable `byte-compile-ignore-files` has > the logic inverse for both file and *directory* parts. > Currently the patch a01024c859 fixed the logic for file part, but > the fix to the directory part is still missing, as far as I can > see in master. Currently, according to the code, when a > directory matchs `byte-compile-ignore-files` it is appended 2 > times instead of being ignored. You are right. I have also discovered that this is related to the failing tests reported in bug#59109. I'll rework your patch and apply that then.