From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#58985: 29.0.50; Have auth-source-pass behave more like other back ends Date: Fri, 18 Nov 2022 16:35:09 -0800 Message-ID: <87v8nbwzlu.fsf@neverwas.me> References: <87wn8cb0ym.fsf@neverwas.me> <874jvdardn.fsf__3771.40490324877$1667692584$gmane$org@neverwas.me> <87pme09vis.fsf@gmx.de> <87a653z7dl.fsf@neverwas.me> <878rkjl1vd.fsf@disroot.org> <877d026uym.fsf@neverwas.me> <87tu35eehq.fsf@disroot.org> <87bkpcu74w.fsf@neverwas.me> <875yfkdwlm.fsf@disroot.org> <874jv3nwmc.fsf@disroot.org> <875yfiq3d8.fsf@neverwas.me> <87mt8uvxkp.fsf@disroot.org> <877czxlgd4.fsf@neverwas.me> <87edu5toi6.fsf@disroot.org> <87a64s99ka.fsf@neverwas.me> <87bkp4z6xg.fsf__44191.716185172$1668780942$gmane$org@neverwas.me> <8735af6e1b.fsf@tetzco.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17448"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58985@debbugs.gnu.org To: Kai Tetzlaff Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 19 01:36:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owBq9-0004Lb-6k for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Nov 2022 01:36:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owBpz-0004wX-VU; Fri, 18 Nov 2022 19:36:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owBpy-0004vG-US for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 19:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owBpy-0000Pi-Lk for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 19:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owBpy-0004at-IK for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 19:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Nov 2022 00:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58985-submit@debbugs.gnu.org id=B58985.166881812717602 (code B ref 58985); Sat, 19 Nov 2022 00:36:02 +0000 Original-Received: (at 58985) by debbugs.gnu.org; 19 Nov 2022 00:35:27 +0000 Original-Received: from localhost ([127.0.0.1]:38536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owBpO-0004Zp-Iu for submit@debbugs.gnu.org; Fri, 18 Nov 2022 19:35:26 -0500 Original-Received: from mail-108-mta149.mxroute.com ([136.175.108.149]:37831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owBpK-0004Zb-Lx for 58985@debbugs.gnu.org; Fri, 18 Nov 2022 19:35:25 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta149.mxroute.com (ZoneMTA) with ESMTPSA id 1848d4f8ffd0006e99.001 for <58985@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 19 Nov 2022 00:35:12 +0000 X-Zone-Loop: c158e47de9c391e2511b41c4661bd0d1a0df8b5f40f4 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2zEngZNdrqEVIGgyRRgymuHIc8FaJ/6kP+94PkYHseQ=; b=dcJCBSh79tellY0YxYvo8hoeNc hPBRc3xIj/xIwMIHYJxFkAYSunadv5Tdpt4iZnLR3JQu45hnYBIwR0eqejOuaFA/YSfE/Uq/hRVdc EE+6nJ+BxuvKaEL0N1DrHQSDL3E49/vRPbIlPGcoPmo/w4csW2A270pNzzRJBm2CbfecHmvxnhWlO OgCgztHhj+sblTeku3m1Ev1sKDu1x+zDpGncgDEPSFz7/jwLcvbp7dW7zLTB+vE8Mx7xMBnUtjf1f aB5lvVVXNRViPla3od3hZAIIJUaG7TnFjyysbI0X3gCFHcCwxYqHKrGlk59q6JSIPgZaOpLF7Ncpe f+1trfUw==; In-Reply-To: <8735af6e1b.fsf@tetzco.de> (Kai Tetzlaff's message of "Sat, 19 Nov 2022 00:25:36 +0100") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248287 Archived-At: Hi Kai, Kai Tetzlaff writes: > This change breaks my use of `auth-source-pass' in gnus. Thanks a lot for reporting this. And sorry about the breakage. > I haven't had time to investigate the issue but what I can already say > is that the problem occurs independent of the value of > `auth-source-pass-extra-query-keywords' (`t' or `nil'). So the > change is not backward compatible. It would (at least) be nice to > mention this in the NEWS entry. I'd rather not settle for "at least" if we can help it. If the user option doesn't preserve existing behavior, that's a bug that needs fixing. The traditional and new code paths diverge in `auth-source-pass-search', so without a backtrace, we should start there. (Obviously, a full backtrace would be ideal, but I understand completely if you're not willing to surrender one.) First off, can you try reverting the changes to that function alone? Just eval'ing a modified version in place, without the extra `cond' clause and the two keywords, :max and :require, should do it. If that doesn't tell us anything (and only if you're up for it) you could trace the function and tell me what the inputs were (obviously after swapping out any sensitive info). A mini example of your ~/.password-store layout might also be helpful. According to etc/AUTHORS, you're likely much better acquainted with Emacs than I (2009!). So, please adjust the above recommendations accordingly and, if possible, apply some of that experience to helping fix this bug. And apologies again for the disruption. Thanks, J.P.