From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression Date: Fri, 02 Dec 2022 21:29:28 +0100 Message-ID: <87v8mt7dnb.fsf@thornhill.no> References: <831qpklejb.fsf@gnu.org> <83mt88jul4.fsf@gnu.org> <0A18F996-F3BB-4A7D-A0BE-76C8374DE517@thornhill.no> <8335a0jofb.fsf@gnu.org> <7BE15945-C463-448A-8593-E3B5D0E374FB@thornhill.no> <871qpj1x2k.fsf@thornhill.no> <83fsdzin4e.fsf@gnu.org> <87v8mvzgmt.fsf@thornhill.no> <838rjrigmq.fsf@gnu.org> <87k03bz99r.fsf@thornhill.no> <835yeviats.fsf@gnu.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24910"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59691@debbugs.gnu.org, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , jostein@kjonigsen.net To: Yuan Fu , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 21:30:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1Cg3-0006I3-0Y for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 21:30:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1Cfe-0005rV-4V; Fri, 02 Dec 2022 15:30:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1Cfb-0005qk-7v for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 15:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1Cfa-0004S1-Kq for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 15:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1Cfa-0000yR-5G for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 15:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 20:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59691 X-GNU-PR-Package: emacs Original-Received: via spool by 59691-submit@debbugs.gnu.org id=B59691.16700129743703 (code B ref 59691); Fri, 02 Dec 2022 20:30:02 +0000 Original-Received: (at 59691) by debbugs.gnu.org; 2 Dec 2022 20:29:34 +0000 Original-Received: from localhost ([127.0.0.1]:48703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1Cf7-0000xf-K4 for submit@debbugs.gnu.org; Fri, 02 Dec 2022 15:29:33 -0500 Original-Received: from out-96.mta0.migadu.com ([91.218.175.96]:34362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1Cf5-0000xZ-TO for 59691@debbugs.gnu.org; Fri, 02 Dec 2022 15:29:33 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670012970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0ppev3Ik8BW5EdaG76Ococjw7l93y5HY0b+R3eC4xFM=; b=bD87Sg4J4fkha45ollJo24iNzfYTc7ib6N+W21LZVpxFucds8mHY1FZOdzoihlkshK/LGq I5UzI8Fi13SJ9acnfxJ7MBOcf7ffe1Gu++xUdLT5E4YaZmhiewMAzv+JlvCpsoXd5VPpF2 shMGAF6jWzj8NE654hjQdh+p7kxC3HQcIqJGuzcozD9IjD5FtshyL2AaS+dTy6nPHQM6ni p6ih2h1Rs1KMVUqtcJj4zkebqnFiyu5NhvRvyIn+HHsp+Lad+mnBI3GRGATTst9k6ezp4P cIsgMvI/qKVBr4M7275Sgbyb1f3Uemi9qZ2byOrwkBf82v5wqERcyV9hKHU1kQ== In-Reply-To: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249784 Archived-At: Yuan Fu writes: >> On Dec 1, 2022, at 4:10 AM, Eli Zaretskii wrote: >>=20 >>> From: Theodor Thornhill >>> Cc: casouri@gmail.com, jostein@secure.kjonigsen.net, 59691@debbugs.gnu.= org, >>> jostein@kjonigsen.net >>> Date: Thu, 01 Dec 2022 11:52:00 +0100 >>>=20 >>>> Yes, I missed that, sorry. But the NEWS entry should clearly say that= one >>>> mode is the default for *.ts files, the other for *.tsx files. >>>=20 >>> No worries :) >>>=20 >>> Is this patch suitable? >>=20 >> LGTM, thanks. >>=20 >> Yuan, if you are okay with this, please install. > > Cool. I applied the patch, thanks Theo! I changed typescript-ts-mode=E2= =80=94base-mode to typescript-ts-base-mode, since I don=E2=80=99t think any= one has strong opinions about its naming, and typescript-ts-base-mode is mo= re consistent with other tree-sitter base modes. > > Yuan Thanks! I believe this can be closed. What do you think, Jostein? Theo