From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#60841: 30.0.50; kill-ring-save pauses despite region being highlighted Date: Sun, 29 Jan 2023 23:57:33 +0100 Message-ID: <87v8kpj6ea.fsf@gmail.com> References: <87h6wrs71h.fsf@gmail.com> <83zgai4peg.fsf@gnu.org> <5583fd58387746ce7ddc@heytings.org> <87cz7dbns0.fsf@gmail.com> <4c2c6cf44ad37e405b06@heytings.org> <878ri0g6ob.fsf@gmail.com> <83pmbc0yxo.fsf@gnu.org> <87y1pzo5dp.fsf@gmail.com> <834jskmhs8.fsf@gnu.org> <87fsc2qjcs.fsf@gmail.com> <833581jtff.fsf@gnu.org> <87lelsga1f.fsf@gmail.com> <83r0vkgj7l.fsf@gnu.org> <87h6wawo2k.fsf@gmail.com> <831qnea5ye.fsf@gnu.org> <87357t2xyh.fsf@gmail.com> <83k01573hz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28441"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: gregory@heytings.org, 60841@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 29 23:58:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMGcr-0007BO-Ae for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Jan 2023 23:58:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMGce-00066a-Tf; Sun, 29 Jan 2023 17:58:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMGcc-00066P-Qc for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 17:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMGcc-0002RN-In for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 17:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMGcc-000581-7N for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 17:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 22:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60841 X-GNU-PR-Package: emacs Original-Received: via spool by 60841-submit@debbugs.gnu.org id=B60841.167503306319688 (code B ref 60841); Sun, 29 Jan 2023 22:58:02 +0000 Original-Received: (at 60841) by debbugs.gnu.org; 29 Jan 2023 22:57:43 +0000 Original-Received: from localhost ([127.0.0.1]:45548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMGcI-00057S-Dj for submit@debbugs.gnu.org; Sun, 29 Jan 2023 17:57:43 -0500 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:37505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMGcG-00057G-NU for 60841@debbugs.gnu.org; Sun, 29 Jan 2023 17:57:41 -0500 Original-Received: by mail-wr1-f50.google.com with SMTP id q10so9534383wrm.4 for <60841@debbugs.gnu.org>; Sun, 29 Jan 2023 14:57:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=MVV1NTd/1yHtKczL/qvHAgtKkml7ilpUCW0r92/UF6c=; b=B97kMLYDy17udLUhTZmGwk9omy3AREsLzCQTJ9cKdiTtIRdrhrujHq3PUfAlks84et m8O8AZ0dK955oSuvta4U5jhUKFGyi5CS9ovoCt6xU8TA8MXCMfm3jXHM4ROI4grGoRpy rVbCpL4UEG9/4V/+AzwrY6TkqALx3KhNBLcWRR4dHgzb/i7SkfTMokbPMX2fxxrjxXjI K+GR8G4WdW1Y3QwHBx5P/7r+JFai73u2J11oFee2b3v7CikOPv0SEfFe/pmIj5OFRBYd yro8lT7swZMztm5bf0X7bDv7CiXo7cwVhtbUlmVMPTrBqppLs8WbfCt4Q5wSWvaAFlzP LOMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MVV1NTd/1yHtKczL/qvHAgtKkml7ilpUCW0r92/UF6c=; b=oFMIlayG+2XZFyQ/9Nc/YQrApcso9/9tVjN/HDaZLvvXER58n32t4G51GXGrjphR+a aaY5LIvaGYWIGuX2xYe+gDRZc9CyxyQTeYcDFpD0Jq3Yqf7a0FTDyU69hrEURqoYBloi o1f0rLl4F00SNc+ORixRrMJW/k8xtvC0Soj0N1ctpi5DPFZ+HZiLlmRp8wK/i10Z0gn7 gpiW3gGq6BcornpyeBZe4/aMtWmkRZGKuow9AYXJw5FPgUwO93IWjV62MhpO5CwC4bHl JuRtOFrmmrFzRpMLxP9QKs5CaGm9RW8b5fxBu/wYPrTXMFMZzvfp9UpxU5/5eq9mMCqK ZX/w== X-Gm-Message-State: AO0yUKXfDr4U+034AvaikL3uMoyxA+oQ9JxK9ZWeb10zMkI1Ljc6Iu+k wkWKqMlCPbymgSZf7EX5XWg= X-Google-Smtp-Source: AK7set+WvW6FtS3P1cZ0Rk2LKJPzqqPUyzXISFZZ9VTJXWBp8p0+NSVoTSMnYt0Gu2eZf3UThosv0A== X-Received: by 2002:a5d:4951:0:b0:2bf:d425:11ba with SMTP id r17-20020a5d4951000000b002bfd42511bamr8886350wrs.22.1675033054647; Sun, 29 Jan 2023 14:57:34 -0800 (PST) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id r6-20020adff106000000b002bfe05bf6dcsm4882477wro.88.2023.01.29.14.57.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 14:57:33 -0800 (PST) In-Reply-To: <83k01573hz.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Jan 2023 17:40:56 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254383 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> =E2=96=BC Copy Region Inhibit Blink: >> Choice: >> (*) region-stands-out-p >> Whether the region can be distinguished visually. More >> ( ) always >> Always inhibit: never blink point and mark. >> ( ) ignore >> Never inhibit: always blink point and mark. >> ( ) Other predicate function.: ignore >> State : STANDARD. >> Whether we should refrain from blinking the cursor after a copy. = =E2=96=BC >> When this condition holds, =E2=80=98kill-ring-save=E2=80=99 will = not blink the >> cursor between point and mark to denote the copied region. >> Groups: Killing >>=20 >> =E2=81=82 VS =E2=81=82 >>=20 >> =E2=96=BC Copy Region Blink Predicate: >> Choice: >> (*) region-indistinguishable-p >> Whether the current region is not denoted visually. =E2=96=BC >> This holds when the region is inactive, or when the =E2=80=98reg= ion=E2=80=99 face >> cannot be distinguished from the =E2=80=98default=E2=80=99 face. >> ( ) always >> Always blink point and mark. >> ( ) ignore >> Never blink point and mark. >> ( ) Other predicate function.: ignore ^ (Booh, that's ugly. Removed in the attached) >> State : STANDARD. >> Whether the cursor must be blinked after a copy. =E2=96=BC >> When this condition holds, and the copied region fits in the >> current window, =E2=80=98kill-ring-save=E2=80=99 will blink the c= ursor between >> point and mark for =E2=80=98copy-region-blink-delay=E2=80=99 seco= nds. >> Groups: Killing > > I prefer the second one, since inhibit-SOMETHING is slightly harder to > grasp, due to the negation. ACK. > The second paragraph of the NEWS entry shouldn't be there: it tells > that we fixed a bug. Right; in this instance I wondered if we should call out what some users could perceive as a "regression". I suppose it doesn't matter; if they are indeed reading NEWS, they'll find this entry whether it mentions the bug or not (since it mentions kill-ring-save). Adjusted the entry in the attached. Re. :stipple: > The problem with :stipple is that we don't allow nil as the value of > :stipple. If you evaluate >=20 > (setq list-matching-lines-prefix-face 'default) > (face-differs-from-default-p list-matching-lines-prefix-face) >=20 > then look in *Messages*, you will see: >=20 > Invalid face attribute :stipple nil (=C5=92il de lynx !) > So we need to treat :stipple specially, or maybe fix merge_face_ref to > allow the nil value. You mean something like the following? (Thoroughly untested, beside passing the (null (face-differs-from-default-p 'default)) test) diff --git a/src/xfaces.c b/src/xfaces.c index 35b79154805..62d7823f308 100644 --- a/src/xfaces.c +++ b/src/xfaces.c @@ -2780,8 +2780,7 @@ merge_face_ref (struct window *w, else if (EQ (keyword, QCstipple)) { #if defined (HAVE_WINDOW_SYSTEM) - Lisp_Object pixmap_p =3D Fbitmap_spec_p (value); - if (!NILP (pixmap_p)) + if (NILP (value) || !NILP (Fbitmap_spec_p (value))) to[LFACE_STIPPLE_INDEX] =3D value; else err =3D true; OT1H that's the kind of sleeping dragon that I wouldn't want to tickle, OTOH I see that other spots in the code seem to accept QCstipple mapping to a NILP value: else if (EQ (attr, QCstipple)) { #if defined (HAVE_WINDOW_SYSTEM) if (!UNSPECIFIEDP (value) && !IGNORE_DEFFACE_P (value) && !RESET_P (value) && !NILP (value) && NILP (Fbitmap_spec_p (value))) signal_error ("Invalid stipple attribute", value); old_value =3D LFACE_STIPPLE (lface); ASET (lface, LFACE_STIPPLE_INDEX, value); #endif /* HAVE_WINDOW_SYSTEM */ } =E2=80=94 Finternal_set_lisp_face_attribute --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Avoid-spurious-pause-in-kill-ring-save-Bug-60841.patch >From d767d5c658278bb102dea9a716da7a04dccb34aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Le=20Gouguec?= Date: Sun, 29 Jan 2023 11:23:01 +0100 Subject: [PATCH] Avoid spurious pause in kill-ring-save (Bug#60841) 'indicate-copied-region' checks whether the region is "highlighted" and if not, briefly moves point to mark to give a visual cue of the extent of text that was saved to the kill ring. The region is considered "highlighted" if (a) it is active and (b) its face specifies a :background. That latter condition does not account for the multiple ways in which the face can make the region "visually distinct" from the default face, so switch to a more extensive predicate. * lisp/faces.el (face-differs-from-default-p): Filter out :extend; add rationale for the attributes we ignore. * lisp/simple.el (copy-region-blink-predicate): Add option to let user explicitly opt into or out of blinking point and mark. (region-indistinguishable-p): New function to detect "if there is currently no active region highlighting", leveraging face-differs-from-default-p. (indicate-copied-region): Use it. * etc/NEWS: Announce user option. --- etc/NEWS | 12 ++++++++++++ lisp/faces.el | 11 ++++++++++- lisp/simple.el | 22 ++++++++++++++++++++-- 3 files changed, 42 insertions(+), 3 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index e0175bacfdf..6a069b74332 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -59,6 +59,18 @@ This allows the user to customize the prompt that is appended by * Editing Changes in Emacs 30.1 +--- +** New user option 'copy-region-blink-predicate'. +By default, when copying a region with 'kill-ring-save', Emacs only +blinks point and mark when the region is not denoted visually, that +is, when either the region is inactive, or the 'region' face is +indistinguishable from the 'default' face. + +Users who would rather enable blinking unconditionally can now set +this user option to 'always'. To disable blinking unconditionally, +either set this option to 'ignore', or set 'copy-region-blink-delay' +to 0. + --- ** New command 'kill-matching-buffers-no-ask'. This works like 'kill-matching-buffers', but without asking for diff --git a/lisp/faces.el b/lisp/faces.el index 3323eab205a..4933b495a6c 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -304,7 +304,16 @@ face-differs-from-default-p If FRAME is t, report on the defaults for face FACE (for new frames). If FRAME is omitted or nil, use the selected frame." (let ((attrs - (delq :inherit (mapcar 'car face-attribute-name-alist))) + ;; The _value_ of :inherit teaches us nothing about how FACE + ;; looks compared to the default face. Instead, we will ask + ;; `face-attribute' to take inheritance into account when + ;; examining other attributes. + (delq :inherit + ;; A difference in extension past EOL only matters when + ;; relevant attributes (such as :background) also + ;; differ from the default; otherwise this difference + ;; is a false positive. + (delq :extend (mapcar 'car face-attribute-name-alist)))) (differs nil)) (while (and attrs (not differs)) (let* ((attr (pop attrs)) diff --git a/lisp/simple.el b/lisp/simple.el index 7bda368d85d..94b08543f44 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -5871,6 +5871,25 @@ copy-region-blink-delay :group 'killing :version "28.1") +(defcustom copy-region-blink-predicate #'region-indistinguishable-p + "Whether the cursor must be blinked after a copy. +When this condition holds, and the copied region fits in the +current window, `kill-ring-save' will blink the cursor between +point and mark for `copy-region-blink-delay' seconds." + :type '(radio (function-item region-indistinguishable-p) + (function-item :doc "Always blink point and mark." always) + (function-item :doc "Never blink point and mark." ignore) + (function :tag "Other predicate function")) + :group 'killing + :version "30.1") + +(defun region-indistinguishable-p () + "Whether the current region is not denoted visually. +This holds when the region is inactive, or when the `region' face +cannot be distinguished from the `default' face." + (not (and (region-active-p) + (face-differs-from-default-p 'region)))) + (defun indicate-copied-region (&optional message-len) "Indicate that the region text has been copied interactively. If the mark is visible in the selected window, blink the cursor between @@ -5891,8 +5910,7 @@ indicate-copied-region ;; was selected. Don't do it if the region is highlighted. (when (and (numberp copy-region-blink-delay) (> copy-region-blink-delay 0) - (or (not (region-active-p)) - (not (face-background 'region nil t)))) + (funcall copy-region-blink-predicate)) ;; Swap point and mark. (set-marker (mark-marker) (point) (current-buffer)) (goto-char mark) -- 2.39.0 --=-=-=--