From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#62009: 29.0.60; Emacs crashes on setf symbol-name Date: Fri, 10 Mar 2023 12:23:54 +0100 Message-ID: <87v8j84zp1.fsf@gmail.com> References: <87o7p5of4n.fsf@daniel-mendler.de> <871qm01s6n.fsf@web.de> <9fcf05e8-506c-6566-e214-2ecf3194b85e@daniel-mendler.de> <83bkl45ul4.fsf@gnu.org> <87v8j9zl3i.fsf@posteo.net> <83a60l13p2.fsf@gnu.org> <16ecbe9ea8ba9d39d058@heytings.org> <16ecbe9ea85b22d008fd@heytings.org> <43460d2c-ba80-0f2f-656c-ef0aca5667b5@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16603"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philip Kaludercic , michael_heerdegen@web.de, Gregory Heytings , monnier@iro.umontreal.ca, 62009@debbugs.gnu.org, Eli Zaretskii To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 10 12:25:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paasE-00040L-FA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Mar 2023 12:25:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paas1-0003DU-4b; Fri, 10 Mar 2023 06:25:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paaru-0003BK-S1 for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 06:25:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1paaru-0000ZE-4n for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 06:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1paart-0003oh-VT for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 06:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Mar 2023 11:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62009 X-GNU-PR-Package: emacs Original-Received: via spool by 62009-submit@debbugs.gnu.org id=B62009.167844744514567 (code B ref 62009); Fri, 10 Mar 2023 11:25:01 +0000 Original-Received: (at 62009) by debbugs.gnu.org; 10 Mar 2023 11:24:05 +0000 Original-Received: from localhost ([127.0.0.1]:53832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paaqz-0003mt-0U for submit@debbugs.gnu.org; Fri, 10 Mar 2023 06:24:05 -0500 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:43551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paaqx-0003mJ-9D for 62009@debbugs.gnu.org; Fri, 10 Mar 2023 06:24:03 -0500 Original-Received: by mail-ed1-f46.google.com with SMTP id x3so19021095edb.10 for <62009@debbugs.gnu.org>; Fri, 10 Mar 2023 03:24:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678447437; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S/hKncmTanA2DZZqQd6TizZDScLjczxPvXz/BQhYNR8=; b=pEjrbGepD+UIfAJ5kY+0PIzjPnzPkSu5AhSq400rhyWx/2UbioJruFMgciVfgtp087 QeWtkc738CSilzLF3NuBb/ivF1U+bCVd9gdtI7SjMPE9z6OTJew5FQGjpeSySUl3REN8 Dnx+/myYFgVsy8Pyi3Z5nHIU2s6ip3soIlaqBmddwt5uqDf/WFybMHe9k3B6AU5T8khG T23U3wal3dkg8ckXfrHJU+3xOaKdIhDLdZo62ZDbMGzPnay6YQabtOpG0RE6GLcEjmpo eziVa9cUwInjCFmnX/Vcv9dfSoGTciXlAAPBB/rELsvoXWZop2Ai0H4YMuVQLt+E4Ek8 EvGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678447437; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S/hKncmTanA2DZZqQd6TizZDScLjczxPvXz/BQhYNR8=; b=5QBQldw/b3m79ciRLE2XHwwrV0yu+5mxL6c5uMsjM/zuqm1NLoPfyetVL4Rh1DFVUh udgFt1x+HXa6gpXF2DMBsuMc0pwByMaurenCS+zke6j0hVpVZ5tUeewB8PLJgWPG1OTT R0n2RQw3fwnbztDoGC8/xQcV6P61F5mbCZGrxIfaKUfmT8kJddB7+Q2nab1IIuNDTYEP zTTXUtirRsflzgett5mNa5UX74Y7TBsHx2DppEn2pQs//2XewcckNF+hOxt7JpQBGw7f o7ct0ExBjMQxCfLO6vnoTo5mWoyZF0XAKCsx5tF+u7ytG5USiIG6x9yzHSRDT5CMrNWl HAOw== X-Gm-Message-State: AO0yUKV8y4sPvFPRge9XiWaRf7Ee4mgHzwgppIMz7nmsB330rGhjul7o cgwMVtvbexiIWaViPaCrEDSF3BwpEaf8xA== X-Google-Smtp-Source: AK7set8FuOZ1vxgvFdKwvcRu9hCcd/ydDVY2RuMTpzZBVTpXi+YGrTIEQEGD5ZQc3XHXaWtCbi89Nw== X-Received: by 2002:a17:906:398a:b0:88d:d700:fe15 with SMTP id h10-20020a170906398a00b0088dd700fe15mr25273399eje.0.1678447436810; Fri, 10 Mar 2023 03:23:56 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::8b3a]) by smtp.gmail.com with ESMTPSA id qc18-20020a170906d8b200b008d9c518a318sm852805ejb.142.2023.03.10.03.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 03:23:56 -0800 (PST) In-Reply-To: <43460d2c-ba80-0f2f-656c-ef0aca5667b5@daniel-mendler.de> (Daniel Mendler's message of "Fri, 10 Mar 2023 12:09:59 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257670 Archived-At: On Fri, 10 Mar 2023 at 12:09, Daniel Mendler wrote: > On 3/10/23 11:59, Gregory Heytings wrote: >> That would also come with a performance overhead, as there is currently = no=20 >> way to distinguist strings that are used for symbol names from other=20 >> strings. Not to mention the added complexity in the code. > > One could check if the string is located in read-only memory. Or one > could add a flag bit to the string data structure (and possibly to other > data structures too). Freezing data structures such that they become > read-only is a generally useful feature. There won't be any performance > overhead of the check since a branch not taken is fast thanks to the > branch predictor. Note also that in-place modification of strings is arbitrarily costly, cf. (aset "ascii" 0 ?=F0=9F=98=BC). Not to mention that it's rarely a good= or necessary move to make, as far as programming style is concerned.