From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63556: 29.0.90; Use of _Generic breaks Emacs build on GCC <4.9 Date: Thu, 18 May 2023 19:11:07 +0800 Message-ID: <87v8gp51ys.fsf@yahoo.com> References: <4b378d55-ef65-7a0f-b03d-e304785cf60d@cs.ucla.edu> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37099"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Spencer Baugh , 63556@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 18 13:12:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzbYW-0009Qh-JR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 May 2023 13:12:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzbYD-00050G-2w; Thu, 18 May 2023 07:12:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzbYA-000505-TM for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 07:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzbYA-0006YD-LZ for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 07:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzbYA-00079b-Gr for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 07:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 May 2023 11:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63556 X-GNU-PR-Package: emacs Original-Received: via spool by 63556-submit@debbugs.gnu.org id=B63556.168440828627435 (code B ref 63556); Thu, 18 May 2023 11:12:02 +0000 Original-Received: (at 63556) by debbugs.gnu.org; 18 May 2023 11:11:26 +0000 Original-Received: from localhost ([127.0.0.1]:52197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzbXa-00078R-EK for submit@debbugs.gnu.org; Thu, 18 May 2023 07:11:26 -0400 Original-Received: from sonic313-56.consmr.mail.ne1.yahoo.com ([66.163.185.31]:35975) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzbXX-00078C-Bh for 63556@debbugs.gnu.org; Thu, 18 May 2023 07:11:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1684408277; bh=vtw/ziophhvK6cjlIA9d7aE/2TncytZ5o5xxpWReitE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=VliNPLn8tv7BtY6TEg10CaEGMyS/v4eBDDcn7frQawhve1Rf69qfdqTuskQOQ4XBsnu3uFC+X2+T7fxqwM9+0eSl2WSyFT/6Fy6c0b88h+tg9gpNpS4Vstyqzh7pGSmPEyHLHHjjqBoSHE1vlvCAeY1Pp/l6n/AOgBKNAo8VWiFbGmD28yS7rBYhuCAK98YQ7iKKmdlLZMoEiMY2aMp5Kds2KVCOmasrEE8TLuS3ZReeOfbj60Nqcld09Ojed2xle2d1UPH3FpDYtMWD7s37wNRwE223uRV0h8ejV/tPy0H3bQBwgT4GZTUm46WM8ctk9GbGv5A3XVWgBWVQnG+WLw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1684408277; bh=G5O227zhCFVA+upS1ClxjA91THt68kgFQlvFJ+dFVaf=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=G2RXoM1V5YK30ZouHKU/FdMo93/q6D/DAjdEaGeeFt4IgNNMcQ/uiyOVVO1PT7f9oF4CoAN/W8ZOroSyNULUq3RMb60Q3aQYIjJht2Ekur9MCVuTFqRH/HRAcxHlPXMBglQzbRtdCERIs7OnqF0zDQXtvOXt+saIwua/TKrGUWbVMjH1Byq7ZKC8FmorTVWQggQLiwRXHfMgccQCen1I5PHmmFAWV3hKrdaoz1W8qGdEltb1UD2M4+L4MkSKtpW3FoghuGfECNf420YuG3y6DxcZiXuVL6laG45JH8ty4k6wj+VCys4xzLDgdNI2yA90OYmXnhxV7bQ5Z5b0y/tZTw== X-YMail-OSG: 4k6JMCUVM1lkqTmqAzXcZ9XM22MYc0k2MAh5yHBHWSamJdmq89QTak.WQPuhflz UFBomPBHchvsVHq2OkIe46hj3F.k291Nx03IjMGcMkZ7s6cBc0nKFxJJsl73n7w0JrHL5BqpFbDp fZb3dFTzmn_E2NT9SUU6pMeK5gGQMBl4zRJGguFUQxXwoorWiKupMuvjOzl9lYECzytB8NhO9vkQ sjCUonkLyq_ItNQJSZ71.3Hq2DYr5QWcvDWE1zanK08PGX0EtlI8SDTpO7vboqHGMfJK_jMhPN7M azTna0spskTL.nnl_5p6zzNmMdnp7zmNS6UU3W75qMuTKtnPxsZsnl2VDm_Q3nh3PwVTGdpBuv85 a__XX8BRKblKl7zY1vAPzhDcmHQbxcHZCf3NXm5mgdbFUKe3kQxM0Ccv1xS44ay7Ow4WbLcWZgjb orq6qkD3_Z1vc.cEumnPSPJS7uE.6Bs7NSTEZoe09394wj619Al7Jy1t378V6oNF_e3XI1rKSj5U sAsBEO9dMKVQRKIxTiQtFeFNeFap8ecz8m.yhJN32IiPiKCCcHmt2.M.Z2WVmS76L5i7FODtq3C7 fg1bJTYiET.lGjg0t1RW6CNl2JlWhGmvjvUCejTeVLZmVhMrD6l0nLRBsjImOgTX9_qystjZbyze wJEMBpwnlWT_ifTVdNhZK5d7Cs2fBSXXDq9RtunINSWjiy8qldNlDaCzZqUxGTVGEMkAUBFwSUae 36cnCa.GJU_lbio_exVgcZTofc03AdvFVu58BKxT8jQwhh25LURQ4utUxmc8JyKJVs7n_T761PdZ 9po7ftkHAjzIarL6tz77ab.A70uQ3oIpfPiaahvt9s X-Sonic-MF: X-Sonic-ID: 0ebed736-4f32-4c6e-8297-75538b03e2da Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Thu, 18 May 2023 11:11:17 +0000 Original-Received: by hermes--production-sg3-748897c457-w4b4d (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 2ced8e12de755f780756e10a69a3f6ed; Thu, 18 May 2023 11:11:12 +0000 (UTC) In-Reply-To: <4b378d55-ef65-7a0f-b03d-e304785cf60d@cs.ucla.edu> (Paul Eggert's message of "Wed, 17 May 2023 10:57:38 -0700") X-Mailer: WebService/1.1.21471 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261919 Archived-At: Paul Eggert writes: > Thanks for reporting the problem. Since _Generic is used here merely > as a micro-optimization on 32-bit platforms, it's not worth whatever > porting hassle you've run into, so I installed the attached patch so > that modiff no longer uses _Generic. Would anyone mind if I made configure check for that? Btw, couldn't the macro be defined to something along the lines of this when the compiler only supports C99? #define foo(expression) \ (sizeof (expression) == sizeof (signed char) \ ? code_for_signed_char \ : (sizeof (expression) == sizeof (short int) \ ? code_for_short_int \ : (sizeof (expression) == sizeof (int) \ ? code_for_int \ ... and so on